Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fixing crashes when comparing objects to nil" #34361

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Revert "Fixing crashes when comparing objects to nil" #34361

merged 1 commit into from
Jul 17, 2024

Conversation

woody-apple
Copy link
Contributor

Reverts #34321

@woody-apple woody-apple merged commit 0840ca6 into master Jul 17, 2024
30 of 32 checks passed
@woody-apple woody-apple deleted the revert-34321-Fixing-crash branch July 17, 2024 02:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

PR #34361: Size comparison from f4bf839 to f1e4cc4

Full report (41 builds for cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, stm32)
platform target config section f4bf839 f1e4cc4 change % change
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667713 667713 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 687565 687565 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 644509 644509 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609329 609329 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628965 628965 0 0.0
RAM 73356 73356 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 625057 625057 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76372 76372 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 593429 593429 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 613281 613281 0 0.0
RAM 70420 70420 0 0.0
efr32 lighting-app BRD4187C FLASH 924668 924660 -8 -0.0
RAM 137528 137528 0 0.0
lock-app BRD4338a FLASH 733916 733908 -8 -0.0
RAM 207892 207892 0 0.0
window-app BRD4187C FLASH 1012700 1012692 -8 -0.0
RAM 129632 129632 0 0.0
esp32 all-clusters-app c3devkit DRAM 90860 90860 0 0.0
FLASH 1470728 1470728 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117340 117340 0 0.0
FLASH 1539579 1539579 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2531376 2531376 0 0.0
RAM 125112 125112 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5592478 5592478 0 0.0
RAM 493240 493240 0 0.0
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5065568 5065568 0 0.0
RAM 235704 235704 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4479776 4479776 0 0.0
RAM 212832 212832 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11797879 11797879 0 0.0
RAM 547618 547618 0 0.0
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10877607 10877607 0 0.0
RAM 544394 544394 0 0.0
fabric-bridge-app debug unknown 4544 4544 0 0.0
FLASH 4247344 4247344 0 0.0
RAM 198872 198872 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5384162 5384162 0 0.0
RAM 224136 224136 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4546128 4546128 0 0.0
RAM 200456 200456 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4199216 4199216 0 0.0
RAM 194544 194544 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4324544 4324544 0 0.0
RAM 199168 199168 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2805869 2805869 0 0.0
RAM 153008 153008 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5627776 5627776 0 0.0
RAM 342120 342120 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9967950 9967950 0 0.0
RAM 402936 402936 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1502972 1502972 0 0.0
RAM 226648 226648 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882696 882696 0 0.0
RAM 142229 142229 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 953128 953128 0 0.0
RAM 140657 140657 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 828172 828172 0 0.0
RAM 141123 141123 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1615620 1615620 0 0.0
RAM 209692 209692 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1536508 1536508 0 0.0
RAM 206588 206588 0 0.0
light cy8ckit_062s2_43012 FLASH 1463108 1463108 0 0.0
RAM 199876 199876 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463868 1463868 0 0.0
RAM 224388 224388 0 0.0
stm32 light STM32WB5MM-DK FLASH 473784 473784 0 0.0
RAM 144196 144196 0 0.0

j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this pull request Jul 31, 2024
@woody-apple @j-ororke
Revert "Fixing crashes when comparing objects to nil" (project-chip#3…
47f6bab 
…4361)

This reverts commit 2d789f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woody-apple