Add an Action Switch endpoint to all-clusters-app #34355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Action Switch is a new feature for a TCR - Need to have the ZAP files updated before adding the logic to reduce review burden. - Re-ran zap_convert_all.py (some of the changes are due to that) Issue project-chip#34304 Testing done: - No regressions of integration tests
|
PR #34355: Size comparison from 1da085d to f7a5d43 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34355: Size comparison from 1da085d to 1a73727 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 16, 2024
|
At least one of the Darwin test failures is due to this All up there are 40 failing test cases, not sure if they all make similar assumptions about what endpoints there are in all-clusters. @bzbarsky-apple ? |
|
PR #34355: Size comparison from 1da085d to 83e99e8 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
I don't think they all do. So I'd fix those two and see what things look like. |
|
PR #34355: Size comparison from 1da085d to da71dca Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Jul 17, 2024
|
PR #34355: Size comparison from a30dd12 to 79445bf Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Fix the Darwin tests to actually pass.
|
PR #34355: Size comparison from a30dd12 to ce85698 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add an Action Switch endpoint to all-clusters-app - Action Switch is a new feature for a TCR - Need to have the ZAP files updated before adding the logic to reduce review burden. - Re-ran zap_convert_all.py (some of the changes are due to that) Issue project-chip#34304 Testing done: - No regressions of integration tests * Fix integration test * Try to fix Darwin tests * Attempt to fix tests some more * Fix Darwin tests * Restyled by clang-format * Fix the Darwin tests to actually pass. * Fix typos --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #34304
Testing done: