Add water heater mode to sdk and all-clusters-app #34351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
PR #34351: Size comparison from 74768a8 to 963017e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34351: Size comparison from 74768a8 to 5571e88 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jamesharrow
changed the title
|
It looks like the chip-repl test cases are failing with a memory leak issue. VerifyOrDie failure at src/lib/support/IntrusiveList.h:290: Empty() |
This PR https://github.com/project-chip/connectedhomeip/pull/28163/files has the need to call Shutdown for each of the modes. Will see if I can push a fix for it. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu and
chulspro
|
PR #34351: Size comparison from b88ac27 to 74f14e7 Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34351: Size comparison from b88ac27 to a2983d2 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #34351: Size comparison from b88ac27 to ce728eb Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34351: Size comparison from b88ac27 to 6acca68 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34351: Size comparison from b88ac27 to 898dccb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/all-clusters-app/all-clusters-common/src/water-heater-mode.cpp
Outdated
Show resolved
Hide resolved
|
PR #34351: Size comparison from 3bc5667 to 1ea0072 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 24, 2024
andy31415
reviewed
Jul 25, 2024
examples/all-clusters-app/all-clusters-common/include/water-heater-mode.h
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Jul 25, 2024
|
PR #34351: Size comparison from c91a779 to 16198cd Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34351: Size comparison from ba949bf to 4ff2071 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add water heater mode cluster * Get all-clusters-app building with water-heater-mode * Restyled by clang-format * Added call to WaterHeaterMode::Shutdown() to fix IntrusiveList not being freed at exit. * Added missing #include "water-heater-mode.h" to main-common.cpp * Regenerated files * Update following review comments from Andrei Litvin * Fix compilation error * Restyled by clang-format * Update after review comment from Boris * WaterHeaterMode moved to future section * Update examples/all-clusters-app/all-clusters-common/include/water-heater-mode.h Co-authored-by: Andrei Litvin <[email protected]> * Address final set of review comments from Andrei --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: jamesharrow <[email protected]> Co-authored-by: James Harrow <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add water heater mode cluster * Get all-clusters-app building with water-heater-mode * Restyled by clang-format * Added call to WaterHeaterMode::Shutdown() to fix IntrusiveList not being freed at exit. * Added missing #include "water-heater-mode.h" to main-common.cpp * Regenerated files * Update following review comments from Andrei Litvin * Fix compilation error * Restyled by clang-format * Update after review comment from Boris * WaterHeaterMode moved to future section * Update examples/all-clusters-app/all-clusters-common/include/water-heater-mode.h Co-authored-by: Andrei Litvin <[email protected]> * Address final set of review comments from Andrei --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: jamesharrow <[email protected]> Co-authored-by: James Harrow <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add water heater mode cluster support to the all-cluster-app (issue Fixes #34253)
The water heater mode cluster spec can be found here:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/82b2966af17528ab88308ae2341142300ad8a3cb/src/app_clusters/Mode_WaterHeater.adoc
This PR follows a serial of PRs starting with #34333