[Python] Adjust logging levels in Python controller #34346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34346: Size comparison from 74768a8 to 84e8061 Full report (3 builds for cc32xx, stm32)
|
Use global loggers per-module which is more Pythonic and avoids unnecessary logger instances. Also use the module name as the logger name consistently. Avoid using the warning level for messages which are really only informational. Also lower the log level of storage messages to debug, as they are really not that important. Drop some unnecessary logs like on every storage commit.
agners
force-pushed
the
improve-python-logging
branch
from
84e8061 to
876d802
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34346: Size comparison from 74768a8 to 876d802 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Jul 16, 2024
yufengwangca
approved these changes
Jul 16, 2024
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Jul 17, 2024
By default the Python controller gets built with unit test configuration enabled. This adds extra functionality to inject errors etc. for testing. There is no known negative effect to have it enabled, but it is certainly better to disable it for a production setup. Furthermore this fixes error handling for APIs with callbacks and improves logging somewhat. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#34346 - project-chip/connectedhomeip#34354 - project-chip/connectedhomeip#34368
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
Use global loggers per-module which is more Pythonic and avoids unnecessary logger instances. Also use the module name as the logger name consistently. Avoid using the warning level for messages which are really only informational. Also lower the log level of storage messages to debug, as they are really not that important. Drop some unnecessary logs like on every storage commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use global loggers per-module which is more Pythonic and avoids unnecessary logger instances. Also use the module name as the logger name consistently.
Avoid using the warning level for messages which are really only informational. Also lower the log level of storage messages to debug, as they are really not that important. Drop some unnecessary logs like on every storage commit.