Fix DNS-SD TCP advertisement to use a bitmap for Client and Server. #34289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34289: Size comparison from bf4edc4 to 7c5a663 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 11, 2024
pidarped
force-pushed
the
DNSAdvertiseTCP
branch
from
7c5a663 to
911153c
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
|
PR #34289: Size comparison from d856745 to 911153c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 12, 2024
andy31415
reviewed
Jul 12, 2024
|
@pidarped please update the PR summary. The title is insufficient: "fix the DNSSD to use a bitmap" ... what got fixed? what was the problem, what is the change containing and how was it tested? can we have some form of unit testing? We should know what to expect in the PR content by reading the PR summary. |
andy31415
reviewed
Jul 12, 2024
andy31415
reviewed
Jul 12, 2024
bzbarsky-apple
requested changes
Jul 12, 2024
pidarped
force-pushed
the
DNSAdvertiseTCP
branch
from
911153c to
864b170
Compare
|
PR #34289: Size comparison from 05e4c10 to 864b170 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 18, 2024
When TCP is enabled, a node, currently, advertises as both a Client and Server.
pidarped
force-pushed
the
DNSAdvertiseTCP
branch
from
864b170 to
9c78a97
Compare
|
PR #34289: Size comparison from e7380a1 to 9c78a97 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…roject-chip#34289) When TCP is enabled, a node, currently, advertises as both a Client and Server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec currently advertises TCP support independently for TCP client and server in a bitmap form. The reception logic supports this advertisement model but the advertising side was not using this mode.
This PR updates the advertisement sending side to support the same.