-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AttributePathExpandIterator to be able to use the IM/DM DataModel split #34288
Update AttributePathExpandIterator to be able to use the IM/DM DataModel split #34288
Conversation
PR #34288: Size comparison from a30dd12 to 29f9cb0 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34288: Size comparison from 5bc3088 to d451f5a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…le expect even if we guarantee perfect overlap
PR #34288: Size comparison from 99ea3e6 to 1e7cfbd Full report (20 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
PR #34288: Size comparison from 4ec643c to 108ef01 Full report (16 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
PR #34288: Size comparison from 5e274d9 to cb42ae6 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #34288: Size comparison from ba375be to c3fa7d4 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #34288: Size comparison from ba375be to 0c4134b Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…del split (project-chip#34288) * Ember invoke implementation with unit tests inside DataModel * Support ember/datamodel/dual(checked) attribute path expand iterators * Code review comments * Fix interactionmodel::status compilation in icd-management-server when ICD is on * Do not include CodegeDataModelInstance if we do not use the codegen data model * Fix linter * Fix java controller linkage. This is still broken: there should be no reason java should want ember, yet here we are (with odd dependencies inside libCHIP) * Fix Amebad compilation: OUT is defined in Ameba * Update log formatting * Review comment: use GlobalAttributesNotInMetadata directly * Remove debug bits * Code review update: we just need to match next logic in the ember code in the dm code. * Restyle * Do not check for differences if result is false ... this is what people expect even if we guarantee perfect overlap * Fix typo * Restyle * Update src/app/AttributePathExpandIterator-DataModel.cpp Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Changes
Ember
representing the old code identicallyDataModel
that uses the data model interface exclusivelyChecked
that runs both Ember and DataModel in parallel and asserts that the outputs are identicalchip_use_data_model_interface
that has enabled/disabled/check. Linux defaults to check (slower runs, however will exercise all unit tests and integration tests to run the interfaces in parallel) all others default to disabled to have minimal deltasDataModel
available. In particularInteractionModelEngine
provides a datamodel that defaults to the codegendatamodel (i.e. ember) if not setInteractionModel namespace is duplicated with
chip::Protocols::InteractionModel
so some namespaces/using logic had to be updated.Low coverage for
Checked
is because the error reporting lines are never reached (all tests pass).