move AttemptToGetTimeFromTrustedNode out of TIME_SYNC_ENABLE_TSC_FEATURE blocks #34273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URE since it is called out of TIME_SYNC_ENABLE_TSC_FEATURE blocks
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
mykrupp
added a commit
to SiliconLabsSoftware/matter_extension
that referenced
this pull request
Jul 10, 2024
|
PR #34273: Size comparison from 47fee48 to 32d9b7f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/clusters/time-synchronization-server/time-synchronization-server.h
Show resolved
Hide resolved
cecille
approved these changes
Jul 10, 2024
jmartinez-silabs
approved these changes
Jul 11, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
…URE since it is called out of TIME_SYNC_ENABLE_TSC_FEATURE blocks (project-chip#34273)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… since it is called out of TIME_SYNC_ENABLE_TSC_FEATURE blocks
AttemptToGetTimeFromTrustedNode() is called outside of TIME_SYNC_ENABLE_TSC_FEATURE blocks, so it should be declared outside of a TIME_SYNC_ENABLE_TSC_FEATURE. Otherwise, if the time sync client feature is turned off (time_sync_enable_tsc_feature = 0), we get a build error - error: 'AttemptToGetTimeFromTrustedNode' was not declared in this scope