Fix door lock endpoint initialization. #34270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few issues here: * DoorLockServer::InitServer was resetting endpoint state for all endpoints when initializing any endpoint. * We had two separate arrays of per-endpoint data, one for the endpoint context, one for the delegate. The fix is to not touch the state of other endpoints when initializing an endpoint and to put all the per-endpoint state in one place.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34270: Size comparison from 8ebe19d to db06bd2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Jul 10, 2024
nivi-apple
reviewed
Jul 10, 2024
nivi-apple
reviewed
Jul 10, 2024
nivi-apple
approved these changes
Jul 10, 2024
Co-authored-by: Nivi Sarkar <[email protected]>
|
PR #34270: Size comparison from 8ebe19d to 837685a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 11, 2024
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* Fix door lock endpoint initialization. A few issues here: * DoorLockServer::InitServer was resetting endpoint state for all endpoints when initializing any endpoint. * We had two separate arrays of per-endpoint data, one for the endpoint context, one for the delegate. The fix is to not touch the state of other endpoints when initializing an endpoint and to put all the per-endpoint state in one place. * Apply suggestions from code review Co-authored-by: Nivi Sarkar <[email protected]> --------- Co-authored-by: Nivi Sarkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues here:
The fix is to not touch the state of other endpoints when initializing an endpoint and to put all the per-endpoint state in one place.