[Darwin] MTRDeviceController getSessionForNode should always use live MTRDevice object #34269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re using subscription/CASE pool
|
PR #34269: Size comparison from c91c3e0 to a385168 Full report (75 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Jul 9, 2024
woody-apple
reviewed
Jul 9, 2024
woody-apple
reviewed
Jul 9, 2024
Co-authored-by: Justin Wood <[email protected]>
|
PR #34269: Size comparison from c91c3e0 to 0685340 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
mhazley,
mkardous-silabs,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
younghak-hwang and
yufengwangca
bzbarsky-apple
approved these changes
Jul 10, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #34269: Size comparison from c91c3e0 to f001bd1 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
… MTRDevice object (project-chip#34269) * [Darwin] MTRDeviceController should always examine the MTRDevice before using subscription/CASE pool * Update src/darwin/Framework/CHIP/MTRDevice.mm Co-authored-by: Justin Wood <[email protected]> * Update src/darwin/Framework/CHIP/MTRDeviceController.mm Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the MTRDeviceController API client doesn't retain MTRDevice objects for known node IDs, the next
getSessionForNodecall may not know if the device uses Thread, and doesn't make use of the CASE/subscription pool mechanism to behave well on the network.