Darwin: Ensure we tell the OTA delegate when a transfer ends #34190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AssertIdentical for obejct identity tests Fulfill expectations at the start of callback blocks before calling more methods
Ensure we call handleBDXTransferSessionEndForNodeID:... if we have called handleBDXTransferSessionBeginForNodeID:..., even if the session is reset via an error code path.
|
PR #34190: Size comparison from f199ba4 to f17fedc Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 4, 2024
|
PR #34190: Size comparison from f199ba4 to 97de59c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Fast-tracking Darwin-only change. |
|
PR #34190: Size comparison from f199ba4 to 022d8de Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…t-chip#34190) * Darwin: Tweak OTA provider test to make it easier to extend Use AssertIdentical for obejct identity tests Fulfill expectations at the start of callback blocks before calling more methods * Darwin: Ensure we tell the OTA delegate when a transfer ends Ensure we call handleBDXTransferSessionEndForNodeID:... if we have called handleBDXTransferSessionBeginForNodeID:..., even if the session is reset via an error code path. * Remove TODO clarified in review * restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we call
handleBDXTransferSessionEndForNodeID:...if we have calledhandleBDXTransferSessionBeginForNodeID:..., even if the session is reset via anerror code path.