[NXP] Add some common platform changes #34159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34159: Size comparison from 005f1b4 to 01406e2 Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
marius-alex-tache
force-pushed
the
nxp-common-platform-changes
branch
from
01406e2 to
a18a7d2
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #34159: Size comparison from 005f1b4 to a18a7d2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Where are the "legacy" files used?
Adding new files without linking in source code feels off, especially if they are "legacy" (i.e. probably should not be used anymore)?
Why do we do this? If this is to preserve old copies, why is git history not sufficient for that?
andy31415
requested changes
Jul 2, 2024
|
Hi, @andy31415. The folder is called legacy because these files are mainly used by k32w0 (which is based on a legacy SDK). I should have specified that these files will be used by some upcoming changes. I am waiting for @chapongatien's PR related to NXP matter support submodule to be merged. Once that is done, I can clean the k32w0 further and sync what we have internally. So this is just an intermediate step and the files will eventually be used. If it is clunky, I can remove this commit for now and just keep the changes to the common NXP part. |
marius-alex-tache
force-pushed
the
nxp-common-platform-changes
branch
from
a18a7d2 to
c0894ce
Compare
|
I've removed the commits. Will add them in the future. |
|
PR #34159: Size comparison from 4ef104b to c0894ce Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jul 5, 2024
Signed-off-by: Martin Girardot <[email protected]>
- Add StoreSoftwareUpdateCompleted API with empty implementation - Add ICD flags in common config header - Create CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE flag for BLE Zephry usage - Enclose CHIPDevicePlatformEvent header sections under CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE - Enclose lwip specific headers under CHIP_SYSTEM_CONFIG_USE_LWIP - Add temporary flag CHIP_DEVICE_CONFIG_INIT_OT_PLAT_ALARM to condition otPlatAlarmInit call. Some platforms are doing this separately and two calls will break things. - Add CHIP_DEVICE_CONFIG_PROCESS_BLE_IN_THREAD flag to override ProcessThreadActivity by extending its default implementation. Some platforms opt to do the BLE processing inside the Thread task, to avoid creating a separate BLE app task. Signed-off-by: marius-alex-tache <[email protected]>
marius-alex-tache
force-pushed
the
nxp-common-platform-changes
branch
from
c0894ce to
5f7e16a
Compare
|
PR #34159: Size comparison from 6e31453 to 5f7e16a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
approved these changes
Jul 10, 2024
lazarkov
pushed a commit
to lazarkov/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* [NXP][platform][common] Add support of boot reason Signed-off-by: Martin Girardot <[email protected]> * [NXP][platform][common] Update some components - Add StoreSoftwareUpdateCompleted API with empty implementation - Add ICD flags in common config header - Create CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE flag for BLE Zephry usage - Enclose CHIPDevicePlatformEvent header sections under CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE - Enclose lwip specific headers under CHIP_SYSTEM_CONFIG_USE_LWIP - Add temporary flag CHIP_DEVICE_CONFIG_INIT_OT_PLAT_ALARM to condition otPlatAlarmInit call. Some platforms are doing this separately and two calls will break things. - Add CHIP_DEVICE_CONFIG_PROCESS_BLE_IN_THREAD flag to override ProcessThreadActivity by extending its default implementation. Some platforms opt to do the BLE processing inside the Thread task, to avoid creating a separate BLE app task. Signed-off-by: marius-alex-tache <[email protected]> --------- Signed-off-by: Martin Girardot <[email protected]> Signed-off-by: marius-alex-tache <[email protected]> Co-authored-by: Martin Girardot <[email protected]>
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* [NXP][platform][common] Add support of boot reason Signed-off-by: Martin Girardot <[email protected]> * [NXP][platform][common] Update some components - Add StoreSoftwareUpdateCompleted API with empty implementation - Add ICD flags in common config header - Create CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE flag for BLE Zephry usage - Enclose CHIPDevicePlatformEvent header sections under CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE - Enclose lwip specific headers under CHIP_SYSTEM_CONFIG_USE_LWIP - Add temporary flag CHIP_DEVICE_CONFIG_INIT_OT_PLAT_ALARM to condition otPlatAlarmInit call. Some platforms are doing this separately and two calls will break things. - Add CHIP_DEVICE_CONFIG_PROCESS_BLE_IN_THREAD flag to override ProcessThreadActivity by extending its default implementation. Some platforms opt to do the BLE processing inside the Thread task, to avoid creating a separate BLE app task. Signed-off-by: marius-alex-tache <[email protected]> --------- Signed-off-by: Martin Girardot <[email protected]> Signed-off-by: marius-alex-tache <[email protected]> Co-authored-by: Martin Girardot <[email protected]>
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 18, 2024
* [NXP][platform][common] Add support of boot reason Signed-off-by: Martin Girardot <[email protected]> * [NXP][platform][common] Update some components - Add StoreSoftwareUpdateCompleted API with empty implementation - Add ICD flags in common config header - Create CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE flag for BLE Zephry usage - Enclose CHIPDevicePlatformEvent header sections under CHIP_DEVICE_CONFIG_USE_ZEPHYR_BLE - Enclose lwip specific headers under CHIP_SYSTEM_CONFIG_USE_LWIP - Add temporary flag CHIP_DEVICE_CONFIG_INIT_OT_PLAT_ALARM to condition otPlatAlarmInit call. Some platforms are doing this separately and two calls will break things. - Add CHIP_DEVICE_CONFIG_PROCESS_BLE_IN_THREAD flag to override ProcessThreadActivity by extending its default implementation. Some platforms opt to do the BLE processing inside the Thread task, to avoid creating a separate BLE app task. Signed-off-by: marius-alex-tache <[email protected]> --------- Signed-off-by: Martin Girardot <[email protected]> Signed-off-by: marius-alex-tache <[email protected]> Co-authored-by: Martin Girardot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: