Zephyr standalone platform update #34135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to let the user choose his own pack of functionality. I guess BLUETOOTH shouldn't be enable by default, because Bluetooth isn't mandatory for a Matter device Signed-off-by: Caldeira, Quentin <[email protected]>
Because zephyr has recvmsg now Signed-off-by: Caldeira, Quentin <[email protected]>
Because Zephyr seems to not have ip_mreq, only ip_mreqn, so add an extra flag in platform config to make the choice. This issue is only meets when doing ipv4 on a Zephyr platform Signed-off-by: Caldeira, Quentin <[email protected]>
Signed-off-by: Caldeira, Quentin <[email protected]>
Signed-off-by: Caldeira, Quentin <[email protected]>
|
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi and
fessehaeve
Since zephyr implement recvsg now Signed-off-by: Caldeira, Quentin <[email protected]>
Signed-off-by: Caldeira, Quentin <[email protected]>
Signed-off-by: Caldeira, Quentin <[email protected]>
|
PR #34135: Size comparison from 0460715 to 6e3d2ce Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Jun 28, 2024
|
First of all Thanks for filing this PR, I want to try Matter on ESP using Zephyr, and Luckily this PR came in right at the time for me. Following are the steps
Following is the error I'm getting. Let me know if i missed any step, or you could help me here. It will be really helpful |
|
Hey @biii-anuj-pathak, I don't know if it's the right place to discuss this, but here are the first things I think of.
By the way, if I can see the example you are building, it will help me to test this PR. [EDIT] It seems to be a missing bootstrap because |
As discussed in conversations Signed-off-by: Caldeira, Quentin <[email protected]>
|
PR #34135: Size comparison from d033f8b to 4def860 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Hi @Damian-Nordic, I don't understand why nrf build doesn't pass. Any idea ? |
|
@QuentinCaldeira-eaton Most likely because you added You can guard the include with |
Signed-off-by: Caldeira, Quentin <[email protected]>
|
PR #34135: Size comparison from d033f8b to ebbaf34 Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
Because all manufactures don't implement it Signed-off-by: Caldeira, Quentin <[email protected]>
|
PR #34135: Size comparison from d033f8b to 40acc38 Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Seems to do the trick, thanks ! Now Darwin platform causing trouble. I don't if it's alarming or not. |
|
@Damian-Nordic, I don't understand why Darwin failed. Any idea ? |
|
Hi, Could you give us (NXP) some time to review this PR ? We are also using zephyr with matter but we don't have workflows setup yet (coming soon, we are working on it). So we just need to check if it's ok on our end. Thanks ! |
|
@axelnxp Yes, of course. Do I need to do something else or everything is okay ? |
|
@QuentinCaldeira-eaton looks good to us, you can go ahead, thanks ! |
|
@axelnxp Thanks ! I'm just waiting for approval. If one day you have some time, could I discuss with you about Matter with Zephyr ? |
andy31415
approved these changes
Jul 2, 2024
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
* fix zephyr build (west) * Use different Kconfig In order to let the user choose his own pack of functionality. I guess BLUETOOTH shouldn't be enable by default, because Bluetooth isn't mandatory for a Matter device Signed-off-by: Caldeira, Quentin <[email protected]> * Remove ZephyrSocket Because zephyr has recvmsg now Signed-off-by: Caldeira, Quentin <[email protected]> * Support ip_mreq and ip_mreqn Because Zephyr seems to not have ip_mreq, only ip_mreqn, so add an extra flag in platform config to make the choice. This issue is only meets when doing ipv4 on a Zephyr platform Signed-off-by: Caldeira, Quentin <[email protected]> * Add missing functions to BLE Signed-off-by: Caldeira, Quentin <[email protected]> * Add specific configs and dependencies for Zephyr platform Signed-off-by: Caldeira, Quentin <[email protected]> * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Revert "Remove ZephyrSocket" This reverts commit f283940. Also, fix things discussed with Damian-Nordic Signed-off-by: Caldeira, Quentin <[email protected]> * Don't use ZephyrSocket.h Since zephyr implement recvsg now Signed-off-by: Caldeira, Quentin <[email protected]> * Remove git artifact Signed-off-by: Caldeira, Quentin <[email protected]> * Restyled by whitespace * Restyled by clang-format * Re-add ZephyrSocket.h include Signed-off-by: Caldeira, Quentin <[email protected]> * Remove BLE Read declarations As discussed in conversations Signed-off-by: Caldeira, Quentin <[email protected]> * Allow net_if only with Ethernet or Wifi connection Signed-off-by: Caldeira, Quentin <[email protected]> * Check if Ethernet is defined Because all manufactures don't implement it Signed-off-by: Caldeira, Quentin <[email protected]> * Restyled by clang-format --------- Signed-off-by: Caldeira, Quentin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #33471 and #33777, the purpose of this PR is to leave open the possibility of using the Zephyr platform as a standalone platform, working with any boards present in Zephyr (which has network connectivity, enough flash, etc...). For testing purposes, I use a nucleo h563zi. This standalone platform should be used for manufacturers working on Zephyr, but also for people which would like to implement Matter in an unsupported board, using Zephyr OS. This zephyr "module" should simplify developer's life on the Zephyr platform.
Currently, zephyr platform can't be used in a Zephyr ecosystems without modifications, that's why I made that. My guess is anybody which has his board into Zephyr, like ESP or ST, could use the zephyr standalone platform to develop a product. With this, it is not mandatory to use a specific manufacturer zephyr sdk.
It would be great to also develop an example (like lighting-app) which work for the Zephyr SDK, but my knowledge on the Matter stack are very limited currently.
To sum-up, this PR make changes in order to have a functional connectedhomeip, as a Zephyr sdk module.