[ESP32] Remove SupportedModes implementation of ModeSelect from nvs and use all-clusters-apps common implementation #34044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jadhavrohit924
commented
Jun 24, 2024
jadhavrohit924
commented
- Remove SupportedModes implementation of ModeSelect from nvs and use all-clusters-apps common implementation.
- Tested esp32/all-clusters-app
|
PR #34044: Size comparison from 07ac2f1 to 3193638 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…nd use all-clusters-apps common implementation
jadhavrohit924
force-pushed
the
fix/esp32_mode_select
branch
from
3193638 to
c1dcb34
Compare
github-actions
bot
added
the
documentation
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34044: Size comparison from 7c04979 to c1dcb34 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jun 26, 2024
|
Can you try any other example (lighting-app) as well? |
Done. It's working fine. |
dhrishi
approved these changes
Jul 1, 2024
|
@jadhavrohit924 This PR does not seem to explain WHY the implementation was removed. I imagine common code is better than specific code, however it is still useful to actually explain changes. For example I do not understand why we got #34191 as a revert now. The history of this seems to be just "tested and it works fine" and it does not explain the intent behind the change (and revert is not explained either) |
|
@andy31415 Sorry for the inconvenience. Actually, we thought of using common implementation and planned to remove this fixed attributes from the factory partition because of while OTA, we cannot update these attributes as factory partition can’t be change in OTA. But later we thought of supporting this fixed attributes in the factory partition for backward compatibility along with SDKs common implementation which has static data. |
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…nd use all-clusters-apps common implementation (project-chip#34044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.