[Python] Convert DiscoverCommissionableNodes to asyncio #34033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34033: Size comparison from e407d40 to 7e03b1c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Make the discovery of commissionable nodes Python asyncio APIs as well. This avoids blocking the event loop when using the API. The implementation is also safe to be used with the Python asyncio wait_for() function: The discovery process will be cancelled if the timeout is reached.
agners
force-pushed
the
convert-discovery-api-to-asyncio
branch
from
7e03b1c to
93c2b1f
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #34033: Size comparison from 281363b to 93c2b1f Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 20, 2024
arkq
approved these changes
Jun 21, 2024
pimpalemahesh
pushed a commit
to pimpalemahesh/connectedhomeip
that referenced
this pull request
Jun 24, 2024
…#34033) * [Python] Convert DiscoverCommissionableNodes to asyncio Make the discovery of commissionable nodes Python asyncio APIs as well. This avoids blocking the event loop when using the API. The implementation is also safe to be used with the Python asyncio wait_for() function: The discovery process will be cancelled if the timeout is reached. * [Python] Adjust tests to use new DiscoverCommissionableNodes API
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Jul 1, 2024
Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#34033
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…#34033) * [Python] Convert DiscoverCommissionableNodes to asyncio Make the discovery of commissionable nodes Python asyncio APIs as well. This avoids blocking the event loop when using the API. The implementation is also safe to be used with the Python asyncio wait_for() function: The discovery process will be cancelled if the timeout is reached. * [Python] Adjust tests to use new DiscoverCommissionableNodes API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the discovery of commissionable nodes Python asyncio APIs as well. This avoids blocking the event loop when using the API.
The implementation is also safe to be used with the Python asyncio wait_for() function: The discovery process will be cancelled if the timeout is reached.