Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update App Install Flow & Attribute Retrieval Status Errors #33961

Closed

Conversation

lazarkov
Copy link
Contributor

Resolving issues from 33445 and from 33827

Problem

  1. Reporting supported clusters has a reflection error
  2. App Installation Service is not added for android and that blocks the commissioning flow

Change overview

  • Resolved reflection error
  • Added and update app installation service for both linux and android

Tests 1

  1. Build the TV app using command:
    scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/

  2. Build the TV casting app using command:
    scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/

  3. Start TV App
    out/debug/chip-tv-app

  4. Start TV Casting App
    out/debug/chip-tv-casting-app

  5. On TV App: Uninstall the app
    app uninstall 65521 32769

  6. On TV Casting App: Send casting request to the tv-app using
    cast request 0

  7. On TV App: Accepted the Cast request from the tv-casting app
    controller ux ok

  8. On TV App: Enter the PIN code (passcode)
    controller ux ok 20202021

Tests 2

  1. Build and installed TV Android Platform app
    scripts/examples/gn_android_example.sh examples/tv-app/android out/android-arm-chip-tvserver

  2. Build the TV casting app using command:
    scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/

  3. Build and installed TV Android Content app

  4. Run TV Platform App and saw that correct supported cluster list was reported.

Copy link

github-actions bot commented Jun 17, 2024

PR #33961: Size comparison from 8ba371a to 69623e2

Full report (7 builds for efr32, mbed, nrfconnect)
platform target config section 8ba371a 69623e2 change % change
efr32 lighting-app BRD4187C FLASH 888232 888224 -8 -0.0
RAM 183424 183424 0 0.0
lock-app BRD4338a FLASH 699848 699848 0 0.0
RAM 242228 242228 0 0.0
window-app BRD4187C FLASH 969748 969748 0 0.0
RAM 167856 167856 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497580 0 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876200 876200 0 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949232 949232 0 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822416 822416 0 0.0
RAM 138027 138027 0 0.0

@lazarkov lazarkov changed the title Update App Install Flow Error & Attribute Retrieval Status Update App Install Flow & Attribute Retrieval Status Errors Jun 18, 2024
Copy link

github-actions bot commented Jun 18, 2024

PR #33961: Size comparison from 4cdce52 to 2e6e42a

Full report (4 builds for mbed, nrfconnect)
platform target config section 4cdce52 2e6e42a change % change
mbed lock-app-release cy8cproto_062_4343w FLASH 1497580 1497580 0 0.0
RAM 226072 226072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 876200 876200 0 0.0
RAM 139129 139129 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949232 949232 0 0.0
RAM 137557 137557 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822416 822416 0 0.0
RAM 138027 138027 0 0.0

@lazarkov lazarkov enabled auto-merge (squash) June 18, 2024 11:14
@lazarkov lazarkov closed this Jun 18, 2024
auto-merge was automatically disabled June 18, 2024 11:19

Pull request was closed

@lazarkov lazarkov deleted the feature/fix-tv-app-install-flow-and-supported-clusters branch June 18, 2024 11:19
Copy link

mergify bot commented Jun 18, 2024

⚠️ The sha of the head commit of this PR conflicts with #33981. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants