[Draft] Re-Implement App Install flow #33959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,6 +225,7 @@ CHIP_ERROR ApplicationBasicAttrAccess::ReadApplicationAttribute(app::AttributeVa | |||
|
|
|||
| CHIP_ERROR ApplicationBasicAttrAccess::ReadStatusAttribute(app::AttributeValueEncoder & aEncoder, Delegate * delegate) | |||
| { | |||
| ChipLogProgress(DeviceLayer, "Here 1"); | |||
There was a problem hiding this comment.
Suggested change
| ChipLogProgress(DeviceLayer, "Here 1"); | |
| ChipLogProgress(DeviceLayer, "ApplicationBasicAttrAccess::ReadStatusAttribute"); |
| <item name="NotInstalled" value="0x04"/> | ||
| <item name="Installing" value="0x05"/> | ||
| <item name="InstallationFailed" value="0x06"/> | ||
| <item name="Installed" value="0x07"/> |
There was a problem hiding this comment.
Seems like the first 4 states indicate Installed. When would we need this state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-Implementing application installation flow
Problem
Current application installation flow blocks commissioning and has too crude functionality that cannot provide great UX (providing installation percentage etc.)
Change overview
Tests
Build the TV app using command:
scripts/examples/gn_build_example.sh examples/tv-app/linux out/debug/Build the TV casting app using command:
scripts/examples/gn_build_example.sh examples/tv-casting-app/linux out/debug/Start TV App
out/debug/chip-tv-appStart TV Casting App
out/debug/chip-tv-casting-appOn TV App: Uninstall the app
app uninstall 65521 32769On TV Casting App: Send casting request to the tv-app using
cast request 0On TV App: Accepted the Cast request from the tv-casting app
controller ux okOn TV casting app: Send Application Basic command
cast cluster applicationbasic read status 0 4Note that you'll see the response
Status: 4which stands forkNotInstalled---------- TBA --------
9. On TV app: Run App install command
app install 65521 32769This should update the app status to
kInstalled