[Bridge Example] Fix dangling pointer when AddDeviceEndpoint failed #33956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
tehampson
approved these changes
Jun 17, 2024
|
PR #33956: Size comparison from 8ba371a to a439f41 Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
samadDotDev
approved these changes
Jun 17, 2024
yufengwangca
changed the title
|
PR #33956: Size comparison from 8ba371a to d8e99af Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
saurabhst
approved these changes
Jun 18, 2024
diogopintodsr
pushed a commit
to diogopintodsr/connectedhomeip
that referenced
this pull request
Jun 20, 2024
…roject-chip#33956) * Fix dandling pointer when AddDeviceEndpoint failed * Remove code never be excuted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary: Inconsistent State of mDevices Array on Error Return
Description
In the current implementation of the DeviceManager::AddDeviceEndpoint function, there is a potential issue where the mDevices array can be left in an inconsistent state when errors occur. Specifically, when the function encounters an error and returns -1, it does not reset the mDevices[index] element back to nullptr. This can lead to the array containing invalid pointers, which can cause undefined behavior in subsequent operations.
Affected Function
DeviceManager::AddDeviceEndpoint
Fixes #33946