reset StartUpCurrentLevel to ensure test repetitions #33921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33921: Size comparison from 60ae46d to 80087c4 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| @@ -230,6 +233,16 @@ tests: | |||
| type: int8u | |||
| notValue: StartUpCurrentLevelValue | |||
|
|
|||
| #This is a reset step that is needed to reset the value of the attribute to another value then the one used in 6b in order to ensure successful test repetitions. | |||
There was a problem hiding this comment.
This is not great, since it introduces a divergence from the test plan in this certification test.
I know we have a step like that below already, but can we either get the test plan fixed to match the test or fix the way we run this test to match the test plan?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TC-LVL-2.2] The added test step resets the StartUpCurrentLevel to another value then the one used in 6b.
Test step 6c checks if writing to the attribute StartUpCurrentLevel was successful by comparing its initial value with the value (5) written in step 6b. If the initial value and the value written in step 6b differ, the step is considered successful. However, if the test case is executed back-to-back, StartUpCurrentLevel remains unchanged between test runs, causing test step 6c to fail.