Add new AddStatus overloads using ClusterStatusCode #33904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CommandHandler and WriteHandler did not have a way to cleanly just `AddStatus` with a cluster-specific status code (to eventually harmonize handling methods to always return just a ClusterStatusCode). This PR: - Introduces an `AddStatus` overload for `ClusterStatusCode` to CommandHandler and WriteHandler. - Removes the unimplemented `WriteClient::Shutdown` method. - Adds notes to the `AddClusterSpecificSuccess` and `AddClusterSpecificFailure`. - Removes implicit conversion from `ClusterStatusCode` to `Status` - Was never used and was error-prone/lossy Fixes project-chip#31120 Testing done: - Updated necessary unit tests. - Added unit tests for cluster specific statuses on writes. - Integration tests still pass.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33904: Size comparison from 645d3a7 to 9f1e0ee Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33904: Size comparison from 645d3a7 to 102c949 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 13, 2024
andy31415
reviewed
Jun 13, 2024
andy31415
reviewed
Jun 13, 2024
andy31415
reviewed
Jun 13, 2024
andy31415
reviewed
Jun 13, 2024
andy31415
reviewed
Jun 13, 2024
andy31415
approved these changes
Jun 13, 2024
bzbarsky-apple
approved these changes
Jun 13, 2024
- Make StatusIB initializable from ClusterStatusCode - Clean-ups requested - CommandResponseHelper loses the error-prone cluster-specific-code on success (can be added back if ever needed).
|
PR #33904: Size comparison from 645d3a7 to db2e60b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddStatuswith a cluster-specific status code (to eventually harmonize handling methods to always return just a ClusterStatusCode).This PR:
AddStatusoverload forClusterStatusCodeto CommandHandler and WriteHandler.WriteClient::Shutdownmethod.AddClusterSpecificSuccessandAddClusterSpecificFailure.ClusterStatusCodetoStatusFixes #31120
Testing done: