[Darwin] MTRDeviceController getSessionForNode: to use subscription pool as needed #33856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33856: Size comparison from bfa3e6f to e479b8b Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…BaseDevice testing
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #33856: Size comparison from bfa3e6f to 08bb265 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Jun 13, 2024
woody-apple
reviewed
Jun 13, 2024
Co-authored-by: Justin Wood <[email protected]>
|
PR #33856: Size comparison from bfa3e6f to 643ffcb Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Jun 13, 2024
| @@ -2055,194 +2061,195 @@ - (void)_setupSubscriptionWithReason:(NSString *)reason | |||
| }); | |||
| } | |||
|
|
|||
| // Call directlyGetSessionForNode because the subscription setup already goes through the subscription pool queue | |||
There was a problem hiding this comment.
So I was figuring we would stop putting the subscription setup in there and just call getSessionForNode and have that get queued.... why are we not doing that?
There was a problem hiding this comment.
Subscriptions on controller startup can cause a thundering herd issue with many Thread devices. If we only use the N-pool for getSessionForNode, then as soon as session is established, another device subscription can move forward, and we can get into a situation where many subscriptions and their priming reports are in the air at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes MTRDeviceController's
-getSessionForNode:completion:also participate in the subscription pool when there is an MTRDevice associated with the nodeID, and is also known to use Thread.With this change, MTRBaseDevice and MTRBaseClusters reads/subscriptions for devices using Thread would also get the CASE session establishment gated by the subscription pool, and help avoid congesting the Thread network when a controller starts and tries to get status for all its Thread devices.