Fix OperationalSessionSetup notifying success with inactive sessions #33822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #33822: Size comparison from d4d9a99 to f7e7b39 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple and
kkasperczyk-no
pullapprove
bot
requested review from
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33822: Size comparison from d4d9a99 to e2736de Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 10, 2024
|
PR #33822: Size comparison from d4d9a99 to 0bcbd58 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 11, 2024
andy31415
reviewed
Jun 11, 2024
andy31415
reviewed
Jun 12, 2024
When a success callback marks the session defunct for some reason, other succcess callbacks should not be called. Implement a GroupedCallbackList to make this logic possible. This specific solution is based on the assumption that we don't want to change the OperationalSessionSetup API which takes success and two variants of failure callbacks as separate, client-provided Callback objects, with all callbacks being optional to provide. We also don't want to introduce additional dynamic allocation within OperationalSessionSetup e.g. to allocate a struct holding the related callbacks. The GroupedCallbackList class makes use of the existing prev/next pointers within the client-allocated Callback objects to capture the grouping relationship between them. Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
approved these changes
Jun 12, 2024
ksperling-apple
force-pushed
the
fix-session-setup-crash
branch
from
9a671e4 to
972e22e
Compare
|
PR #33822: Size comparison from 1a8c6d2 to 972e22e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a success callback marks the session defunct for some reason, other succcess callbacks should not be called. Implement a GroupedCallbackList to make this logic possible.
This specific solution is based on the assumption that we don't want to change the
OperationalSessionSetupAPI which takes success and two variants of failure callbacks as separate, client-providedCallbackobjects, with all callbacks being optional to provide. We also don't want to introduce additional dynamic allocation withinOperationalSessionSetupe.g. to allocate a struct holding the related callbacks.The GroupedCallbackList class makes use of the existing prev/next pointers within the client-allocated
Callbackobjects to capture the grouping relationship between them.