Enable ReadHandler to support large payloads #33814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pidarped
changed the title
pidarped
force-pushed
the
LargeReadRequests
branch
from
9e4dac0 to
dc7de5f
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
pullapprove
bot
requested review from
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #33814: Size comparison from 5ee4ef6 to dc7de5f Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 10, 2024
andy31415
reviewed
Jun 10, 2024
andy31415
reviewed
Jun 10, 2024
andy31415
reviewed
Jun 10, 2024
pidarped
force-pushed
the
LargeReadRequests
branch
from
dc7de5f to
bcc7517
Compare
|
PR #33814: Size comparison from bd0422b to bcc7517 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
When sending reports, if the session established with the peer supports large payloads, the ReadHandler will allocate a large buffer to, potentially, fit more attribute and event data.
pidarped
force-pushed
the
LargeReadRequests
branch
from
bcc7517 to
5f31784
Compare
|
PR #33814: Size comparison from 3058c4b to 5f31784 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33814: Size comparison from 3058c4b to 190916f Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
pidarped
force-pushed
the
LargeReadRequests
branch
from
190916f to
b0f4ca0
Compare
|
PR #33814: Size comparison from bfa3e6f to b0f4ca0 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 12, 2024
andy31415
reviewed
Jun 12, 2024
andy31415
approved these changes
Jun 12, 2024
Co-authored-by: Andrei Litvin <[email protected]>
|
PR #33814: Size comparison from bfa3e6f to 821b65f Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending reports, if the session established with the peer supports large payloads, the ReadHandler would allocate a large buffer to, potentially, fit more cluster data.