Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-commissioner: support secondary network interface commissioning #33801

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Auto-commissioner: support secondary network interface commissioning #33801

merged 4 commits into from
Jun 27, 2024

Conversation

DejinChen
Copy link
Contributor

@DejinChen DejinChen commented Jun 7, 2024 •
edited
Loading

Ref to SEPC PR Clarify Commissioner behavior to support multiple networks, added supports for secondary network interface commissioning.

Change overview

  • CHIP-TOOL pairing command: pairing ble-wifi-thread.
  • AutoCommissioner and CHIPDeviceController: If primary network (on endpoint 0) failed, disable it (by writing InterfaceEnabled attribute, require related PRs) and try to connect secondary network.

Related PRs

Test

  • Tested CHIP-TOOL pairing ble-wifi-thread command on ESP32-C6, which both Wi-Fi driver and Thread driver are enabled.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

PR #33801: Size comparison from 4239c88 to 7608074

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4239c88 7608074 change % change
bl602 lighting-app bl602 FLASH 1268040 1268040 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282318 1282318 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307254 1307254 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088680 1089010 330 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099374 1099704 330 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178504 1178834 330 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872112 872112 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123798 1123798 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075566 1075896 330 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086828 1087158 330 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797948 798228 280 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813552 813832 280 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802852 803140 288 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755620 755908 288 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741260 741540 280 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605022 605022 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650490 650490 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661589 661885 296 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681441 681737 296 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681441 681737 296 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638377 638665 288 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603661 603965 304 0.1
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623305 623593 288 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623305 623593 288 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619277 619573 296 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639001 639289 288 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639001 639289 288 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587813 588101 288 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607657 607953 296 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607657 607953 296 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 888216 888568 352 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701328 701328 0 0.0
RAM 242724 242724 0 0.0
window-app BRD4187C FLASH 968492 968772 280 0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466358 1466656 298 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535559 1535771 212 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532688 2532688 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568606 5568606 0 0.0
RAM 482216 482216 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052456 5052456 0 0.0
RAM 236792 236792 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4478200 4478200 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11519399 11529783 10384 0.1
RAM 521762 522234 472 0.1
chip-tool-ipv6only arm64 unknown 17384 17424 40 0.2
FLASH 10667812 10676764 8952 0.1
RAM 569744 570208 464 0.1
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11289479 11298951 9472 0.1
RAM 515330 515394 64 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347784 4347784 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366434 5366434 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4543096 4543096 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177976 4177976 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4302360 4302360 0 0.0
RAM 197712 197712 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2800317 2800317 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4150404 4150404 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5588856 5594984 6128 0.1
RAM 344872 344872 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9568214 9568214 0 0.0
RAM 340288 340288 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497548 1497548 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873664 874016 352 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949208 949208 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822188 822540 352 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575652 575884 232 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590912 591152 240 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609624 609992 368 0.1
RAM 69596 69596 0 0.0
k32w1+release FLASH 673992 674352 360 0.1
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610364 1610364 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534572 1534572 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460860 1460860 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650848 272 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610276 610580 304 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472036 472324 288 0.1
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625046 625310 264 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600864 600864 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770184 770458 274 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668176 668450 274 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626798 627062 264 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713688 713962 274 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558740 558740 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793506 793780 274 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 659986 660260 274 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 687174 687448 274 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 608998 609272 274 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599346 599620 274 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633192 633456 264 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642846 643120 274 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618248 618522 274 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464864 464864 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1556 1556 0 0.0
FLASH 1613936 1613936 0 0.0
RAM 45452 45452 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15639098 15663002 23904 0.2
RAM 6828408 6840844 12436 0.2

@DejinChen DejinChen force-pushed the auto-commissioner/secondary_network_inetface_commissioning branch from 7608074 to 908f57b Compare June 7, 2024 10:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

PR #33801: Size comparison from 4239c88 to 908f57b

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4239c88 908f57b change % change
bl602 lighting-app bl602 FLASH 1268040 1268040 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282318 1282318 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307254 1307254 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088680 1089010 330 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099374 1099704 330 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178504 1178834 330 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872112 872112 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123798 1123798 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075566 1075896 330 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086828 1087158 330 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797948 798228 280 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813552 813832 280 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802852 803140 288 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755620 755908 288 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741260 741540 280 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605022 605022 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650490 650490 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661589 661885 296 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681441 681737 296 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681441 681737 296 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638377 638665 288 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603661 603965 304 0.1
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623305 623593 288 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623305 623593 288 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619277 619573 296 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639001 639289 288 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639001 639289 288 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587813 588101 288 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607657 607953 296 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607657 607953 296 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 888216 888568 352 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701328 701328 0 0.0
RAM 242724 242724 0 0.0
window-app BRD4187C FLASH 968492 968772 280 0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466358 1466656 298 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535559 1535771 212 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532688 2532688 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568606 5568606 0 0.0
RAM 482216 482216 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052456 5052456 0 0.0
RAM 236792 236792 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4478200 4478200 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11519399 11529783 10384 0.1
RAM 521762 522234 472 0.1
chip-tool-ipv6only arm64 unknown 17384 17424 40 0.2
FLASH 10667812 10676764 8952 0.1
RAM 569744 570208 464 0.1
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11289479 11298951 9472 0.1
RAM 515330 515394 64 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347784 4347784 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366434 5366434 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4543096 4543096 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177976 4177976 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4302360 4302360 0 0.0
RAM 197712 197712 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2800317 2800317 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4150404 4150404 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5588856 5594984 6128 0.1
RAM 344872 344872 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9568214 9568214 0 0.0
RAM 340288 340288 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497548 1497548 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873664 874016 352 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 949208 949208 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 822188 822540 352 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575652 575884 232 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590912 591152 240 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609624 609992 368 0.1
RAM 69596 69596 0 0.0
k32w1+release FLASH 673992 674352 360 0.1
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610364 1610364 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534572 1534572 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460860 1460860 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462844 1462844 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650576 650848 272 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610276 610580 304 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472036 472324 288 0.1
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625046 625310 264 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600864 600864 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770184 770458 274 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668176 668450 274 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626798 627062 264 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713688 713962 274 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 558740 558740 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793506 793780 274 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 659986 660260 274 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 687174 687448 274 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 608998 609272 274 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599346 599620 274 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633192 633456 264 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642846 643120 274 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618248 618522 274 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464864 464864 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1556 1556 0 0.0
FLASH 1613936 1613936 0 0.0
RAM 45452 45452 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15639098 15663002 23904 0.2
RAM 6828408 6840844 12436 0.2

bzbarsky-apple
bzbarsky-apple requested changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested largely for the non-cancelable write bits; the other issues need fixing too, but that one is critical.

examples/chip-tool/commands/pairing/Commands.h Outdated Show resolved Hide resolved
src/controller/AutoCommissioner.cpp Outdated Show resolved Hide resolved
src/controller/AutoCommissioner.cpp Show resolved Hide resolved
src/controller/AutoCommissioner.cpp Outdated Show resolved Hide resolved
src/controller/AutoCommissioner.h Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CHIPDeviceController.cpp Outdated Show resolved Hide resolved
src/controller/CommissioningDelegate.cpp Outdated Show resolved Hide resolved
src/controller/CommissioningDelegate.cpp Outdated Show resolved Hide resolved
src/platform/ESP32/NetworkCommissioningDriver.cpp Outdated Show resolved Hide resolved
@DejinChen DejinChen force-pushed the auto-commissioner/secondary_network_inetface_commissioning branch from 2591e37 to 236743e Compare June 12, 2024 05:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

PR #33801: Size comparison from 23ec1b0 to 236743e

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 23ec1b0 236743e change % change
bl602 lighting-app bl602 FLASH 1268298 1268298 0 0.0
RAM 95424 95424 0 0.0
bl602+mfd FLASH 1282576 1282576 0 0.0
RAM 95576 95576 0 0.0
bl602+rpc FLASH 1307256 1307256 0 0.0
RAM 103856 103856 0 0.0
bl702 lighting-app bl702 FLASH 1088938 1088938 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099888 1099888 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1179018 1179018 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872114 872114 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1124146 1124146 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1076080 1076080 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1087342 1087342 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797596 797596 0 0.0
RAM 103184 103184 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813392 813392 0 0.0
RAM 113664 113664 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802756 802756 0 0.0
RAM 107784 107784 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755244 755244 0 0.0
RAM 101884 101884 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 740900 740900 0 0.0
RAM 102132 102132 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604846 604846 0 0.0
RAM 204608 204608 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650634 650634 0 0.0
RAM 204868 204868 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661253 661253 0 0.0
RAM 74608 74608 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681105 681105 0 0.0
RAM 77240 77240 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638033 638033 0 0.0
RAM 69676 69676 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603429 603429 0 0.0
RAM 70312 70312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623073 623073 0 0.0
RAM 72864 72864 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619221 619221 0 0.0
RAM 73328 73328 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638945 638945 0 0.0
RAM 75880 75880 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638945 638945 0 0.0
RAM 75880 75880 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587469 587469 0 0.0
RAM 67296 67296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607313 607313 0 0.0
RAM 69928 69928 0 0.0
efr32 lighting-app BRD4187C FLASH 887832 887832 0 0.0
RAM 183520 183520 0 0.0
lock-app BRD4338a FLASH 701672 701664 -8 -0.0
RAM 242804 242804 0 0.0
window-app BRD4187C FLASH 968748 968740 -8 -0.0
RAM 167952 167952 0 0.0
esp32 all-clusters-app c3devkit DRAM 88420 88420 0 0.0
FLASH 1466214 1466214 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114892 114892 0 0.0
FLASH 1535431 1535431 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2532288 2532288 0 0.0
RAM 129104 129104 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5568878 5568878 0 0.0
RAM 483096 483096 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5052664 5052664 0 0.0
RAM 236888 236888 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4477800 4477800 0 0.0
RAM 216816 216816 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11511095 11521543 10448 0.1
RAM 535234 535706 472 0.1
chip-tool-ipv6only arm64 unknown 19792 19832 40 0.2
FLASH 10649364 10658332 8968 0.1
RAM 583232 583696 464 0.1
fabric-admin debug unknown 5600 5600 0 0.0
FLASH 11281239 11290775 9536 0.1
RAM 528818 528882 64 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4347384 4347384 0 0.0
RAM 208864 208864 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5366034 5366034 0 0.0
RAM 225424 225424 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4543304 4543304 0 0.0
RAM 204240 204240 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4177560 4177560 0 0.0
RAM 193200 193200 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4302024 4302024 0 0.0
RAM 197840 197840 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2799997 2799997 0 0.0
RAM 154424 154424 0 0.0
thermostat-no-ble arm64 unknown 9160 9160 0 0.0
FLASH 4149636 4149636 0 0.0
RAM 234616 234616 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5587000 5593144 6144 0.1
RAM 345672 345672 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9559318 9559318 0 0.0
RAM 352864 352864 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497748 1497748 0 0.0
RAM 226168 226168 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 873828 873828 0 0.0
RAM 139225 139225 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948512 948512 0 0.0
RAM 137653 137653 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821804 821804 0 0.0
RAM 138123 138123 0 0.0
nxp contact k32w0+release FLASH 575220 575220 0 0.0
RAM 70120 70120 0 0.0
k32w1+release FLASH 590464 590464 0 0.0
RAM 74152 74152 0 0.0
light k32w0+release FLASH 609216 609216 0 0.0
RAM 69596 69596 0 0.0
k32w1+release FLASH 673648 673648 0 0.0
RAM 82904 82904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1610156 1610156 0 0.0
RAM 207228 207228 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1534356 1534356 0 0.0
RAM 204132 204132 0 0.0
light cy8ckit_062s2_43012 FLASH 1460652 1460652 0 0.0
RAM 197412 197412 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462948 1462948 0 0.0
RAM 224476 224476 0 0.0
qpg lighting-app qpg6105+debug FLASH 650216 650216 0 0.0
RAM 104652 104652 0 0.0
lock-app qpg6105+debug FLASH 610196 610196 0 0.0
RAM 99328 99328 0 0.0
stm32 light STM32WB5MM-DK FLASH 472124 472124 0 0.0
RAM 141748 141748 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 625098 625098 0 0.0
RAM 49952 49952 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 600692 600692 0 0.0
RAM 130384 130384 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 770308 770308 0 0.0
RAM 110148 110148 0 0.0
bridge-app tlsr9258a FLASH 668228 668228 0 0.0
RAM 94768 94768 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626850 626850 0 0.0
RAM 49996 49996 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 712688 712688 0 0.0
RAM 76588 76588 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 557830 557830 0 0.0
RAM 126640 126640 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 792896 792896 0 0.0
RAM 99996 99996 0 0.0
lock-app-dfu tlsr9528a FLASH 660154 660154 0 0.0
RAM 69276 69276 0 0.0
ota-requestor-app tlsr9258a FLASH 686564 686564 0 0.0
RAM 94492 94492 0 0.0
pump-app tlsr9518adk80d FLASH 609050 609050 0 0.0
RAM 56376 56376 0 0.0
pump-controller-app tlsr9518adk80d FLASH 599398 599398 0 0.0
RAM 56176 56176 0 0.0
shell tlsr9518adk80d FLASH 462618 462618 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633244 633244 0 0.0
RAM 51624 51624 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642236 642236 0 0.0
RAM 59812 59812 0 0.0
thermostat tlsr9518adk80d FLASH 618300 618300 0 0.0
RAM 56500 56500 0 0.0
window-covering tlsr9118bdk40d FLASH 464616 464616 0 0.0
RAM 82272 82272 0 0.0
tizen all-clusters-app arm unknown 1552 1552 0 0.0
FLASH 1613156 1613156 0 0.0
RAM 45460 45460 0 0.0
chip-tool-ubsan arm unknown 2360 2360 0 0.0
FLASH 15734418 15758602 24184 0.2
RAM 6901824 6914352 12528 0.2

This was referenced Jun 12, 2024
Closed
Merged
bzbarsky-apple
bzbarsky-apple approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pullapprove pullapprove bot requested a review from ReneJosefsen June 26, 2024 19:48
@mergify mergify bot merged commit d71a363 into project-chip:master Jun 27, 2024
68 checks passed
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
@DejinChen @austina-csa
Auto-commissioner: support secondary network interface commissioning (p…
130ffc6 
…roject-chip#33801)

* Auto-commissioner: support secondary network interface commissioning

* Fix code-wifi-thread command and reset trying secondary network flag

* Revert server-side changes

* Added write request cancel function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

Assignees
No one assigned
Labels
controller esp32 examples platform review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DejinChen @bzbarsky-apple @jmartinez-silabs