-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Add TriggerResubscribeIfScheduled to SubscriptionTransaction #33774
Merged
mergify
merged 1 commit into
project-chip:master
from
agners:add-trigger-resubscribe-if-scheduled
Jun 7, 2024
Merged
[Python] Add TriggerResubscribeIfScheduled to SubscriptionTransaction #33774
mergify
merged 1 commit into
project-chip:master
from
agners:add-trigger-resubscribe-if-scheduled
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TriggerResubscribeIfScheduled to SubscriptionTransaction. If the ReadClient currently has a resubscription attempt scheduled, This function allows to trigger that attempt immediately. This is useful when the server side is up and communicating, and it's a good time to try to resubscribe.
agners
force-pushed
the
add-trigger-resubscribe-if-scheduled
branch
2 times, most recently
from
June 6, 2024 12:21
f945ba2
to
e076554
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
June 6, 2024 12:21
pullapprove
bot
requested review from
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
June 6, 2024 12:22
PR #33774: Size comparison from d15f6c1 to e076554 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
agners
force-pushed
the
add-trigger-resubscribe-if-scheduled
branch
from
June 6, 2024 12:43
e076554
to
f945ba2
Compare
PR #33774: Size comparison from d15f6c1 to f945ba2 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 6, 2024
arkq
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TriggerResubscribeIfScheduled to SubscriptionTransaction. If the ReadClient currently has a resubscription attempt scheduled, This function allows to trigger that attempt immediately. This is useful when the server side is up and communicating, and it's a good time to try to resubscribe.