-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pw_unit_test migration: apps final batch #33772
Conversation
PR #33772: Size comparison from d15f6c1 to 52ab66a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33772: Size comparison from 17cda5a to 37122f9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33772: Size comparison from 17cda5a to ac12ff3 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33772: Size comparison from 17cda5a to 2181cb0 Increases above 0.2%:
Full report (6 builds for cc32xx, mbed, stm32, tizen)
|
PR #33772: Size comparison from 17cda5a to 39dc47e Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My focus was more on TestCommandInteraction, with a quick glance at other tests
This PR is the same as pw_unit_test migration: apps-2 #33734, but without the
*TestAccess.h
classes and instead, private tested-class members were accessed using the MacroTEST_F_FROM_FIXTURE
from ExtraPwTestMacros.hfinal batch of src/app tests (related to Interaction Model) first started in pw_unit_test migration: apps-1 and stub-refactoring #33638
pw_unit conversion was first discussed in: Testing using pw_unit_test #29342
In the PR
TestCommissioningWindowManager
was renamed and the sleep timeouts were replaced byRunEventLoop
and a call to StopEventLoop for each taskNOTE:
NL_TEST_ASSERT
API behavior is closest toEXPECT
than toASSERT
which is whyEXPECT
has been used more widelyFollow-up: remove other NL_TEST dependencies.