-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update device-energy-management-cluster.xml based on latest cluster spec #33771
Merged
mergify
merged 7 commits into
project-chip:master
from
PeterC1965:add-dem-xml-updates-for-1-4
Jun 13, 2024
Merged
Update device-energy-management-cluster.xml based on latest cluster spec #33771
mergify
merged 7 commits into
project-chip:master
from
PeterC1965:add-dem-xml-updates-for-1-4
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pec and regenerate zap files
PR #33771: Size comparison from be94090 to 9d4d762 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #33771: Size comparison from be94090 to 9931b0a Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jamesharrow
reviewed
Jun 6, 2024
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
requested changes
Jun 6, 2024
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Show resolved
Hide resolved
PR #33771: Size comparison from be94090 to 956c311 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 8, 2024
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/device-energy-management-server/device-energy-management-server.cpp
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jun 10, 2024
examples/energy-management-app/energy-management-common/energy-management-app.matter
Show resolved
Hide resolved
jamesharrow
approved these changes
Jun 12, 2024
pullapprove
bot
requested review from
arkq,
bauerschwan,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve and
harimau-qirex
June 13, 2024 05:34
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
mspang,
p0fi,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang and
yunhanw-google
June 13, 2024 05:34
PR #33771: Size comparison from bbd3419 to 725df5f Increases above 0.2%:
Full report (49 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
PR #33771: Size comparison from bbd3419 to 0f6d3ff Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update device-energy-management-cluster.xml based on latest cluster spec. This is the first of several pull-requests that implement the DEM cluster in Matter 1.4.
Note DEM did not make Matter 1.3 SVE and is only provisional.
The spec can be found at: https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/DeviceEnergyManagement.adoc
Follow-up PRs will include adding: