Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Allow to pass CHIP error to device event #33744

Merged
merged 6 commits into from
Jun 5, 2024
Merged

[Tizen] Allow to pass CHIP error to device event #33744

merged 6 commits into from
Jun 5, 2024

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Jun 5, 2024

Problem

When reporting error from async operation it's not possible to pass error value.

Changes

  • store CHIP_ERROR instead of "bool isSuccess" in the event
  • do not initialize characteristics with dummy values
  • do not keep non-Matter UUIDs in BleUUID.h (Client Characteristic Configuration)
  • create GATT service with short Bluetooth SIG UUID

Testing

CI will verify potential build brakes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

PR #33744: Size comparison from 0050994 to e487cec

Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 0050994 e487cec change % change
bl602 lighting-app bl602 FLASH 1267960 1267960 0 0.0
RAM 95408 95408 0 0.0
bl602+mfd FLASH 1282238 1282238 0 0.0
RAM 95560 95560 0 0.0
bl602+rpc FLASH 1307174 1307174 0 0.0
RAM 103840 103840 0 0.0
bl702 lighting-app bl702 FLASH 1088666 1088666 0 0.0
RAM 14897 14897 0 0.0
bl702+mfd FLASH 1099360 1099360 0 0.0
RAM 15049 15049 0 0.0
bl702+rpc FLASH 1178490 1178490 0 0.0
RAM 23925 23925 0 0.0
bl706-eth FLASH 872000 872000 0 0.0
RAM 27016 27016 0 0.0
bl706-wifi FLASH 1123626 1123626 0 0.0
RAM 14349 14349 0 0.0
bl702l lighting-app bl702l FLASH 1075552 1075552 0 0.0
RAM 21468 21468 0 0.0
bl702l+mfd FLASH 1086814 1086814 0 0.0
RAM 21628 21628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797492 797492 0 0.0
RAM 103216 103216 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 813184 813184 0 0.0
RAM 113696 113696 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 802564 802564 0 0.0
RAM 107816 107816 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 755476 755476 0 0.0
RAM 101924 101924 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 741132 741132 0 0.0
RAM 102164 102164 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 604350 604350 0 0.0
RAM 204592 204592 0 0.0
lock CC3235SF_LAUNCHXL FLASH 649626 649626 0 0.0
RAM 204852 204852 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661053 661053 0 0.0
RAM 74592 74592 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680897 680897 0 0.0
RAM 77224 77224 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680897 680897 0 0.0
RAM 77224 77224 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637841 637841 0 0.0
RAM 69660 69660 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 603533 603533 0 0.0
RAM 70296 70296 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 623177 623177 0 0.0
RAM 72848 72848 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 623177 623177 0 0.0
RAM 72848 72848 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618885 618885 0 0.0
RAM 73312 73312 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638601 638601 0 0.0
RAM 75864 75864 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638601 638601 0 0.0
RAM 75864 75864 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 587653 587653 0 0.0
RAM 67280 67280 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 607505 607505 0 0.0
RAM 69912 69912 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 607505 607505 0 0.0
RAM 69912 69912 0 0.0
efr32 lighting-app BRD4187C FLASH 887672 887672 0 0.0
RAM 183504 183504 0 0.0
lock-app BRD4338a FLASH 700520 700512 -8 -0.0
RAM 242708 242708 0 0.0
window-app BRD4187C FLASH 967876 967876 0 0.0
RAM 167936 167936 0 0.0
esp32 all-clusters-app c3devkit DRAM 88404 88404 0 0.0
FLASH 1465246 1465246 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 114876 114876 0 0.0
FLASH 1533955 1533955 0 0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4576 4576 0 0.0
FLASH 2529872 2529872 0 0.0
RAM 128832 128832 0 0.0
all-clusters-app debug unknown 5344 5344 0 0.0
FLASH 5561342 5561342 0 0.0
RAM 481944 481944 0 0.0
all-clusters-minimal-app debug unknown 5264 5264 0 0.0
FLASH 5047448 5047448 0 0.0
RAM 236520 236520 0 0.0
bridge-app debug unknown 5232 5232 0 0.0
FLASH 4475576 4475576 0 0.0
RAM 216544 216544 0 0.0
chip-tool debug unknown 5744 5744 0 0.0
FLASH 11514295 11514295 0 0.0
RAM 521474 521474 0 0.0
chip-tool-ipv6only arm64 unknown 17368 17368 0 0.0
FLASH 10663460 10663460 0 0.0
RAM 569472 569472 0 0.0
fabric-admin debug unknown 5592 5592 0 0.0
FLASH 11276887 11276887 0 0.0
RAM 514786 514786 0 0.0
fabric-bridge-app debug unknown 5240 5240 0 0.0
FLASH 4345384 4345384 0 0.0
RAM 208592 208592 0 0.0
lighting-app debug+rpc+ui unknown 5864 5864 0 0.0
FLASH 5361826 5361826 0 0.0
RAM 225136 225136 0 0.0
lock-app debug unknown 5184 5184 0 0.0
FLASH 4539512 4539512 0 0.0
RAM 203968 203968 0 0.0
ota-provider-app debug unknown 4552 4552 0 0.0
FLASH 4175544 4175544 0 0.0
RAM 192928 192928 0 0.0
ota-requestor-app debug unknown 4488 4488 0 0.0
FLASH 4299640 4299640 0 0.0
RAM 197440 197440 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2794637 2794637 0 0.0
RAM 154168 154168 0 0.0
thermostat-no-ble arm64 unknown 9144 9144 0 0.0
FLASH 4148500 4148500 0 0.0
RAM 234344 234344 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5585240 5585240 0 0.0
RAM 344600 344600 0 0.0
tv-casting-app debug unknown 5104 5104 0 0.0
FLASH 9565254 9565254 0 0.0
RAM 340016 340016 0 0.0
mbed lock-app-release cy8cproto_062_4343w FLASH 1497156 1497156 0 0.0
RAM 226152 226152 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 872776 872776 0 0.0
RAM 139209 139209 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 948124 948124 0 0.0
RAM 137637 137637 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 821680 821680 0 0.0
RAM 138107 138107 0 0.0
nxp contact k32w0+release FLASH 575492 575492 0 0.0
RAM 70112 70112 0 0.0
k32w1+release FLASH 590888 590888 0 0.0
RAM 74144 74144 0 0.0
light k32w0+release FLASH 609408 609408 0 0.0
RAM 69588 69588 0 0.0
k32w1+release FLASH 673728 673728 0 0.0
RAM 82896 82896 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1608916 1608916 0 0.0
RAM 207212 207212 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1533492 1533492 0 0.0
RAM 204116 204116 0 0.0
light cy8ckit_062s2_43012 FLASH 1459868 1459868 0 0.0
RAM 197396 197396 0 0.0
lock cy8ckit_062s2_43012 FLASH 1461996 1461996 0 0.0
RAM 224460 224460 0 0.0
qpg lighting-app qpg6105+debug FLASH 650176 650176 0 0.0
RAM 104644 104644 0 0.0
lock-app qpg6105+debug FLASH 610020 610020 0 0.0
RAM 99320 99320 0 0.0
stm32 light STM32WB5MM-DK FLASH 471484 471484 0 0.0
RAM 141732 141732 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 624960 624960 0 0.0
RAM 49944 49944 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 596982 596982 0 0.0
RAM 125184 125184 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 769686 769686 0 0.0
RAM 110132 110132 0 0.0
bridge-app tlsr9518adk80d FLASH 656458 656458 0 0.0
RAM 92888 92888 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 626766 626766 0 0.0
RAM 49988 49988 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 713698 713698 0 0.0
RAM 76580 76580 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 555272 555272 0 0.0
RAM 121432 121432 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 793042 793042 0 0.0
RAM 99980 99980 0 0.0
lock-app-dfu tlsr9528a FLASH 659810 659810 0 0.0
RAM 69268 69268 0 0.0
ota-requestor-app tlsr9518adk80d FLASH 675340 675340 0 0.0
RAM 92620 92620 0 0.0
pump-app tlsr9258a FLASH 621398 621398 0 0.0
RAM 58232 58232 0 0.0
pump-controller-app tlsr9118bdk40d FLASH 450174 450174 0 0.0
RAM 76672 76672 0 0.0
shell tlsr9518adk80d FLASH 462642 462642 0 0.0
RAM 71852 71852 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 633166 633166 0 0.0
RAM 51616 51616 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 642876 642876 0 0.0
RAM 59804 59804 0 0.0
thermostat tlsr9518adk80d FLASH 618224 618224 0 0.0
RAM 56492 56492 0 0.0
window-covering tlsr9258a FLASH 623168 623168 0 0.0
RAM 58448 58448 0 0.0
tizen all-clusters-app arm unknown 1556 1556 0 0.0
FLASH 1609836 1609892 56 0.0
RAM 45460 45460 0 0.0
chip-tool-ubsan arm unknown 2364 2364 0 0.0
FLASH 15626350 15626510 160 0.0
RAM 6822000 6822092 92 0.0

@mergify mergify bot merged commit e445e8a into project-chip:master Jun 5, 2024
68 checks passed
@arkq arkq deleted the tizen-ble-fixes branch June 5, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
ble fast track linux platform review - pending tizen For Tizen platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkq @andy31415 @restyled-commits