-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added endpoint id for Thread network commissioning instance #33685
Merged
mergify
merged 1 commit into
project-chip:master
from
DejinChen:thread_network_endpoint_id
Jun 8, 2024
Merged
Added endpoint id for Thread network commissioning instance #33685
mergify
merged 1 commit into
project-chip:master
from
DejinChen:thread_network_endpoint_id
Jun 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 31, 2024 06:50
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
May 31, 2024 06:50
PR #33685: Size comparison from b3fc1d0 to 3c29376 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
requested changes
Jun 1, 2024
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
Outdated
Show resolved
Hide resolved
DejinChen
force-pushed
the
thread_network_endpoint_id
branch
from
June 3, 2024 07:03
3c29376
to
973531b
Compare
PR #33685: Size comparison from 294dc18 to 973531b Decreases (3 builds for efr32)
Full report (73 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bauerschwan
approved these changes
Jun 3, 2024
DejinChen
force-pushed
the
thread_network_endpoint_id
branch
from
June 4, 2024 08:47
973531b
to
ca1a2f7
Compare
PR #33685: Size comparison from 923854b to ca1a2f7 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
chshu
reviewed
Jun 5, 2024
chshu
approved these changes
Jun 6, 2024
DejinChen
force-pushed
the
thread_network_endpoint_id
branch
from
June 7, 2024 07:56
ca1a2f7
to
77f82e6
Compare
PR #33685: Size comparison from 4239c88 to 77f82e6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the generic thread network commissioning instance can only be added at endpoint 0. To support multiple network interfaces, a configurable endpoint ID is necessary.