-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDeviceConnectivityMonitor stopMonitoring crash fix #33666
Merged
woody-apple
merged 2 commits into
project-chip:master
from
jtung-apple:jtung/darwin-connectivity-monitor-stopmonitoring-fix
May 30, 2024
Merged
[Darwin] MTRDeviceConnectivityMonitor stopMonitoring crash fix #33666
woody-apple
merged 2 commits into
project-chip:master
from
jtung-apple:jtung/darwin-connectivity-monitor-stopmonitoring-fix
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kiel-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 29, 2024 17:28
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 29, 2024 17:28
PR #33666: Size comparison from 20b1457 to 2a42270 Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
kiel-apple
reviewed
May 29, 2024
kiel-apple
approved these changes
May 29, 2024
kiel-apple
reviewed
May 29, 2024
bzbarsky-apple
approved these changes
May 29, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33666: Size comparison from 20b1457 to e4ee7ee Full report (77 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Fast-tracking platform-specific fix with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in a shutdown / cleanup scenario where MTRDevice goes away and calls
stopMonitoring
when the shared resolver connection/queue have already cleaned up.Also added some logging for when resubscription happens in the MTRDevice layer.