-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue related to teardown of some App Tests #33654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33654: Size comparison from 8c8889b to f7a5195 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, stm32, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 29, 2024 13:25
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 29, 2024 13:25
@lpbeliveau-silabs, can you give your thought on this? I have seen your comment in |
bzbarsky-apple
approved these changes
May 29, 2024
andy31415
approved these changes
May 29, 2024
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33654: Size comparison from 896f802 to 1189988 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @bzbarsky-apple in #33638 (comment)
Context
TestAclAttribute.cpp
andTestReportScheduler.cpp
are triggering failures in (some) tests that follow them when being run on Nordic CI (on the Zephyr Native POSIX target, which compiles all unit tests into a single binary).TestReportScheduler.cpp
is not being run for Nordic, andTestAclAttribute.cpp
is being configured to run last, right after all the tests that it triggers failures.TestAclEvent
andTestReadInteraction
: it seems that the problem is related toReport Data
that comes after a Read Request --> the Callback that will callBuildAndSendSingleReportData
is not being called.DrainAndServiceIO()
right in the teardown of these Tests (TestAclAttribute.cpp
andTestReportScheduler.cpp
) --> However, I thought I might just put it in the teardown of AppTestContext incase we add more tests in the future that might trigger the same problemUPDATE: There was already an issue for this here: #27976