-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Fixing Scenes Ifdef #33641
Merged
mergify
merged 1 commit into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes-ifdef
May 29, 2024
Merged
[Scenes] Fixing Scenes Ifdef #33641
mergify
merged 1 commit into
project-chip:master
from
lpbeliveau-silabs:bugfix/scenes-ifdef
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
May 28, 2024 18:01
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
May 28, 2024 18:01
lpbeliveau-silabs
force-pushed
the
bugfix/scenes-ifdef
branch
from
May 28, 2024 18:10
df70c8e
to
9830c79
Compare
jmartinez-silabs
approved these changes
May 28, 2024
PR #33641: Size comparison from af25f56 to 9830c79 Full report (19 builds for bl602, bl702, bl702l, cc32xx, mbed, nxp, qpg)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes-ifdef
branch
from
May 28, 2024 19:07
9830c79
to
8bf8f4f
Compare
PR #33641: Size comparison from 22a9dc3 to 8bf8f4f Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/scenes-ifdef
branch
from
May 28, 2024 20:34
8bf8f4f
to
aeed365
Compare
PR #33641: Size comparison from a98dc79 to aeed365 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build apps without the scenes cluster revealed that the cluster wasn't properly ifedefed.
Since the cluster is now provisional, we need this fix to allow building the onoff, colorcontrol and level control without scenes.