Meter Identification Cluster test scripts: TC-MTRID-2.1, TC-MTRID-3.1 #33593
+312
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Maslov <[email protected]>
|
|
|
PR #33593: Size comparison from 21e239e to 3b0a991 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Signed-off-by: Dmitry Maslov <[email protected]>
|
PR #33593: Size comparison from 21e239e to ef1b001 Increases above 0.2%:
Increases (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
… PowerThresholdSourse attributes, remove obsolete attributes Signed-off-by: Dmitry Maslov <[email protected]>
|
PR #33593: Size comparison from a63cf02 to b80c741 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…butes, update numbering of attributes Signed-off-by: Dmitry Maslov <[email protected]>
Vinchouch
approved these changes
Jun 7, 2024
Vinchouch
approved these changes
Jun 7, 2024
dmitrymaslovdsr
changed the title
dmitrymaslovdsr
changed the title
|
PR #33593: Size comparison from 9d56786 to ccd5e1b Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
…test steps Signed-off-by: Dmitry Maslov <[email protected]>
|
PR #33593: Size comparison from 9d56786 to 17b4ae9 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
hasty
reviewed
Jul 24, 2024
|
PR #33593: Size comparison from c4a25e6 to 79a955b Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nxp, qpg, stm32, telink, tizen)
|
Signed-off-by: Dmitry Maslov <[email protected]>
|
PR #33593: Size comparison from 34462f1 to 17c85fa Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
Signed-off-by: Dmitry Maslov <[email protected]>
….com:dmitrymaslovdsr/connectedhomeip into metering-identification-cluster-test-scripts
dmitrymaslovdsr
changed the title
|
PR #33593: Size comparison from 1b1340f to 3cd8b57 Full report (15 builds for cc32xx, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
hasty
approved these changes
Jul 25, 2024
Signed-off-by: Dmitry Maslov <[email protected]>
Signed-off-by: Dmitry Maslov <[email protected]>
|
PR #33593: Size comparison from c91a779 to fe3bbfc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
michaelleecowan7
approved these changes
Jul 25, 2024
|
PR #33593: Size comparison from 6180583 to 98d1b8c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| # limitations under the License. | ||
|
|
||
|
|
||
| name: X.2.1. [TC-MTRID-3.1] Subscription Report Verification with DUT as Server |
There was a problem hiding this comment.
From what I can understand this is mostly a "manual" test? Would it be worth implementing it in python instead a try to automate it? I do not think we should do manual tests at this point.
There was a problem hiding this comment.
agree - manual tests are now disallowed for new features. You can have manual steps where you're asking a human to do something to the device, but not for steps where you're asking humans to verify logs or manually send commands through chip-tool
cecille
reviewed
Oct 9, 2024
| @@ -0,0 +1,72 @@ | |||
| # Copyright (c) 2021 Project CHIP Authors | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2021 Project CHIP Authors | |
| # Copyright (c) 2024 Project CHIP Authors |
| @@ -0,0 +1,832 @@ | |||
| # Copyright (c) 2021 Project CHIP Authors | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2021 Project CHIP Authors | |
| # Copyright (c) 2024 Project CHIP Authors |
| # limitations under the License. | ||
|
|
||
|
|
||
| name: X.2.1. [TC-MTRID-3.1] Subscription Report Verification with DUT as Server |
There was a problem hiding this comment.
agree - manual tests are now disallowed for new features. You can have manual steps where you're asking a human to do something to the device, but not for steps where you're asking humans to verify logs or manually send commands through chip-tool
michaelleecowan7
suggested changes
Feb 28, 2025
|
PR #33593: Size comparison from f4260df to 1dd299e Full report (3 builds for cc32xx, stm32)
|
|
@michaelleecowan7 Hey! Taking into account your comment. Looks like our cluster is read-only attributes based and can be changed by application part only on server side. We can't set string (for example) out of constraint with write request or command. I have tried to look on other already implemented clusters and open PRs and have not managed to find good example of such checks. Mostly it checks constraints based on cluster logic and always has possibility to change it via Write Request or Command. We checked it manually and looks like such cases are handled correctly, but it can't be fully automated as it required in latest recommendations to test scripts. |
|
Hello Artem,
Leo mentioned added string length defined across Matter and test to make sure enough memory available for strings in Data Model work group. Please discuss with Leo guidelines to define and test.
Thanks,
Michael
Michael Cowan
Principal System Engineer
Xylem
639 Davis Drive Morrisville NC 27560
HomeO: +1.919.469.2453 | M: +1.919.602.6629 | Lab: +1.919.317.6320
[signature_1839051095]<https://xylem.com/?utm_source=signature&utm_medium=email&utm_campaign=corporate>
Xylem.com<https://xylem.com/?utm_source=signature&utm_medium=email&utm_campaign=corporate> | Sensus.com<https://sensus.com/?utm_source=signature&utm_medium=email&utm_campaign=corporate>
LinkedIn<https://www.linkedin.com/company/sensus> | Twitter<https://twitter.com/SensusGlobal> | YouTube<https://www.youtube.com/c/SensusGlobal> | Facebook<https://www.facebook.com/SensusGlobal/> | Instagram<https://www.instagram.com/sensusglobal/> | 3D Tour<https://apps.kaonadn.net/5277329597136896/index.html>
From: Artem Burgonov ***@***.***>
Sent: Monday, March 10, 2025 5:08 PM
To: project-chip/connectedhomeip ***@***.***>
Cc: Cowan, Michael - Xylem ***@***.***>; Mention ***@***.***>
Subject: Re: [project-chip/connectedhomeip] Meter Identification Cluster test scripts: TC-MTRID-2.1, TC-MTRID-3.1 (PR #33593)
@michaelleecowan7<https://urldefense.com/v3/__https:/github.com/michaelleecowan7__;!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrBG5-Oqc$> Hey! Taking into account your comment<https://urldefense.com/v3/__https:/github.com/project-chip/connectedhomeip/pull/33593*pullrequestreview-2651932564__;Iw!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrKn7i9gO$>. Looks like our cluster is read-only attributes based and can be changed by application part only on server side. We can't set string (for example) out of constraint with write request or command.
I have tried to look on other already implemented clusters and open PRs and have not managed to find good example of such checks. Mostly it checks constraints based on cluster logic and always has possibility to change it via Write Request or Command.
We checked it manually and looks like such cases are handled correctly, but it can't be fully automated as it required in latest recommendations to test scripts.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/project-chip/connectedhomeip/pull/33593*issuecomment-2711839201__;Iw!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrAoLNApi$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BGA7VPT4OC5B6GZVEJIDLFD2TX5LXAVCNFSM6AAAAABIHS43QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJRHAZTSMRQGE__;!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrO3sNd20$>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
[aburgonov-dsr]aburgonov-dsr left a comment (project-chip/connectedhomeip#33593)<https://urldefense.com/v3/__https:/github.com/project-chip/connectedhomeip/pull/33593*issuecomment-2711839201__;Iw!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrAoLNApi$>
@michaelleecowan7<https://urldefense.com/v3/__https:/github.com/michaelleecowan7__;!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrBG5-Oqc$> Hey! Taking into account your comment<https://urldefense.com/v3/__https:/github.com/project-chip/connectedhomeip/pull/33593*pullrequestreview-2651932564__;Iw!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrKn7i9gO$>. Looks like our cluster is read-only attributes based and can be changed by application part only on server side. We can't set string (for example) out of constraint with write request or command.
I have tried to look on other already implemented clusters and open PRs and have not managed to find good example of such checks. Mostly it checks constraints based on cluster logic and always has possibility to change it via Write Request or Command.
We checked it manually and looks like such cases are handled correctly, but it can't be fully automated as it required in latest recommendations to test scripts.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/project-chip/connectedhomeip/pull/33593*issuecomment-2711839201__;Iw!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrAoLNApi$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BGA7VPT4OC5B6GZVEJIDLFD2TX5LXAVCNFSM6AAAAABIHS43QCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJRHAZTSMRQGE__;!!OKzgfr8!eR69dSWEpvvjcoP8n2FlMIM4aa7QRI0aXfbbcgYZHz5wdbRZL3akGoSXoqSF7hOwwFRTDb-yfHBFaHsCBEmDrO3sNd20$>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
CONFIDENTIALITY NOTICE: This e-mail, including any attachments and/or linked documents, is intended for the sole use of the intended addressee and may contain information that is privileged, confidential, proprietary, or otherwise protected by law. Any unauthorized review, dissemination, distribution, or copying is prohibited. If you have received this communication in error, please contact the original sender immediately by reply email and destroy all copies of the original message and any attachments. Please note that any views or opinions presented in this e-mail are solely those of the author and do not necessarily represent those of Xylem Inc..
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR to the Test Plan:
https://github.com/CHIP-Specifications/chip-test-plans/pull/4179