-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] ICD checkin message can't receive in some Android device #33561
Merged
yunhanw-google
merged 6 commits into
project-chip:master
from
joonhaengHeo:fix_android_icd_checkin_issue
May 23, 2024
Merged
[Android] ICD checkin message can't receive in some Android device #33561
yunhanw-google
merged 6 commits into
project-chip:master
from
joonhaengHeo:fix_android_icd_checkin_issue
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonhaengHeo
changed the title
[Android] Fix ICD checkin message can'issue
[Android] ICD checkin message can't receive in some Android device
May 23, 2024
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
kiel-apple
May 23, 2024 05:46
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 23, 2024 05:46
PR #33561: Size comparison from c3ef110 to 9d7035d Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
May 23, 2024
chulspro
approved these changes
May 23, 2024
PR #33561: Size comparison from c3ef110 to dba568a Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
PR #33561: Size comparison from c3ef110 to 5ce7186 Increases above 0.2%:
Increases (13 builds for cyw30739)
Decreases (9 builds for cyw30739, efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some Android devices, there is an issue where a Check in message is not received when commissioning an ICD Device. To improve this, Dnssd Start/Stop is controlled when the app starts/stops to receive a Check in Message.