-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nl-unit-test with pigweed for messaging #33500
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
May 17, 2024 07:49
arkq
approved these changes
May 17, 2024
jlatusek
force-pushed
the
messaging-pigweed
branch
from
May 20, 2024 15:02
1bb1d16
to
4ca07bf
Compare
PR #33500: Size comparison from 37af39c to 4ca07bf Decreases (1 build for efr32)
Full report (94 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jlatusek
force-pushed
the
messaging-pigweed
branch
from
May 21, 2024 07:25
4ca07bf
to
0899a04
Compare
PR #33500: Size comparison from b77979a to 0899a04 Decreases (1 build for efr32)
Full report (94 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jlatusek
force-pushed
the
messaging-pigweed
branch
from
May 21, 2024 11:42
0899a04
to
f57c75f
Compare
arkq
reviewed
May 22, 2024
jlatusek
force-pushed
the
messaging-pigweed
branch
from
May 22, 2024 11:27
f57c75f
to
50412cf
Compare
PR #33500: Size comparison from 8ae8954 to 50412cf Decreases (1 build for efr32)
Full report (94 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The problem was described in #29342.
Changes
These changes are another piece of replacing the nl-unit test with the pigweed-unit test. I changed tests for the
messaging
.I've swapped the order of calling tests on nrfconnect because there is a problem with running messaging tests after calling the test with the nlunitest framework(probably the nlunittest does not clean everything properly). The nlunittest will be removed in the future so I don't want to resolve the related problem right now.