Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove final keyword from the class contains virtual functions #33498

Merged
merged 1 commit into from
May 21, 2024
Merged

Remove final keyword from the class contains virtual functions #33498

merged 1 commit into from
May 21, 2024

Conversation

yufengwangca
Copy link
Contributor

If the class is declared as final, it cannot be inherited from. Therefore, the virtual member functions are unnecessary.

We should either remove the final keyword from class declaration or the virtual keyword from the member functions of the final class.

I choose to remove the final keyword from the class declaration to align with other RPC service interfaces

@yufengwangca yufengwangca changed the title Remove final keyword to from class contains virtual functions Remove final keyword from the class contains virtual functions May 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

PR #33498: Size comparison from 7b2f729 to ee5c407

Decreases (1 build for efr32)
platform target config section 7b2f729 ee5c407 change % change
efr32 window-app BRD4187C (read/write) 1135888 1135880 -8 -0.0
.text 967932 967924 -8 -0.0
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 7b2f729 ee5c407 change % change
bl602 lighting-app bl602 (read/write) 1446214 1446214 0 0.0
.bss 85896 85896 0 0.0
.data 9512 9512 0 0.0
.rodata 159472 159472 0 0.0
.text 1110674 1110674 0 0.0
bl602+mfd (read/write) 1460646 1460646 0 0.0
.bss 86072 86072 0 0.0
.data 9488 9488 0 0.0
.rodata 158432 158432 0 0.0
.text 1125992 1125992 0 0.0
bl602+rpc (read/write) 1493878 1493878 0 0.0
.bss 93944 93944 0 0.0
.data 9896 9896 0 0.0
.rodata 167048 167048 0 0.0
.text 1142320 1142320 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1212107 1212107 0 0.0
.bss 11185 11185 0 0.0
.data 3720 3720 0 0.0
.rodata 109024 109024 0 0.0
.text 981120 981120 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1223195 1223195 0 0.0
.bss 11361 11361 0 0.0
.data 3696 3696 0 0.0
.rodata 107964 107964 0 0.0
.text 993130 993130 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1303571 1303571 0 0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124396 124396 0 0.0
.text 1055828 1055828 0 0.0
bl706-eth (read/write) 1029213 1029213 0 0.0
.bss 23760 23760 0 0.0
.data 3264 3264 0 0.0
.rodata 102080 102080 0 0.0
.text 771642 771642 0 0.0
bl706-wifi (read/write) 1263286 1263286 0 0.0
.bss 10645 10645 0 0.0
.data 3712 3712 0 0.0
.rodata 123160 123160 0 0.0
.text 1002852 1002852 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1181684 1181684 0 0.0
.bss 16396 16396 0 0.0
.data 5080 5080 0 0.0
.rodata 103028 103028 0 0.0
.text 974234 974234 0 0.0
bl702l+mfd (read/write) 1193600 1193600 0 0.0
.bss 16572 16572 0 0.0
.data 5064 5064 0 0.0
.rodata 101968 101968 0 0.0
.text 986556 986556 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798740 798740 0 0.0
(read/write) 177700 177700 0 0.0
.bss 99612 99612 0 0.0
.data 3604 3604 0 0.0
.rodata 85204 85204 0 0.0
.text 713272 713272 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813960 813960 0 0.0
(read/write) 188172 188172 0 0.0
.bss 110100 110100 0 0.0
.data 3596 3596 0 0.0
.rodata 78776 78776 0 0.0
.text 734920 734920 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 803308 803308 0 0.0
(read/write) 182292 182292 0 0.0
.bss 104220 104220 0 0.0
.data 3596 3596 0 0.0
.rodata 106100 106100 0 0.0
.text 696944 696944 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755612 755612 0 0.0
(read/write) 176644 176644 0 0.0
.bss 98336 98336 0 0.0
.data 3588 3588 0 0.0
.rodata 80852 80852 0 0.0
.text 674496 674496 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 741284 741284 0 0.0
(read/write) 176884 176884 0 0.0
.bss 98576 98576 0 0.0
.data 3588 3588 0 0.0
.rodata 76636 76636 0 0.0
.text 664384 664384 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606718 606718 0 0.0
(read/write) 209716 209716 0 0.0
.bss 202932 202932 0 0.0
.data 1660 1660 0 0.0
.rodata 89766 89766 0 0.0
.text 514832 514832 0 0.0
lock CC3235SF_LAUNCHXL (read only) 652614 652614 0 0.0
(read/write) 209972 209972 0 0.0
.bss 203328 203328 0 0.0
.data 1524 1524 0 0.0
.rodata 110526 110526 0 0.0
.text 539964 539964 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 740195 740195 0 0.0
.app_xip_area 660205 660205 0 0.0
.bss 73588 73588 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 755831 755831 0 0.0
.app_xip_area 672641 672641 0 0.0
.bss 75444 75444 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 755831 755831 0 0.0
.app_xip_area 672641 672641 0 0.0
.bss 75444 75444 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 712051 712051 0 0.0
.app_xip_area 636993 636993 0 0.0
.bss 68712 68712 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 677731 677731 0 0.0
.app_xip_area 602029 602029 0 0.0
.bss 69180 69180 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 693063 693063 0 0.0
.app_xip_area 614249 614249 0 0.0
.bss 71036 71036 0 0.0
.data 2316 2316 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 693063 693063 0 0.0
.app_xip_area 614249 614249 0 0.0
.bss 71036 71036 0 0.0
.data 2316 2316 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 696251 696251 0 0.0
.app_xip_area 617533 617533 0 0.0
.bss 72228 72228 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 711655 711655 0 0.0
.app_xip_area 629825 629825 0 0.0
.bss 74084 74084 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 711655 711655 0 0.0
.app_xip_area 629825 629825 0 0.0
.bss 74084 74084 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 658771 658771 0 0.0
.app_xip_area 586093 586093 0 0.0
.bss 66380 66380 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 674415 674415 0 0.0
.app_xip_area 598529 598529 0 0.0
.bss 68244 68244 0 0.0
.data 2180 2180 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 674415 674415 0 0.0
.app_xip_area 598529 598529 0 0.0
.bss 68244 68244 0 0.0
.data 2180 2180 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1072180 1072180 0 0.0
.bss 180056 180056 0 0.0
.data 3448 3448 0 0.0
.text 888656 888656 0 0.0
lock-app BRD4338a (read/write) 962580 962580 0 0.0
.bss 213204 213204 0 0.0
.data 29448 29448 0 0.0
.text 700560 700560 0 0.0
window-app BRD4187C (read/write) 1135888 1135880 -8 -0.0
.bss 164584 164584 0 0.0
.data 3352 3352 0 0.0
.text 967932 967924 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1215154 1215154 0 0.0
(read/write) 1751704 1751704 0 0.0
.dram0.bss 74744 74744 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 253768 253768 0 0.0
.flash.text 1215154 1215154 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256495 1256495 0 0.0
(read/write) 536308 536308 0 0.0
.dram0.bss 79680 79680 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285512 285512 0 0.0
.flash.text 1250331 1250331 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2721845 2721845 0 0.0
(read/write) 132728 132728 0 0.0
.bss 47880 47880 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 76536 76536 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 187472 187472 0 0.0
.text 2351221 2351221 0 0.0
all-clusters-app debug (read only) 6034705 6034705 0 0.0
(read/write) 484272 484272 0 0.0
.bss 136160 136160 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 336072 336072 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1448 1448 0 0.0
.rodata 354320 354320 0 0.0
.text 5241523 5241523 0 0.0
all-clusters-minimal-app debug (read only) 5318145 5318145 0 0.0
(read/write) 240224 240224 0 0.0
.bss 129024 129024 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 99608 99608 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 293130 293130 0 0.0
.text 4784963 4784963 0 0.0
bridge-app debug (read only) 4708561 4708561 0 0.0
(read/write) 221136 221136 0 0.0
.bss 119552 119552 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 88576 88576 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 233514 233514 0 0.0
.text 4249411 4249411 0 0.0
chip-tool debug (read only) 12162873 12162873 0 0.0
(read/write) 524584 524584 0 0.0
.bss 95160 95160 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 417016 417016 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 454457 454457 0 0.0
.text 10997539 10997539 0 0.0
chip-tool-ipv6only arm64 (read only) 11496092 11496092 0 0.0
(read/write) 589784 589784 0 0.0
.bss 104152 104152 0 0.0
.data 4536 4536 0 0.0
.data.rel.ro 457112 457112 0 0.0
.dynamic 512 512 0 0.0
.got 17272 17272 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 358460 358460 0 0.0
.text 10252632 10252632 0 0.0
fabric-admin debug (read only) 11915233 11915233 0 0.0
(read/write) 517872 517872 0 0.0
.bss 94520 94520 0 0.0
.data 4866 4866 0 0.0
.data.rel.ro 411480 411480 0 0.0
.dynamic 624 624 0 0.0
.got 5584 5584 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 427065 427065 0 0.0
.text 10791491 10791491 0 0.0
fabric-bridge-app debug (read only) 4574817 4574817 0 0.0
(read/write) 213112 213112 0 0.0
.bss 115104 115104 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86256 86256 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 226922 226922 0 0.0
.text 4124755 4124755 0 0.0
lighting-app debug+rpc+ui (read only) 5632121 5632121 0 0.0
(read/write) 229936 229936 0 0.0
.bss 120496 120496 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 96992 96992 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 357332 357332 0 0.0
.text 5022723 5022723 0 0.0
lock-app debug (read only) 4769617 4769617 0 0.0
(read/write) 208264 208264 0 0.0
.bss 114792 114792 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 82568 82568 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 259370 259370 0 0.0
.text 4293683 4293683 0 0.0
ota-provider-app debug (read only) 4382353 4382353 0 0.0
(read/write) 196864 196864 0 0.0
.bss 114656 114656 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 71824 71824 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 211754 211754 0 0.0
.text 3972691 3972691 0 0.0
ota-requestor-app debug (read only) 4513041 4513041 0 0.0
(read/write) 201232 201232 0 0.0
.bss 115552 115552 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 74928 74928 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 217834 217834 0 0.0
.text 4092755 4092755 0 0.0
shell debug (read only) 3005345 3005345 0 0.0
(read/write) 156856 156856 0 0.0
.bss 60784 60784 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 88792 88792 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 191072 191072 0 0.0
.text 2635122 2635122 0 0.0
thermostat-no-ble arm64 (read only) 4500476 4500476 0 0.0
(read/write) 249888 249888 0 0.0
.bss 123144 123144 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 106008 106008 0 0.0
.dynamic 512 512 0 0.0
.got 9000 9000 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162164 162164 0 0.0
.text 3996776 3996776 0 0.0
tv-app debug (read only) 5830121 5830121 0 0.0
(read/write) 352992 352992 0 0.0
.bss 242672 242672 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 96472 96472 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 297834 297834 0 0.0
.text 5285891 5285891 0 0.0
tv-casting-app debug (read only) 9997673 9997673 0 0.0
(read/write) 343184 343184 0 0.0
.bss 156760 156760 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 176432 176432 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 388088 388088 0 0.0
.text 9138451 9138451 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536680 2536680 0 0.0
.bss 220928 220928 0 0.0
.data 5224 5224 0 0.0
.text 1499364 1499364 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061312 1061312 0 0.0
bss 139209 139209 0 0.0
rodata 101840 101840 0 0.0
text 772988 772988 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1238556 1238556 0 0.0
bss 137637 137637 0 0.0
rodata 151444 151444 0 0.0
text 799432 799432 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1009000 1009000 0 0.0
bss 138107 138107 0 0.0
rodata 89096 89096 0 0.0
text 734576 734576 0 0.0
nxp contact k32w0+release (read only) 576444 576444 0 0.0
(read/write) 83220 83220 0 0.0
.bss 67920 67920 0 0.0
.data 2204 2204 0 0.0
.text 575908 575908 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704308 704308 0 0.0
.bss 71272 71272 0 0.0
.data 2872 2872 0 0.0
.text 590784 590784 0 0.0
light k32w0+release (read only) 610624 610624 0 0.0
(read/write) 82688 82688 0 0.0
.bss 67376 67376 0 0.0
.data 2224 2224 0 0.0
.text 610088 610088 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 796256 796256 0 0.0
.bss 80816 80816 0 0.0
.data 2080 2080 0 0.0
.text 673992 673992 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826128 826128 0 0.0
(read/write) 1827444 1827444 0 0.0
.bss 204460 204460 0 0.0
.data 2752 2752 0 0.0
.text 1611844 1611844 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829224 829224 0 0.0
(read/write) 1748716 1748716 0 0.0
.bss 201388 201388 0 0.0
.data 2728 2728 0 0.0
.text 1536212 1536212 0 0.0
light cy8ckit_062s2_43012 (read only) 835944 835944 0 0.0
(read/write) 1667156 1667156 0 0.0
.bss 194852 194852 0 0.0
.data 2544 2544 0 0.0
.text 1461372 1461372 0 0.0
lock cy8ckit_062s2_43012 (read only) 808880 808880 0 0.0
(read/write) 1695820 1695820 0 0.0
.bss 221932 221932 0 0.0
.data 2528 2528 0 0.0
.text 1462972 1462972 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134260 1134260 0 0.0
.bss 102676 102676 0 0.0
.data 864 864 0 0.0
.text 646640 646640 0 0.0
lock-app qpg6105+debug (read/write) 1094076 1094076 0 0.0
.bss 97340 97340 0 0.0
.data 876 876 0 0.0
.text 606460 606460 0 0.0
stm32 light STM32WB5MM-DK (read/write) 606849 606849 0 0.0
.bss 128548 128548 0 0.0
.data 696 696 0 0.0
.rodata 80668 80668 0 0.0
.text 387192 387192 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 835058 835058 0 0.0
bss 49944 49944 0 0.0
text 625418 625418 0 0.0
all-clusters-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 843552 843552 0 0.0
bss 79088 79088 0 0.0
noinit 46096 46096 0 0.0
text 601330 601330 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1059988 1059988 0 0.0
bss 110132 110132 0 0.0
text 773504 773504 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 915532 915532 0 0.0
bss 92888 92888 0 0.0
text 657004 657004 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 837418 837418 0 0.0
bss 49988 49988 0 0.0
text 627836 627836 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 948500 948500 0 0.0
bss 76580 76580 0 0.0
text 714788 714788 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 772060 772060 0 0.0
bss 75336 75336 0 0.0
noinit 46096 46096 0 0.0
text 557886 557886 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1092104 1092104 0 0.0
bss 99980 99980 0 0.0
text 795204 795204 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 912512 912512 0 0.0
bss 69268 69268 0 0.0
text 661224 661224 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 934724 934724 0 0.0
bss 92620 92620 0 0.0
text 676312 676312 0 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831992 831992 0 0.0
bss 58232 58232 0 0.0
text 621860 621860 0 0.0
pump-controller-app tlsr9118bdk40d (read only) 160 160 0 0.0
(read/write) 607488 607488 0 0.0
bss 44160 44160 0 0.0
noinit 32512 32512 0 0.0
text 451088 451088 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 674836 674836 0 0.0
bss 71852 71852 0 0.0
text 461970 461970 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 845270 845270 0 0.0
bss 51616 51616 0 0.0
text 634502 634502 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 860113 860113 0 0.0
bss 59804 59804 0 0.0
text 643430 643430 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 826644 826644 0 0.0
bss 56492 56492 0 0.0
text 619298 619298 0 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 836696 836696 0 0.0
bss 58448 58448 0 0.0
text 624144 624144 0 0.0

andy31415
andy31415 previously approved these changes May 17, 2024
View reviewed changes
@andy31415 andy31415 dismissed their stale review May 17, 2024 13:58

I am unsure of the approach - what do we want to override?

@mergify mergify bot merged commit 3c6bd79 into project-chip:master May 21, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yufengwangca @andy31415