-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: remove _handleAttributeReport
convenience method
#33489
Merged
mergify
merged 2 commits into
project-chip:master
from
kiel-apple:darwin-remove-handleAttributeReport-convenience-method
May 17, 2024
Merged
Darwin: remove _handleAttributeReport
convenience method
#33489
mergify
merged 2 commits into
project-chip:master
from
kiel-apple:darwin-remove-handleAttributeReport-convenience-method
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #33489: Size comparison from f980f2c to 76a6f5f Full report (14 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, qpg, stm32)
|
2 tasks
PR #33489: Size comparison from f980f2c to 476607d Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
kiel-apple
force-pushed
the
darwin-remove-handleAttributeReport-convenience-method
branch
from
May 16, 2024 21:24
476607d
to
1da1c7a
Compare
PR #33489: Size comparison from 7b2f729 to 1da1c7a Full report (47 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
kiel-apple
force-pushed
the
darwin-remove-handleAttributeReport-convenience-method
branch
from
May 16, 2024 22:25
1da1c7a
to
6fe4a3d
Compare
bzbarsky-apple
approved these changes
May 16, 2024
pullapprove
bot
requested review from
arkq,
bauerschwan,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no and
kpschoedel
May 16, 2024 22:33
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
younghak-hwang and
yufengwangca
May 16, 2024 22:33
PR #33489: Size comparison from 7b2f729 to 6fe4a3d Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
kiel-apple
force-pushed
the
darwin-remove-handleAttributeReport-convenience-method
branch
from
May 17, 2024 16:55
6fe4a3d
to
15a3a72
Compare
nivi-apple
approved these changes
May 17, 2024
PR #33489: Size comparison from fa28631 to 15a3a72 Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
andy31415
approved these changes
May 17, 2024
…ption` explicit for remaining callsites
…mSubscription:YES`. also allow configuration for all unit test attribute report injections.
kiel-apple
force-pushed
the
darwin-remove-handleAttributeReport-convenience-method
branch
from
May 17, 2024 17:25
15a3a72
to
d7857fa
Compare
PR #33489: Size comparison from 4c2afbd to d7857fa Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
kiel-apple
deleted the
darwin-remove-handleAttributeReport-convenience-method
branch
September 5, 2024 23:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per previous PR discussion, force callers to explicitly declare whether or not the report is from a subscription.