-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux tv-casting-app v1.3 Commissioner-Generated passcode flow #33479
Linux tv-casting-app v1.3 Commissioner-Generated passcode flow #33479
Conversation
df2e7a5
to
82b0cb1
Compare
PR #33479: Size comparison from be581ef to 82b0cb1 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/CastingPlayer.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/ConnectionCallbacks.h
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/ConnectionCallbacks.h
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/tv-casting-common/core/ConnectionCallbacks.h
Outdated
Show resolved
Hide resolved
PR #33479: Size comparison from be581ef to 73e26f7 Increases above 0.2%:
Increases (5 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding approve for consensus and some general readability. I am insufficiently familiar with TV apps logic and leaving it up to TV maintainers to review logic here.
Linux tv-casting-app example app, implemented new Matter v1.3 Matter Casting User Directed Commissioning (UDC) feature commissioner-generated passcode flow.
Change summary
Testing
Verified and tested locally with the Linux, Android and iOS tv-casting-app example mobile apps, and the Linux tv-app (CastingPlayer). With the Linux example tv-casting-app app, we are able to successfully commission using the commissioner generated passcode flow as follows:
Usage