-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDeviceController to limit concurrent subscriptions to Thread-enabled devices #33472
Merged
woody-apple
merged 27 commits into
project-chip:master
from
jtung-apple:jtung/darwin-mtrdevice-throttle-subscriptions
May 16, 2024
Merged
[Darwin] MTRDeviceController to limit concurrent subscriptions to Thread-enabled devices #33472
woody-apple
merged 27 commits into
project-chip:master
from
jtung-apple:jtung/darwin-mtrdevice-throttle-subscriptions
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead-enabled devices
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 15, 2024 14:15
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33472: Size comparison from f4e02d4 to c92d8e5 Increases above 0.2%:
Increases (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Decreases (27 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, stm32)
Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
woody-apple
reviewed
May 16, 2024
woody-apple
reviewed
May 16, 2024
woody-apple
reviewed
May 16, 2024
woody-apple
reviewed
May 16, 2024
woody-apple
approved these changes
May 16, 2024
woody-apple
reviewed
May 16, 2024
woody-apple
reviewed
May 16, 2024
PR #33472: Size comparison from f4e02d4 to b8df5fd Increases above 0.2%:
Increases (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
Decreases (27 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, stm32)
Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
PR #33472: Size comparison from f4e02d4 to a59d18e Increases above 0.2%:
Increases (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (32 builds for cc13x4_26x4, cyw30739, esp32, linux, nrfconnect, psoc6, stm32, telink)
Full report (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to throttle concurrent subscriptions to Thread-enabled devices, to avoid flooding the Thread network.
Specific changes:
OnResubscriptionNeeded
retry count etc., fromMTRBaseSubscriptionCallback
to the localSubscriptionCallback
inMTRDevice.m
.Currently working on unit tests.