-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Disable metric collector debug logging #33458
Merged
woody-apple
merged 1 commit into
project-chip:master
from
anush-apple:darwin-reduce-noisy-logging
May 15, 2024
Merged
[Darwin] Disable metric collector debug logging #33458
woody-apple
merged 1 commit into
project-chip:master
from
anush-apple:darwin-reduce-noisy-logging
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anush-apple
commented
May 14, 2024
- The debug logging in metrics collector is very noisy and debug is enabled by default.
- Disabling the metrics debug logging since it is not really useful except for developer development mode debugging, which is recompile and test.
- The debug logging in metrics collector is very noisy and debug is enabled by default. - Disabling the metrics debug logging since it is not really useful except for developer development mode debugging, which is recompile and test.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
lazarkov and
lpbeliveau-silabs
May 14, 2024 22:36
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 14, 2024 22:36
yufengwangca
approved these changes
May 14, 2024
PR #33458: Size comparison from c7f7984 to 77f4713 Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
ksperling-apple
approved these changes
May 14, 2024
Fast-tracking Darwin-only change. |
woody-apple
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.