-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric-Sync] Run interactive mode in Fabric-Admin by default #33455
Merged
mergify
merged 3 commits into
project-chip:master
from
yufengwangca:pr/example/fabric-admin
May 16, 2024
Merged
[Fabric-Sync] Run interactive mode in Fabric-Admin by default #33455
mergify
merged 3 commits into
project-chip:master
from
yufengwangca:pr/example/fabric-admin
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yufengwangca
commented
May 14, 2024
- Run interactive mode in Fabric-Admin by default
- Redirect the system logging from console to to /tmp/fabric_admin.log
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
May 14, 2024 20:22
pullapprove
bot
requested review from
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
May 14, 2024 20:22
PR #33455: Size comparison from 3fe770c to 47b8ea3 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, qpg, stm32)
|
PR #33455: Size comparison from 85295b5 to 4badb2a Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
examples/fabric-admin/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
examples/fabric-admin/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
examples/fabric-admin/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
examples/fabric-admin/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
tehampson
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I thought I submitted these comments earlier today, realizing now that it was only a draft
Sorry for the delay
examples/fabric-admin/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
…tor to commands.Run()
PR #33455: Size comparison from be581ef to b662d53 Increases (1 build for linux)
Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tcarmelveilleux
approved these changes
May 16, 2024
tehampson
approved these changes
May 16, 2024
jmartinez-silabs
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.