Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openthread] Fixed potential usage fault #33434

Merged
merged 1 commit into from
May 14, 2024
Merged

[openthread] Fixed potential usage fault #33434

merged 1 commit into from
May 14, 2024

Conversation

kkasperczyk-no
Copy link
Contributor

Pointer to the ThreadDiagnosticsDelegate is used without a null check. It leads to the usage fault, if ThreadNetworkDiagnostics cluster is disabled and pointer is set to nullptr.

@kkasperczyk-no
[openthread] Fixed potential usage fault
6e288f2 
Pointer to the ThreadDiagnosticsDelegate is used without a null
check. It leads to the usage fault, if ThreadNetworkDiagnostics
cluster is disabled and pointer is set to nullptr.
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

PR #33434: Size comparison from 3219a5f to 6e288f2

Increases (31 builds for bl702, bl702l, cc13x4_26x4, cyw30739, nxp, stm32, telink)
platform target config section 3219a5f 6e288f2 change % change
bl702 lighting-app bl702 (read/write) 1210823 1210827 4 0.0
.text 979932 979934 2 0.0
bl702+mfd .text 991942 991944 2 0.0
bl702+rpc (read/write) 1302287 1302291 4 0.0
.text 1054640 1054642 2 0.0
bl702l lighting-app bl702l .text 973046 973048 2 0.0
bl702l+mfd (read/write) 1191804 1192320 516 0.0
.text 985368 985370 2 0.0
cc13x4_26x4 lock-ftd LP_EM_CC1354P10_6 (read only) 813840 813848 8 0.0
.text 734760 734768 8 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 803164 803172 8 0.0
.text 696760 696768 8 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755420 755428 8 0.0
.text 674256 674264 8 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742323 742331 8 0.0
.app_xip_area 660557 660565 8 0.0
CYW30739B2-P5-EVK-02 (read/write) 757967 757975 8 0.0
.app_xip_area 673001 673009 8 0.0
CYW30739B2-P5-EVK-03 (read/write) 757967 757975 8 0.0
.app_xip_area 673001 673009 8 0.0
CYW930739M2EVB-02 (read/write) 714179 714187 8 0.0
.app_xip_area 637345 637353 8 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 679843 679851 8 0.0
.app_xip_area 602365 602373 8 0.0
nxp light k32w1+release (read/write) 796120 796128 8 0.0
.text 673896 673904 8 0.0
stm32 light STM32WB5MM-DK (read/write) 606729 606737 8 0.0
.text 387080 387088 8 0.0
telink air-quality-sensor-app tlsr9528a_retention text 624598 624600 2 0.0
all-clusters-app tlsr9518adk80d text 797276 797278 2 0.0
all-clusters-minimal-app tlsr9528a text 772616 772618 2 0.0
bridge-app tlsr9518adk80d text 656210 656212 2 0.0
contact-sensor-app tlsr9528a_retention text 627018 627020 2 0.0
light-switch-app-ota-shell-factory-data tlsr9528a text 703624 703626 2 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d text 794084 794086 2 0.0
lock-app-dfu tlsr9528a text 660384 660386 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 933404 933412 8 0.0
text 675196 675198 2 0.0
pump-app tlsr9258a text 621022 621024 2 0.0
pump-controller-app tlsr9518adk80d text 598894 598896 2 0.0
shell tlsr9518adk80d (read/write) 676416 676420 4 0.0
text 461828 461830 2 0.0
smoke_co_alarm-app tlsr9528a_retention text 633686 633688 2 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d text 642434 642436 2 0.0
thermostat tlsr9518adk80d text 618456 618458 2 0.0
window-covering tlsr9258a text 623290 623292 2 0.0
Decreases (2 builds for efr32)
platform target config section 3219a5f 6e288f2 change % change
efr32 lock-app BRD4338a (read/write) 962300 962292 -8 -0.0
.text 700392 700384 -8 -0.0
window-app BRD4187C (read/write) 1135696 1135688 -8 -0.0
.text 967764 967756 -8 -0.0
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 3219a5f 6e288f2 change % change
bl602 lighting-app bl602 (read/write) 1444854 1444854 0 0.0
.bss 85776 85776 0 0.0
.data 9512 9512 0 0.0
.rodata 159424 159424 0 0.0
.text 1109476 1109476 0 0.0
bl602+mfd (read/write) 1459278 1459278 0 0.0
.bss 85952 85952 0 0.0
.data 9488 9488 0 0.0
.rodata 158384 158384 0 0.0
.text 1124794 1124794 0 0.0
bl602+rpc (read/write) 1492526 1492526 0 0.0
.bss 93824 93824 0 0.0
.data 9896 9896 0 0.0
.rodata 167000 167000 0 0.0
.text 1141122 1141122 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210823 1210827 4 0.0
.bss 11185 11185 0 0.0
.data 3720 3720 0 0.0
.rodata 108976 108976 0 0.0
.text 979932 979934 2 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1221911 1221911 0 0.0
.bss 11361 11361 0 0.0
.data 3696 3696 0 0.0
.rodata 107916 107916 0 0.0
.text 991942 991944 2 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1302287 1302291 4 0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124348 124348 0 0.0
.text 1054640 1054642 2 0.0
bl706-eth (read/write) 1027861 1027861 0 0.0
.bss 23760 23760 0 0.0
.data 3264 3264 0 0.0
.rodata 102032 102032 0 0.0
.text 770450 770450 0 0.0
bl706-wifi (read/write) 1261918 1261918 0 0.0
.bss 10645 10645 0 0.0
.data 3712 3712 0 0.0
.rodata 123112 123112 0 0.0
.text 1001644 1001644 0 0.0
bl702l lighting-app bl702l (read/write) 1180912 1180912 0 0.0
.bss 16396 16396 0 0.0
.data 5080 5080 0 0.0
.rodata 102980 102980 0 0.0
.text 973046 973048 2 0.0
bl702l+mfd (read/write) 1191804 1192320 516 0.0
.bss 16572 16572 0 0.0
.data 5064 5064 0 0.0
.rodata 101920 101920 0 0.0
.text 985368 985370 2 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798596 798596 0 0.0
(read/write) 177660 177660 0 0.0
.bss 99572 99572 0 0.0
.data 3604 3604 0 0.0
.rodata 85236 85236 0 0.0
.text 713096 713096 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813840 813848 8 0.0
(read/write) 188132 188132 0 0.0
.bss 110060 110060 0 0.0
.data 3596 3596 0 0.0
.rodata 78816 78816 0 0.0
.text 734760 734768 8 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 803164 803172 8 0.0
(read/write) 182252 182252 0 0.0
.bss 104180 104180 0 0.0
.data 3596 3596 0 0.0
.rodata 106140 106140 0 0.0
.text 696760 696768 8 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755420 755428 8 0.0
(read/write) 176612 176612 0 0.0
.bss 98304 98304 0 0.0
.data 3588 3588 0 0.0
.rodata 80900 80900 0 0.0
.text 674256 674264 8 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 741140 741140 0 0.0
(read/write) 176844 176844 0 0.0
.bss 98536 98536 0 0.0
.data 3588 3588 0 0.0
.rodata 76676 76676 0 0.0
.text 664200 664200 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606558 606558 0 0.0
(read/write) 209596 209596 0 0.0
.bss 202812 202812 0 0.0
.data 1660 1660 0 0.0
.rodata 89718 89718 0 0.0
.text 514716 514716 0 0.0
lock CC3235SF_LAUNCHXL (read only) 652446 652446 0 0.0
(read/write) 209852 209852 0 0.0
.bss 203208 203208 0 0.0
.data 1524 1524 0 0.0
.rodata 110478 110478 0 0.0
.text 539848 539848 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742323 742331 8 0.0
.app_xip_area 660557 660565 8 0.0
.bss 75364 75364 0 0.0
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 757967 757975 8 0.0
.app_xip_area 673001 673009 8 0.0
.bss 77220 77220 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 757967 757975 8 0.0
.app_xip_area 673001 673009 8 0.0
.bss 77220 77220 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 714179 714187 8 0.0
.app_xip_area 637345 637353 8 0.0
.bss 70488 70488 0 0.0
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 679843 679851 8 0.0
.app_xip_area 602365 602373 8 0.0
.bss 70956 70956 0 0.0
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 695183 695183 0 0.0
.app_xip_area 614593 614593 0 0.0
.bss 72812 72812 0 0.0
.data 2316 2316 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 695183 695183 0 0.0
.app_xip_area 614593 614593 0 0.0
.bss 72812 72812 0 0.0
.data 2316 2316 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 698387 698387 0 0.0
.app_xip_area 617893 617893 0 0.0
.bss 74004 74004 0 0.0
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 713799 713799 0 0.0
.app_xip_area 630193 630193 0 0.0
.bss 75860 75860 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 713799 713799 0 0.0
.app_xip_area 630193 630193 0 0.0
.bss 75860 75860 0 0.0
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 660915 660915 0 0.0
.app_xip_area 586453 586453 0 0.0
.bss 68164 68164 0 0.0
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 676559 676559 0 0.0
.app_xip_area 598889 598889 0 0.0
.bss 70028 70028 0 0.0
.data 2180 2180 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 676559 676559 0 0.0
.app_xip_area 598889 598889 0 0.0
.bss 70028 70028 0 0.0
.data 2180 2180 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1072044 1072044 0 0.0
.bss 180008 180008 0 0.0
.data 3448 3448 0 0.0
.text 888568 888568 0 0.0
lock-app BRD4338a (read/write) 962300 962292 -8 -0.0
.bss 213092 213092 0 0.0
.data 29448 29448 0 0.0
.text 700392 700384 -8 -0.0
window-app BRD4187C (read/write) 1135696 1135688 -8 -0.0
.bss 164560 164560 0 0.0
.data 3352 3352 0 0.0
.text 967764 967756 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214916 1214916 0 0.0
(read/write) 1751544 1751544 0 0.0
.dram0.bss 74624 74624 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 253736 253736 0 0.0
.flash.text 1214916 1214916 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256479 1256479 0 0.0
(read/write) 538148 538148 0 0.0
.dram0.bss 81384 81384 0 0.0
.dram0.data 35196 35196 0 0.0
.flash.rodata 285648 285648 0 0.0
.flash.text 1250315 1250315 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2720653 2720653 0 0.0
(read/write) 132536 132536 0 0.0
.bss 47752 47752 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 187504 187504 0 0.0
.text 2350117 2350117 0 0.0
all-clusters-app debug (read only) 6033401 6033401 0 0.0
(read/write) 484048 484048 0 0.0
.bss 136032 136032 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 335976 335976 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1448 1448 0 0.0
.rodata 354352 354352 0 0.0
.text 5240307 5240307 0 0.0
all-clusters-minimal-app debug (read only) 5316809 5316809 0 0.0
(read/write) 240000 240000 0 0.0
.bss 128896 128896 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 99512 99512 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 293162 293162 0 0.0
.text 4783715 4783715 0 0.0
bridge-app debug (read only) 4707353 4707353 0 0.0
(read/write) 220912 220912 0 0.0
.bss 119424 119424 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 88480 88480 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 233546 233546 0 0.0
.text 4248291 4248291 0 0.0
chip-tool debug (read only) 12156385 12156385 0 0.0
(read/write) 524328 524328 0 0.0
.bss 95000 95000 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 416928 416928 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 454489 454489 0 0.0
.text 10991139 10991139 0 0.0
chip-tool-ipv6only arm64 (read only) 11483436 11483436 0 0.0
(read/write) 590024 590024 0 0.0
.bss 104008 104008 0 0.0
.data 4536 4536 0 0.0
.data.rel.ro 457024 457024 0 0.0
.dynamic 512 512 0 0.0
.got 17264 17264 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 358476 358476 0 0.0
.text 10240152 10240152 0 0.0
fabric-bridge-app debug (read only) 4573593 4573593 0 0.0
(read/write) 212888 212888 0 0.0
.bss 114976 114976 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86160 86160 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 226954 226954 0 0.0
.text 4123619 4123619 0 0.0
lighting-app debug+rpc+ui (read only) 5630881 5630881 0 0.0
(read/write) 229712 229712 0 0.0
.bss 120368 120368 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 96912 96912 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 357332 357332 0 0.0
.text 5021603 5021603 0 0.0
lock-app debug (read only) 4768393 4768393 0 0.0
(read/write) 208040 208040 0 0.0
.bss 114664 114664 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 82472 82472 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 259402 259402 0 0.0
.text 4292547 4292547 0 0.0
ota-provider-app debug (read only) 4381065 4381065 0 0.0
(read/write) 196640 196640 0 0.0
.bss 114528 114528 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 71728 71728 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 211786 211786 0 0.0
.text 3971491 3971491 0 0.0
ota-requestor-app debug (read only) 4511721 4511721 0 0.0
(read/write) 201008 201008 0 0.0
.bss 115424 115424 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 74848 74848 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 217834 217834 0 0.0
.text 4091555 4091555 0 0.0
shell debug (read only) 3004617 3004617 0 0.0
(read/write) 159448 159448 0 0.0
.bss 63504 63504 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 88672 88672 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 191264 191264 0 0.0
.text 2634274 2634274 0 0.0
thermostat-no-ble arm64 (read only) 4499180 4499180 0 0.0
(read/write) 246896 246896 0 0.0
.bss 123000 123000 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 105920 105920 0 0.0
.dynamic 512 512 0 0.0
.got 8992 8992 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162180 162180 0 0.0
.text 3995656 3995656 0 0.0
tv-app debug (read only) 5828785 5828785 0 0.0
(read/write) 355296 355296 0 0.0
.bss 245136 245136 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 96312 96312 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 298026 298026 0 0.0
.text 5284435 5284435 0 0.0
tv-casting-app debug (read only) 9992017 9992017 0 0.0
(read/write) 345776 345776 0 0.0
.bss 159512 159512 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 176272 176272 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 388280 388280 0 0.0
.text 9132675 9132675 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536520 2536520 0 0.0
.bss 220808 220808 0 0.0
.data 5224 5224 0 0.0
.text 1499204 1499204 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061220 1061220 0 0.0
bss 139161 139161 0 0.0
rodata 101876 101876 0 0.0
text 772860 772860 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1238316 1238316 0 0.0
bss 137517 137517 0 0.0
rodata 151420 151420 0 0.0
text 799340 799340 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1008860 1008860 0 0.0
bss 138059 138059 0 0.0
rodata 89132 89132 0 0.0
text 734408 734408 0 0.0
nxp contact k32w0+release (read only) 576332 576332 0 0.0
(read/write) 83188 83188 0 0.0
.bss 67888 67888 0 0.0
.data 2204 2204 0 0.0
.text 575796 575796 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704164 704164 0 0.0
.bss 71240 71240 0 0.0
.data 2872 2872 0 0.0
.text 590672 590672 0 0.0
light k32w0+release (read only) 610544 610544 0 0.0
(read/write) 82648 82648 0 0.0
.bss 67336 67336 0 0.0
.data 2224 2224 0 0.0
.text 610008 610008 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 796120 796128 8 0.0
.bss 80776 80776 0 0.0
.data 2080 2080 0 0.0
.text 673896 673904 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826248 826248 0 0.0
(read/write) 1827116 1827116 0 0.0
.bss 204340 204340 0 0.0
.data 2752 2752 0 0.0
.text 1611636 1611636 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829344 829344 0 0.0
(read/write) 1748388 1748388 0 0.0
.bss 201268 201268 0 0.0
.data 2728 2728 0 0.0
.text 1536004 1536004 0 0.0
light cy8ckit_062s2_43012 (read only) 836064 836064 0 0.0
(read/write) 1666860 1666860 0 0.0
.bss 194732 194732 0 0.0
.data 2544 2544 0 0.0
.text 1461196 1461196 0 0.0
lock cy8ckit_062s2_43012 (read only) 809000 809000 0 0.0
(read/write) 1695508 1695508 0 0.0
.bss 221812 221812 0 0.0
.data 2528 2528 0 0.0
.text 1462780 1462780 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134196 1134196 0 0.0
.bss 102636 102636 0 0.0
.data 864 864 0 0.0
.text 646576 646576 0 0.0
lock-app qpg6105+debug (read/write) 1093956 1093956 0 0.0
.bss 97308 97308 0 0.0
.data 876 876 0 0.0
.text 606340 606340 0 0.0
stm32 light STM32WB5MM-DK (read/write) 606729 606737 8 0.0
.bss 128500 128500 0 0.0
.data 696 696 0 0.0
.rodata 80708 80708 0 0.0
.text 387080 387088 8 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834118 834118 0 0.0
bss 49884 49884 0 0.0
text 624598 624600 2 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096468 1096468 0 0.0
bss 101552 101552 0 0.0
text 797276 797278 2 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058960 1058960 0 0.0
bss 110048 110048 0 0.0
text 772616 772618 2 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914600 914600 0 0.0
bss 92804 92804 0 0.0
text 656210 656212 2 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836486 836486 0 0.0
bss 49928 49928 0 0.0
text 627018 627020 2 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937436 937436 0 0.0
bss 77540 77540 0 0.0
text 703624 703626 2 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090800 1090800 0 0.0
bss 99876 99876 0 0.0
text 794084 794086 2 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911556 911556 0 0.0
bss 69208 69208 0 0.0
text 660384 660386 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933404 933412 8 0.0
bss 92516 92516 0 0.0
text 675196 675198 2 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831044 831044 0 0.0
bss 58172 58172 0 0.0
text 621022 621024 2 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 800140 800140 0 0.0
bss 56108 56108 0 0.0
text 598894 598896 2 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676416 676420 4 0.0
bss 73388 73388 0 0.0
text 461828 461830 2 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844338 844338 0 0.0
bss 51556 51556 0 0.0
text 633686 633688 2 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858965 858965 0 0.0
bss 59724 59724 0 0.0
text 642434 642436 2 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825688 825688 0 0.0
bss 56432 56432 0 0.0
text 618456 618458 2 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835732 835732 0 0.0
bss 58388 58388 0 0.0
text 623290 623292 2 0.0

@mergify mergify bot merged commit 052f162 into project-chip:master May 14, 2024
67 checks passed
kkasperczyk-no added a commit to kkasperczyk-no/connectedhomeip that referenced this pull request May 14, 2024
@kkasperczyk-no
[openthread] Fixed potential usage fault (project-chip#33434)
2db44eb 
Pointer to the ThreadDiagnosticsDelegate is used without a null
check. It leads to the usage fault, if ThreadNetworkDiagnostics
cluster is disabled and pointer is set to nullptr.
LuDuda
LuDuda reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mergify bot pushed a commit that referenced this pull request May 14, 2024
@kkasperczyk-no
[openthread] Fixed potential usage fault (#33434) (#33440)
c76613c 
Pointer to the ThreadDiagnosticsDelegate is used without a null
check. It leads to the usage fault, if ThreadNetworkDiagnostics
cluster is disabled and pointer is set to nullptr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuDuda LuDuda LuDuda left review comments

@markaj-nordic markaj-nordic markaj-nordic approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@arkq arkq arkq approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kkasperczyk-no @LuDuda @arkq @Damian-Nordic @markaj-nordic