-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember compatibility layer - split out GlobalAttributeAccessInterface and the I/O buffer #33396
Merged
mergify
merged 9 commits into
project-chip:master
from
andy31415:ember_compatibility_split
May 14, 2024
Merged
Ember compatibility layer - split out GlobalAttributeAccessInterface and the I/O buffer #33396
mergify
merged 9 commits into
project-chip:master
from
andy31415:ember_compatibility_split
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When looking to implement the ember/codegen data mode, some functionality in ember-compatibility-functions needs sharing to avoid extra copy&paste bloat: - Global attribute handling via AAI split into a separate file - Raw "data I/O" buffer split into a separate file Moved privilege-storage and implemented a few more mock ember methods.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 9, 2024 20:40
pullapprove
bot
requested review from
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 9, 2024 20:40
pullapprove
bot
added
app
github
workflows
tests
and removed
app
github
workflows
tests
labels
May 9, 2024
PR #33396: Size comparison from 550b1c1 to 777dd94 Increases above 0.2%:
Increases (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for psoc6)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Add additional comments.
PR #33396: Size comparison from 550b1c1 to ce59a6d Increases above 0.2%:
Increases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
PR #33396: Size comparison from 93aa97d to cf9a3a2 Increases above 0.2%:
Increases (79 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for psoc6)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
yufengwangca
approved these changes
May 13, 2024
bzbarsky-apple
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are code sharing changes to support future development for a ember-backed data provider, implementing the interface defined in #32914
Changes
MandatoryGlobalAttributeReader
andGlobalAttributeReader
into a separate cpp/header:ember-global-attribute-access-interface
since these are ember-backedattributeData
intoember-io-storage.h/cpp
and exposed it as aMutableByteSpan
(so have access to size, however no sizeof usage anymore ... this loses some compile-time asserts, however that should be safe as the minimum size of this span is 8 and compile-time asserts were previously done for numeric types only)BaseType
function into ember-io-storage as well and renamed toAttributeBaseType
with documentation to make things clearer about usageprivilege-storagec.pp
into ember mocking as this seems to be very tightly coupled with ember in general. Removed the corresponding stubs from integration tests (as they can now use the mocks)emberAfLocateAttributeMetadata
emberAfFindClusterInType
For mocks, also provide a ATTRIBUTE_LARGEST which I initialized to the all-clusters-app size (1003).