cluster model decoupling - declare the codegen (ember) version and implement iteration #33345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
force-pushed
the
imdm/2-ember-iterate
branch
from
5892a36 to
30812a9
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
|
PR #33345: Size comparison from 72450e4 to 7fda3b6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33345: Size comparison from 853a386 to 8ff725d Full report (8 builds for cc32xx, mbed, qpg, stm32, tizen)
|
|
PR #33345: Size comparison from 853a386 to b52b362 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33345: Size comparison from 853a386 to 41012d9 Full report (3 builds for cc32xx, stm32)
|
|
PR #33345: Size comparison from 853a386 to 988d4d5 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
cecille
approved these changes
Jun 10, 2024
|
PR #33345: Size comparison from 853a386 to 82a6824 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jun 10, 2024
|
PR #33345: Size comparison from 853a386 to 10c48ca Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
pushed a commit
to Alami-Amine/connectedhomeip
that referenced
this pull request
Jun 12, 2024
…plement iteration (project-chip#33345) * Initial copy with a clean history * make linter happy * Restyle * Fix typo * Add nolint: assert will return before we use the underlying value * 2 more fixes regarding unchecked access * Switch some asserts to expects, for better test logic * Model renames * Add renamed files * Add some attribute iteration hint * Make use of the attribute cache * Restyle * Add a cluster iteration hint * Add a few more hints. Ember code still contains loops though, so this may not be ideal still * Add some TODO items for using faster iterations for data. Ember index vs value duality still needs some work * Add a cluster type cache as well. This relies on ember being reasonably static * Add global attribute handling * Fix typing u16 vs unsigned * Fix auto-added include names * Remove back the initialization and make the comment more obvious * Update src/app/codegen-interaction-model/model.gni Co-authored-by: Karsten Sperling <[email protected]> * Code review feedback: added comments * Update src/app/codegen-interaction-model/CodegenDataModel.h Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/codegen-interaction-model/CodegenDataModel.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/codegen-interaction-model/BUILD.gn Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> * Some cleanup logic for event generation - naming and return values as eventid is not the same as event number * Comment fix * More naming updates * Several comment updates and renamed RequestContext to ActionContext * Restyle * Rename to InteractionModelContext * one more rename * Fix typo * Fix tests to compile * More renames of actions to context * One more comment added * Restyle * Address review comments * Restyle * make clang-tidy happy * Operator== exists on optional ... make use of that directly * Started renaming things * Use the right types in Model.h * Make things compile * Skip global attribute handling, add TODOs for reading extra bits from ember * Typo fix * Several flags and correct loading of privileges for attributes * Start implementing command iteration ... still feels awkward and caching will be a pain * We seem to also support fabric scoping detection * implementation is in theory done, need unit tests * Fix iterator name * Mock support for accepted/generated commands, start having unit tests * Better iteration tests on accepted commands * More unit tests and fix bugs * Restyle * More tests, one iteration bug fix * Slight update again * Aiming for more test coverage * More test coverage for edge cases in iteration * Fix code review comment * Restyle * Update src/app/interaction-model/Events.h Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/interaction-model/IterationTypes.h Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/interaction-model/Paths.h Co-authored-by: Boris Zbarsky <[email protected]> * Fix comment about validity * Some kListBegin/End comment updates * Drop kListBegin/End alltogether * Drop groupId * Comment update * Update for data version to be mandatory, add more error reporting and logging * Update to use kInvalid instead of Invalid method * Update flags.set * Use IsServerMask on clusterr class * Use a struct instead of a typedef * Fix compile without error logging * Restyle * Remove command quality that is not supported * Restyle * Rename IsServerMask to IsServer --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Karsten Sperling <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a mostly-empty
CodegenDataModel::Modelexcept attribute-tree iteration.Implement the attribute-tree iteration and add unit tests via ember mocks.
Changes contained:
src/app/codegen-interaction-modelto contain a interaction model that uses code-generated data (i.e. ember/zap metadata) for executionkInvalidstatic constants to iteration types, so it is clear when an invalid value is created