Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPCREDS: Remove all the PICS markers #33336

Merged
merged 1 commit into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ tests:
disabled: true

- label: "Step 6: From TH1 read the CurrentFabricIndex"
PICS: OPCREDS.S.A0005
verification: |
./chip-tool operationalcredentials read current-fabric-index 1 0

Expand Down
13 changes: 0 additions & 13 deletions src/app/tests/suites/certification/Test_TC_OPCREDS_3_4.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ tests:
"Step 4: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_original ICACValue is to set icac_original"
PICS: OPCREDS.S.C07.Rsp
verification: |
Verify that the DUT responds with FAILSAFE_REQUIRED

Expand Down Expand Up @@ -135,7 +134,6 @@ tests:
"Step 6: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_original ICACValue is to set icac_original"
PICS: OPCREDS.S.C07.Rsp
verification: |
Verify that the DUT responds with a NOCResponse with the StatusCode field set to MissingCsr that is status code 4

Expand All @@ -151,7 +149,6 @@ tests:
- label:
"Step 7: TH1 Sends CSRRequest command with the IsForUpdateNOC field
set to false"
PICS: OPCREDS.S.C04.Rsp
verification: |
Verify that the DUT returns a CSRResponse and save as csr_not_update

Expand Down Expand Up @@ -182,15 +179,13 @@ tests:
"Step 9: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_not_for_update ICACValue is to set icac_not_for_update"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true

- label:
"Step 10: TH1 Sends CSRRequest command with the IsForUpdateNOC field
set to true"
PICS: OPCREDS.S.C04.Rsp
verification: |

disabled: true
Expand All @@ -199,7 +194,6 @@ tests:
"Step 11: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_original ICACValue is to set icac_original"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
Expand All @@ -225,7 +219,6 @@ tests:
"Step 14: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_update_new_root ICACValue is to set icac_update_new_root"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
Expand All @@ -247,7 +240,6 @@ tests:
Credentials cluster with the following fields: NOCValue is set to
noc_update_bad_fabric_on_noc ICACValue is to set
icac_update_bad_fabric_on_noc"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
Expand All @@ -269,15 +261,13 @@ tests:
Credentials cluster with the following fields: NOCValue is set to
noc_update_bad_fabric_on_icac ICACValue is to set
icac_update_bad_fabric_on_icac"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true

- label:
"Step 19: TH1 sends AddTrustedRootCertificate command to DUT again
with the RootCACertificate field set to new_root_cert"
PICS: OPCREDS.S.C0b.Rsp
verification: |

disabled: true
Expand All @@ -286,7 +276,6 @@ tests:
"Step 20: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_update_new_root ICACValue is to set icac_update_new_root"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
Expand Down Expand Up @@ -314,7 +303,6 @@ tests:
- label:
"Step 24: TH1 Sends CSRRequest command over PASE with the
IsForUpdateNOC field set to true"
PICS: OPCREDS.S.C04.Rsp
verification: |

disabled: true
Expand All @@ -332,7 +320,6 @@ tests:
"Step 26: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster over PASE with the following fields: NOCValue is
set to noc_pase ICACValue is to set icac_pase"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
4 changes: 0 additions & 4 deletions src/app/tests/suites/certification/Test_TC_OPCREDS_3_5.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ tests:
- label:
"Step 5: TH1 Sends CSRRequest command with the IsForUpdateNOC field
set to true"
PICS: OPCREDS.S.C04.Rsp
verification: |
To get csr nonce give below command 2 times in TH(chip-tool)
echo hex:$(hexdump -vn32 -e'4/4 "%08X" ' /dev/urandom)
Expand Down Expand Up @@ -116,7 +115,6 @@ tests:
"Step 7: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_update1 ICACValue is to set icac_update1"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
Expand Down Expand Up @@ -152,7 +150,6 @@ tests:
- label:
"Step 12: TH1 Sends CSRRequest command with the IsForUpdateNOC field
set to true"
PICS: OPCREDS.S.C04.Rsp
verification: |

disabled: true
Expand All @@ -174,7 +171,6 @@ tests:
"Step 14: TH1 sends the UpdateNOC command to the Node Operational
Credentials cluster with the following fields: NOCValue is set to
noc_update2 ICACValue is to set icac_update2"
PICS: OPCREDS.S.C07.Rsp
verification: |

disabled: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ tests:
- label:
"Step 2: TH1 sends RemoveFabric command with Fabric Index as
FabricIndex_TH1 to DUT"
PICS: OPCREDS.S.C0a.Rsp
verification: |
./chip-tool operationalcredentials remove-fabric 1 1 0

Expand Down
16 changes: 0 additions & 16 deletions src/app/tests/suites/certification/Test_TC_OPCREDS_3_7.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ tests:
- label:
"Step 1: Factory Reset DUT (to ensure NOC list is empty at the
beginning of the following steps)"
PICS: OPCREDS.S.A0000
# verification: ""
# Disabling this step, because the test starts with a DUT device that has just been commissioned by the TH1 commissioner
disabled: true
Expand All @@ -56,7 +55,6 @@ tests:
- label:
"Step 3.1: Save the FabricIndex for TH1 as TH1_Fabric_Index for future
use."
PICS: OPCREDS.S.A0001
identity: "alpha"
command: "readAttribute"
cluster: "Operational Credentials"
Expand All @@ -68,7 +66,6 @@ tests:
"Step 3.2: TH1 does a non-fabric-filtered read of the Fabrics
attribute from the Node Operational Credentials cluster. Save the
FabricIndex for TH1 as TH1_Fabric_Index for future use."
PICS: OPCREDS.S.A0001
identity: "alpha"
command: "readAttribute"
cluster: "Operational Credentials"
Expand All @@ -83,7 +80,6 @@ tests:
- label:
"Step 4: TH1 sends ArmFailSafe command to the DUT with the
ExpiryLengthSeconds field set to 60 seconds"
PICS: CGEN.S.C00.Rsp && CGEN.S.C01.Tx
identity: "alpha"
cluster: "General Commissioning"
command: "ArmFailSafe"
Expand All @@ -100,7 +96,6 @@ tests:

# verification: "Verify that the DUT sends ArmFailSafeResponse command to TH1 with field ErrorCode as OK(0)"
- label: "Step 5: TH1 Sends CSRRequest command with a random 32-byte nonce."
PICS: OPCREDS.S.C04.Rsp
identity: "alpha"
command: "CSRRequest"
cluster: "Operational Credentials"
Expand All @@ -119,7 +114,6 @@ tests:
- label:
"Step 6.1: Read the commissioner root certificate from TH2's fabric.
Save RCAC as Root_CA_Certificate_TH2"
# PICS:
identity: "beta"
cluster: "CommissionerCommands"
command: "GetCommissionerRootCertificate"
Expand All @@ -135,7 +129,6 @@ tests:
TH2. Save ICAC as Intermediate_Certificate_TH2. Save NOC as
Node_Operational_Certificate_TH2. Save IPK as IPK_TH2. Extract the
RCAC public key and save as Root_Public_Key_TH2."
# PICS:
identity: "beta"
cluster: "CommissionerCommands"
command: "IssueNocChain"
Expand All @@ -156,7 +149,6 @@ tests:

# verification: ""
- label: "Step 7.1: Read the commissioner node ID from TH2"
# PICS:
identity: "beta"
cluster: "CommissionerCommands"
command: "GetCommissionerNodeId"
Expand All @@ -169,7 +161,6 @@ tests:
- label:
"Step 7.2: TH1 sends AddTrustedRootCertificate command to DUT with
RootCACertificate set to Root_CA_Certificate_TH2"
PICS: OPCREDS.S.C0b.Rsp
identity: "alpha"
command: "AddTrustedRootCertificate"
cluster: "Operational Credentials"
Expand All @@ -184,7 +175,6 @@ tests:
fields: NOCValue as Node_Operational_Certificate_TH2. ICACValue as
Intermediate_Certificate_TH2. IpkValue as IPK_TH2. CaseAdminSubject as
the NodeID of TH2. AdminVendorId as the Vendor ID of TH2."
PICS: OPCREDS.S.C06.Rsp && OPCREDS.S.C08.Tx
identity: "alpha"
command: "AddNOC"
cluster: "Operational Credentials"
Expand All @@ -207,14 +197,12 @@ tests:

# verification: "Verify that DUT responds with NOCResponse with status code OK"
- label: "Step 9: TH2 starts discovery of DUT using Operational Discovery"
# PICS: ""
# verification: ""
# Disabling this step as this occurs from the AddNOC command being run
disabled: true

- label:
"Step 10: TH2 opens a CASE session with DUT over operational network."
# PICS: ""
identity: "beta"
cluster: "DelayCommands"
command: "WaitForCommissionee"
Expand All @@ -225,7 +213,6 @@ tests:

# verification: "DUT is able to open the CASE session with TH2"
- label: "Step 11: TH2 sends CommissioningComplete command"
PICS: CGEN.S.C05.Tx
nodeId: 0x43211234
identity: "beta"
cluster: "General Commissioning"
Expand All @@ -240,7 +227,6 @@ tests:
"Step 12: TH2 reads the Current Fabric Index attribute from the Node
Operational Credentials cluster. Save the FabricIndex for TH2 as
TH2_Fabric_Index."
PICS: OPCREDS.S.A0001
identity: "beta"
nodeId: 0x43211234
command: "readAttribute"
Expand All @@ -253,7 +239,6 @@ tests:
- label:
"Step 13: TH2 does a non-fabric-filtered read of the Fabrics attribute
from the Node Operational Credentials cluster"
PICS: OPCREDS.S.A0001
identity: "beta"
nodeId: 0x43211234
command: "readAttribute"
Expand All @@ -273,7 +258,6 @@ tests:
- label:
"Step 14: TH1 sends RemoveFabric command to DUT with the FabricIndex
field set to TH2_Fabric_Index."
PICS: OPCREDS.S.C0a.Rsp
identity: "alpha"
command: "RemoveFabric"
cluster: "Operational Credentials"
Expand Down
Loading