Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick into 1.2: Fix off-by-one in look checks for QName iterators. #33280

Merged
merged 1 commit into from
May 2, 2024
Merged

Cherrypick into 1.2: Fix off-by-one in look checks for QName iterators. #33280

merged 1 commit into from
May 2, 2024

Conversation

andy31415
Copy link
Contributor

This cherrypicks #33273

Unit test sizes for the string test were off by one which masked a off-by-one comparison in QName handling.
Update unit test and comparisons. This will disallow backward references to "self" for qnames.

@andy31415 @andreilitvin
Fix off-by-one in look checks for QName iterators. (project-chip#33273)
cfb0c95 
Unit test sizes for the string `test` were off by one which
masked a off-by-one comparison in QName handling.

Update unit test and comparisons. This will disallow
backward references to "self" for qnames.

Co-authored-by: Andrei Litvin <[email protected]>
@github-actions github-actions bot added the lib label May 2, 2024
@andy31415 andy31415 changed the title Cherrypick into 1.3: Fix off-by-one in look checks for QName iterators. Cherrypick into 1.2: Fix off-by-one in look checks for QName iterators. May 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

PR #33280: Size comparison from 3857abd to cfb0c95

Full report (4 builds for mbed, nrfconnect)
platform target config section 3857abd cfb0c95 change % change
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523080 2523080 0 0.0
.bss 219048 219048 0 0.0
.data 5136 5136 0 0.0
.text 1485764 1485764 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1179828 1179828 0 0.0
bss 153980 153980 0 0.0
rodata 118816 118816 0 0.0
text 828124 828124 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1327392 1327392 0 0.0
bss 139990 139990 0 0.0
rodata 134880 134880 0 0.0
text 761868 761868 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1161576 1161576 0 0.0
bss 154219 154219 0 0.0
rodata 113820 113820 0 0.0
text 814620 814620 0 0.0

@andy31415 andy31415 merged commit 69faf5f into project-chip:v1.2-branch May 2, 2024
55 checks passed
tobiasgraf pushed a commit to boschglobal/connectedhomeip that referenced this pull request Jun 4, 2024
@andy31415 @tobiasgraf
Fix off-by-one in look checks for QName iterators. (project-chip#33273)…
c0d0012 
… (project-chip#33280)

Unit test sizes for the string `test` were off by one which
masked a off-by-one comparison in QName handling.

Update unit test and comparisons. This will disallow
backward references to "self" for qnames.

Co-authored-by: Andrei Litvin <[email protected]>
(cherry picked from commit 69faf5f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy31415