Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shell] Reduce memory usage and boileplate code for subcommands #33243

Merged
merged 1 commit into from
May 15, 2024
Merged

[shell] Reduce memory usage and boileplate code for subcommands #33243

merged 1 commit into from
May 15, 2024

Conversation

Damian-Nordic
Copy link
Contributor

  1. Add lightweight CommandSet class to prevent instantiating Shell::Engine, which allows for dynamic command registration, just to create a subshell with a fixed number of subcommands.

    This slightly reduces the RAM usage. Additionally, the command set automatically prints the help texts if no command or "help" command has been submitted.

  2. Add SubShellCommand templatized command handler to remove the boilerplate associated with creating a subshell.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

PR #33243: Size comparison from 416f6a3 to 7cb236a

Increases (3 builds for linux)
platform target config section 416f6a3 7cb236a change % change
linux shell debug .data.rel.ro 87400 87432 32 0.0
tv-app debug .data.rel.ro 95432 95496 64 0.1
tv-casting-app debug .data.rel.ro 174960 175024 64 0.0
Decreases (12 builds for cyw30739, efr32, esp32, linux, telink)
platform target config section 416f6a3 7cb236a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 570727 568431 -2296 -0.4
.app_xip_area 460637 460165 -472 -0.1
.bss 64908 63084 -1824 -2.8
lock cyw930739m2evb_01 (read/write) 552807 550511 -2296 -0.4
.app_xip_area 438045 437573 -472 -0.1
.bss 69572 67748 -1824 -2.6
ota-requestor cyw930739m2evb_01 (read/write) 573479 571191 -2288 -0.4
.app_xip_area 464885 464421 -464 -0.1
.bss 63452 61628 -1824 -2.9
switch cyw930739m2evb_01 (read/write) 565919 563623 -2296 -0.4
.app_xip_area 454141 453669 -472 -0.1
.bss 66556 64732 -1824 -2.7
efr32 lock-app BRD4338a (read/write) 961412 961404 -8 -0.0
.text 699568 699560 -8 -0.0
window-app BRD4187C (read/write) 1136904 1136896 -8 -0.0
.text 968948 968940 -8 -0.0
esp32 all-clusters-app m5stack (read only) 1256495 1256263 -232 -0.0
(read/write) 537684 535700 -1984 -0.4
.dram0.bss 81320 79496 -1824 -2.2
.flash.rodata 285248 285088 -160 -0.1
.flash.text 1250331 1250099 -232 -0.0
linux shell debug (read only) 2941337 2940777 -560 -0.0
(read/write) 157424 154608 -2816 -1.8
.bss 62800 59952 -2848 -4.5
.rodata 187744 187584 -160 -0.1
.text 2578194 2577842 -352 -0.0
tv-app debug (read only) 5788401 5787841 -560 -0.0
(read/write) 353816 351000 -2816 -0.8
.bss 244528 241648 -2880 -1.2
.rodata 295274 295114 -160 -0.1
.text 5249059 5248707 -352 -0.0
tv-casting-app debug (read only) 9929393 9928801 -592 -0.0
(read/write) 343616 340800 -2816 -0.8
.bss 158744 155864 -2880 -1.8
.rodata 384760 384568 -192 -0.0
.text 9077443 9077091 -352 -0.0
telink light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 936768 934424 -2344 -0.3
bss 77508 75688 -1820 -2.3
text 703352 703036 -316 -0.0
shell tlsr9518adk80d (read/write) 676156 674196 -1960 -0.3
bss 73452 71892 -1560 -2.1
text 461832 461578 -254 -0.1
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 416f6a3 7cb236a change % change
bl602 lighting-app bl602 (read/write) 1444122 1444122 0 0.0
.bss 85720 85720 0 0.0
.data 9512 9512 0 0.0
.rodata 159220 159220 0 0.0
.text 1109010 1109010 0 0.0
bl602+mfd (read/write) 1458538 1458538 0 0.0
.bss 85888 85888 0 0.0
.data 9488 9488 0 0.0
.rodata 158180 158180 0 0.0
.text 1124328 1124328 0 0.0
bl602+rpc (read/write) 1491506 1491506 0 0.0
.bss 93760 93760 0 0.0
.data 9888 9888 0 0.0
.rodata 166788 166788 0 0.0
.text 1140400 1140400 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209431 1209431 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108816 108816 0 0.0
.text 978764 978764 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220527 1220527 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107756 107756 0 0.0
.text 990774 990774 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1301175 1301175 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124188 124188 0 0.0
.text 1053728 1053728 0 0.0
bl706-eth (read/write) 1026209 1026209 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101904 101904 0 0.0
.text 768982 768982 0 0.0
bl706-wifi (read/write) 1261378 1261378 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122904 122904 0 0.0
.text 1001382 1001382 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1179028 1179028 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102820 102820 0 0.0
.text 971874 971874 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190168 1190168 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101760 101760 0 0.0
.text 983940 983940 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 784020 784020 0 0.0
(read/write) 176660 176660 0 0.0
.bss 98604 98604 0 0.0
.data 3588 3588 0 0.0
.rodata 83092 83092 0 0.0
.text 700664 700664 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799820 799820 0 0.0
(read/write) 187148 187148 0 0.0
.bss 109092 109092 0 0.0
.data 3588 3588 0 0.0
.rodata 77084 77084 0 0.0
.text 722468 722468 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788580 788580 0 0.0
(read/write) 181268 181268 0 0.0
.bss 103212 103212 0 0.0
.data 3588 3588 0 0.0
.rodata 103996 103996 0 0.0
.text 684320 684320 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 740980 740980 0 0.0
(read/write) 175636 175636 0 0.0
.bss 97344 97344 0 0.0
.data 3580 3580 0 0.0
.rodata 78756 78756 0 0.0
.text 661960 661960 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726636 726636 0 0.0
(read/write) 175844 175844 0 0.0
.bss 97568 97568 0 0.0
.data 3572 3572 0 0.0
.rodata 74540 74540 0 0.0
.text 651832 651832 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 588918 588918 0 0.0
(read/write) 208372 208372 0 0.0
.bss 201596 201596 0 0.0
.data 1652 1652 0 0.0
.rodata 87654 87654 0 0.0
.text 499144 499144 0 0.0
lock CC3235SF_LAUNCHXL (read only) 634766 634766 0 0.0
(read/write) 208636 208636 0 0.0
.bss 202000 202000 0 0.0
.data 1516 1516 0 0.0
.rodata 108414 108414 0 0.0
.text 524228 524228 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570727 568431 -2296 -0.4
.app_xip_area 460637 460165 -472 -0.1
.bss 64908 63084 -1824 -2.8
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552807 550511 -2296 -0.4
.app_xip_area 438045 437573 -472 -0.1
.bss 69572 67748 -1824 -2.6
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573479 571191 -2288 -0.4
.app_xip_area 464885 464421 -464 -0.1
.bss 63452 61628 -1824 -2.9
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565919 563623 -2296 -0.4
.app_xip_area 454141 453669 -472 -0.1
.bss 66556 64732 -1824 -2.7
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069940 1069940 0 0.0
.bss 180008 180008 0 0.0
.data 3432 3432 0 0.0
.text 886480 886480 0 0.0
lock-app BRD4338a (read/write) 961412 961404 -8 -0.0
.bss 213032 213032 0 0.0
.data 29448 29448 0 0.0
.text 699568 699560 -8 -0.0
window-app BRD4187C (read/write) 1136904 1136896 -8 -0.0
.bss 164600 164600 0 0.0
.data 3336 3336 0 0.0
.text 968948 968940 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214720 1214720 0 0.0
(read/write) 1751288 1751288 0 0.0
.dram0.bss 74568 74568 0 0.0
.dram0.data 13652 13652 0 0.0
.flash.rodata 253528 253528 0 0.0
.flash.text 1214720 1214720 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256495 1256263 -232 -0.0
(read/write) 537684 535700 -1984 -0.4
.dram0.bss 81320 79496 -1824 -2.2
.dram0.data 35196 35196 0 0.0
.flash.rodata 285248 285088 -160 -0.1
.flash.text 1250331 1250099 -232 -0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2656821 2656821 0 0.0
(read/write) 130384 130384 0 0.0
.bss 47016 47016 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75160 75160 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 184464 184464 0 0.0
.text 2293077 2293077 0 0.0
all-clusters-app debug (read only) 5970057 5970057 0 0.0
(read/write) 481992 481992 0 0.0
.bss 135296 135296 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334712 334712 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 350832 350832 0 0.0
.text 5183795 5183795 0 0.0
all-clusters-minimal-app debug (read only) 5254049 5254049 0 0.0
(read/write) 238008 238008 0 0.0
.bss 128160 128160 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98296 98296 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290058 290058 0 0.0
.text 4727219 4727219 0 0.0
bridge-app debug (read only) 4644649 4644649 0 0.0
(read/write) 218888 218888 0 0.0
.bss 118688 118688 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87248 87248 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230474 230474 0 0.0
.text 4191827 4191827 0 0.0
chip-tool debug (read only) 12112865 12112865 0 0.0
(read/write) 523456 523456 0 0.0
.bss 95032 95032 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416064 416064 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451577 451577 0 0.0
.text 10952691 10952691 0 0.0
chip-tool-ipv6only arm64 (read only) 11443780 11443780 0 0.0
(read/write) 588712 588712 0 0.0
.bss 104008 104008 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 456016 456016 0 0.0
.dynamic 512 512 0 0.0
.got 17104 17104 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356340 356340 0 0.0
.text 10205544 10205544 0 0.0
lighting-app debug+rpc+ui (read only) 5567897 5567897 0 0.0
(read/write) 227656 227656 0 0.0
.bss 119632 119632 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95616 95616 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354292 354292 0 0.0
.text 4964867 4964867 0 0.0
lock-app debug (read only) 4711905 4711905 0 0.0
(read/write) 206112 206112 0 0.0
.bss 113960 113960 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81256 81256 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256394 256394 0 0.0
.text 4242227 4242227 0 0.0
ota-provider-app debug (read only) 4319601 4319601 0 0.0
(read/write) 194616 194616 0 0.0
.bss 113760 113760 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70544 70544 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209290 209290 0 0.0
.text 3915539 3915539 0 0.0
ota-requestor-app debug (read only) 4450177 4450177 0 0.0
(read/write) 198984 198984 0 0.0
.bss 114656 114656 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215338 215338 0 0.0
.text 4035523 4035523 0 0.0
shell debug (read only) 2941337 2940777 -560 -0.0
(read/write) 157424 154608 -2816 -1.8
.bss 62800 59952 -2848 -4.5
.data 1424 1424 0 0.0
.data.rel.ro 87400 87432 32 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 187744 187584 -160 -0.1
.text 2578194 2577842 -352 -0.0
thermostat-no-ble arm64 (read only) 4443916 4443916 0 0.0
(read/write) 244072 244072 0 0.0
.bss 122264 122264 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104520 104520 0 0.0
.dynamic 512 512 0 0.0
.got 8720 8720 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160436 160436 0 0.0
.text 3946360 3946360 0 0.0
tv-app debug (read only) 5788401 5787841 -560 -0.0
(read/write) 353816 351000 -2816 -0.8
.bss 244528 241648 -2880 -1.2
.data 6560 6560 0 0.0
.data.rel.ro 95432 95496 64 0.1
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295274 295114 -160 -0.1
.text 5249059 5248707 -352 -0.0
tv-casting-app debug (read only) 9929393 9928801 -592 -0.0
(read/write) 343616 340800 -2816 -0.8
.bss 158744 155864 -2880 -1.8
.data 3008 3008 0 0.0
.data.rel.ro 174960 175024 64 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384760 384568 -192 -0.0
.text 9077443 9077091 -352 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535992 2535992 0 0.0
.bss 220744 220744 0 0.0
.data 5216 5216 0 0.0
.text 1498676 1498676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1059160 1059160 0 0.0
bss 139123 139123 0 0.0
rodata 101560 101560 0 0.0
text 771260 771260 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1236496 1236496 0 0.0
bss 137395 137395 0 0.0
rodata 151392 151392 0 0.0
text 797676 797676 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1007152 1007152 0 0.0
bss 138029 138029 0 0.0
rodata 88824 88824 0 0.0
text 733004 733004 0 0.0
nxp contact k32w0+release (read only) 575772 575772 0 0.0
(read/write) 83140 83140 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575236 575236 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703164 703164 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589720 589720 0 0.0
light k32w0+release (read only) 609768 609768 0 0.0
(read/write) 82600 82600 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609232 609232 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 795024 795024 0 0.0
.bss 80736 80736 0 0.0
.data 2064 2064 0 0.0
.text 672856 672856 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832056 832056 0 0.0
(read/write) 1807324 1807324 0 0.0
.bss 198540 198540 0 0.0
.data 2744 2744 0 0.0
.text 1597652 1597652 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835152 835152 0 0.0
(read/write) 1728772 1728772 0 0.0
.bss 195468 195468 0 0.0
.data 2720 2720 0 0.0
.text 1522196 1522196 0 0.0
light cy8ckit_062s2_43012 (read only) 841872 841872 0 0.0
(read/write) 1647388 1647388 0 0.0
.bss 188932 188932 0 0.0
.data 2536 2536 0 0.0
.text 1447532 1447532 0 0.0
lock cy8ckit_062s2_43012 (read only) 814808 814808 0 0.0
(read/write) 1676068 1676068 0 0.0
.bss 216012 216012 0 0.0
.data 2520 2520 0 0.0
.text 1449148 1449148 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133348 1133348 0 0.0
.bss 102620 102620 0 0.0
.data 856 856 0 0.0
.text 645728 645728 0 0.0
lock-app qpg6105+debug (read/write) 1093172 1093172 0 0.0
.bss 97292 97292 0 0.0
.data 860 860 0 0.0
.text 605556 605556 0 0.0
stm32 light STM32WB5MM-DK (read/write) 604953 604953 0 0.0
.bss 128468 128468 0 0.0
.data 688 688 0 0.0
.rodata 80532 80532 0 0.0
.text 385520 385520 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833650 833650 0 0.0
bss 49852 49852 0 0.0
text 624328 624328 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1095936 1095936 0 0.0
bss 101520 101520 0 0.0
text 796950 796950 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058460 1058460 0 0.0
bss 110016 110016 0 0.0
text 772312 772312 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914148 914148 0 0.0
bss 92772 92772 0 0.0
text 655962 655962 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836018 836018 0 0.0
bss 49896 49896 0 0.0
text 626760 626760 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936768 934424 -2344 -0.3
bss 77508 75688 -1820 -2.3
text 703352 703036 -316 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090548 1090548 0 0.0
bss 99864 99864 0 0.0
text 793958 793958 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911136 911136 0 0.0
bss 69176 69176 0 0.0
text 660162 660162 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932944 932944 0 0.0
bss 92476 92476 0 0.0
text 674946 674946 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833552 833552 0 0.0
bss 58140 58140 0 0.0
text 623738 623738 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799672 799672 0 0.0
bss 56068 56068 0 0.0
text 598640 598640 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676156 674196 -1960 -0.3
bss 73452 71892 -1560 -2.1
text 461832 461578 -254 -0.1
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843862 843862 0 0.0
bss 51524 51524 0 0.0
text 633404 633404 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858537 858537 0 0.0
bss 59692 59692 0 0.0
text 642202 642202 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825236 825236 0 0.0
bss 56400 56400 0 0.0
text 618212 618212 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838280 838280 0 0.0
bss 58356 58356 0 0.0
text 626038 626038 0 0.0

@pullapprove pullapprove bot requested a review from kiel-apple April 30, 2024 17:36
@pullapprove pullapprove bot requested review from bauerschwan and fessehaeve May 1, 2024 15:57
@Damian-Nordic
[shell] Reduce memory usage and boileplate code for subcommands
47b8d45 
1. Add lightweight CommandSet class to prevent instantiating
   Shell::Engine, which allows for dynamic command registration,
   just to create a subshell with a fixed number of subcommands.

   This slightly reduces the RAM usage.
   Additionally, the command set automatically prints the help
   texts if no command or "help" command has been submitted.
2. Add SubShellCommand templatized command handler to remove
   the boilerplate associated with creating a subshell.
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

PR #33243: Size comparison from f4e02d4 to 47b8d45

Increases (3 builds for linux)
platform target config section f4e02d4 47b8d45 change % change
linux shell debug .data.rel.ro 88672 88704 32 0.0
tv-app debug .data.rel.ro 96312 96392 80 0.1
tv-casting-app debug .data.rel.ro 176272 176336 64 0.0
Decreases (21 builds for cyw30739, efr32, esp32, linux, telink)
platform target config section f4e02d4 47b8d45 change % change
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742331 740067 -2264 -0.3
.app_xip_area 660565 660125 -440 -0.1
.bss 75364 73540 -1824 -2.4
CYW30739B2-P5-EVK-02 (read/write) 757975 755703 -2272 -0.3
.app_xip_area 673009 672561 -448 -0.1
.bss 77220 75396 -1824 -2.4
CYW30739B2-P5-EVK-03 (read/write) 757975 755703 -2272 -0.3
.app_xip_area 673009 672561 -448 -0.1
.bss 77220 75396 -1824 -2.4
CYW930739M2EVB-02 (read/write) 714187 711923 -2264 -0.3
.app_xip_area 637353 636913 -440 -0.1
.bss 70488 68664 -1824 -2.6
light-switch CYW30739B2-P5-EVK-01 (read/write) 679851 677595 -2256 -0.3
.app_xip_area 602373 601933 -440 -0.1
.bss 70956 69140 -1816 -2.6
CYW30739B2-P5-EVK-02 (read/write) 695183 692919 -2264 -0.3
.app_xip_area 614593 614145 -448 -0.1
.bss 72812 70996 -1816 -2.5
CYW30739B2-P5-EVK-03 (read/write) 695183 692919 -2264 -0.3
.app_xip_area 614593 614145 -448 -0.1
.bss 72812 70996 -1816 -2.5
lock CYW30739B2-P5-EVK-01 (read/write) 698387 696131 -2256 -0.3
.app_xip_area 617893 617453 -440 -0.1
.bss 74004 72188 -1816 -2.5
CYW30739B2-P5-EVK-02 (read/write) 713799 711535 -2264 -0.3
.app_xip_area 630193 629745 -448 -0.1
.bss 75860 74044 -1816 -2.4
CYW30739B2-P5-EVK-03 (read/write) 713799 711535 -2264 -0.3
.app_xip_area 630193 629745 -448 -0.1
.bss 75860 74044 -1816 -2.4
thermostat CYW30739B2-P5-EVK-01 (read/write) 660915 658643 -2272 -0.3
.app_xip_area 586453 586005 -448 -0.1
.bss 68164 66340 -1824 -2.7
CYW30739B2-P5-EVK-02 (read/write) 676559 674295 -2264 -0.3
.app_xip_area 598889 598449 -440 -0.1
.bss 70028 68204 -1824 -2.6
CYW30739B2-P5-EVK-03 (read/write) 676559 674295 -2264 -0.3
.app_xip_area 598889 598449 -440 -0.1
.bss 70028 68204 -1824 -2.6
efr32 lock-app BRD4338a (read/write) 962300 962292 -8 -0.0
.text 700392 700384 -8 -0.0
window-app BRD4187C (read/write) 1135760 1135752 -8 -0.0
.text 967828 967820 -8 -0.0
esp32 all-clusters-app m5stack (read only) 1256479 1256271 -208 -0.0
(read/write) 538148 536156 -1992 -0.4
.dram0.bss 81384 79560 -1824 -2.2
.flash.rodata 285648 285480 -168 -0.1
.flash.text 1250315 1250107 -208 -0.0
linux shell debug (read only) 3004473 3003945 -528 -0.0
(read/write) 159448 156632 -2816 -1.8
.bss 63504 60656 -2848 -4.5
.rodata 191232 191072 -160 -0.1
.text 2634162 2633842 -320 -0.0
tv-app debug (read only) 5828641 5828129 -512 -0.0
(read/write) 355296 352512 -2784 -0.8
.bss 245136 242256 -2880 -1.2
.rodata 297994 297834 -160 -0.1
.text 5284323 5284019 -304 -0.0
tv-casting-app debug (read only) 9992065 9991537 -528 -0.0
(read/write) 345776 342960 -2816 -0.8
.bss 159512 156632 -2880 -1.8
.rodata 388248 388088 -160 -0.0
.text 9132755 9132435 -320 -0.0
telink light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 937436 935116 -2320 -0.2
bss 77540 75720 -1820 -2.3
text 703626 703346 -280 -0.0
shell tlsr9518adk80d (read/write) 676420 674484 -1936 -0.3
bss 73388 71828 -1560 -2.1
text 461830 461612 -218 -0.0
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section f4e02d4 47b8d45 change % change
bl602 lighting-app bl602 (read/write) 1444854 1444854 0 0.0
.bss 85776 85776 0 0.0
.data 9512 9512 0 0.0
.rodata 159424 159424 0 0.0
.text 1109478 1109478 0 0.0
bl602+mfd (read/write) 1459278 1459278 0 0.0
.bss 85952 85952 0 0.0
.data 9488 9488 0 0.0
.rodata 158384 158384 0 0.0
.text 1124796 1124796 0 0.0
bl602+rpc (read/write) 1492526 1492526 0 0.0
.bss 93824 93824 0 0.0
.data 9896 9896 0 0.0
.rodata 167000 167000 0 0.0
.text 1141124 1141124 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1210827 1210827 0 0.0
.bss 11185 11185 0 0.0
.data 3720 3720 0 0.0
.rodata 108976 108976 0 0.0
.text 979936 979936 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1221915 1221915 0 0.0
.bss 11361 11361 0 0.0
.data 3696 3696 0 0.0
.rodata 107916 107916 0 0.0
.text 991946 991946 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1302291 1302291 0 0.0
.bss 19669 19669 0 0.0
.data 4256 4256 0 0.0
.rodata 124348 124348 0 0.0
.text 1054644 1054644 0 0.0
bl706-eth (read/write) 1027861 1027861 0 0.0
.bss 23760 23760 0 0.0
.data 3264 3264 0 0.0
.rodata 102032 102032 0 0.0
.text 770452 770452 0 0.0
bl706-wifi (read/write) 1261922 1261922 0 0.0
.bss 10645 10645 0 0.0
.data 3712 3712 0 0.0
.rodata 123112 123112 0 0.0
.text 1001646 1001646 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1180404 1180404 0 0.0
.bss 16396 16396 0 0.0
.data 5080 5080 0 0.0
.rodata 102980 102980 0 0.0
.text 973050 973050 0 0.0
bl702l+mfd (read/write) 1192320 1192320 0 0.0
.bss 16572 16572 0 0.0
.data 5064 5064 0 0.0
.rodata 101920 101920 0 0.0
.text 985372 985372 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 798596 798596 0 0.0
(read/write) 177660 177660 0 0.0
.bss 99572 99572 0 0.0
.data 3604 3604 0 0.0
.rodata 85236 85236 0 0.0
.text 713096 713096 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 813848 813848 0 0.0
(read/write) 188132 188132 0 0.0
.bss 110060 110060 0 0.0
.data 3596 3596 0 0.0
.rodata 78816 78816 0 0.0
.text 734768 734768 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 803172 803172 0 0.0
(read/write) 182252 182252 0 0.0
.bss 104180 104180 0 0.0
.data 3596 3596 0 0.0
.rodata 106140 106140 0 0.0
.text 696768 696768 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 755428 755428 0 0.0
(read/write) 176612 176612 0 0.0
.bss 98304 98304 0 0.0
.data 3588 3588 0 0.0
.rodata 80900 80900 0 0.0
.text 674264 674264 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 741140 741140 0 0.0
(read/write) 176844 176844 0 0.0
.bss 98536 98536 0 0.0
.data 3588 3588 0 0.0
.rodata 76676 76676 0 0.0
.text 664200 664200 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 606558 606558 0 0.0
(read/write) 209596 209596 0 0.0
.bss 202812 202812 0 0.0
.data 1660 1660 0 0.0
.rodata 89718 89718 0 0.0
.text 514716 514716 0 0.0
lock CC3235SF_LAUNCHXL (read only) 652446 652446 0 0.0
(read/write) 209852 209852 0 0.0
.bss 203208 203208 0 0.0
.data 1524 1524 0 0.0
.rodata 110478 110478 0 0.0
.text 539848 539848 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 (read/write) 742331 740067 -2264 -0.3
.app_xip_area 660565 660125 -440 -0.1
.bss 75364 73540 -1824 -2.4
.data 940 940 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 757975 755703 -2272 -0.3
.app_xip_area 673009 672561 -448 -0.1
.bss 77220 75396 -1824 -2.4
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 757975 755703 -2272 -0.3
.app_xip_area 673009 672561 -448 -0.1
.bss 77220 75396 -1824 -2.4
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW930739M2EVB-02 (read/write) 714187 711923 -2264 -0.3
.app_xip_area 637353 636913 -440 -0.1
.bss 70488 68664 -1824 -2.6
.data 884 884 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
light-switch CYW30739B2-P5-EVK-01 (read/write) 679851 677595 -2256 -0.3
.app_xip_area 602373 601933 -440 -0.1
.bss 70956 69140 -1816 -2.6
.data 1060 1060 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 695183 692919 -2264 -0.3
.app_xip_area 614593 614145 -448 -0.1
.bss 72812 70996 -1816 -2.5
.data 2316 2316 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 695183 692919 -2264 -0.3
.app_xip_area 614593 614145 -448 -0.1
.bss 72812 70996 -1816 -2.5
.data 2316 2316 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
lock CYW30739B2-P5-EVK-01 (read/write) 698387 696131 -2256 -0.3
.app_xip_area 617893 617453 -440 -0.1
.bss 74004 72188 -1816 -2.5
.data 1028 1028 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 713799 711535 -2264 -0.3
.app_xip_area 630193 629745 -448 -0.1
.bss 75860 74044 -1816 -2.4
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 713799 711535 -2264 -0.3
.app_xip_area 630193 629745 -448 -0.1
.bss 75860 74044 -1816 -2.4
.data 2284 2284 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
thermostat CYW30739B2-P5-EVK-01 (read/write) 660915 658643 -2272 -0.3
.app_xip_area 586453 586005 -448 -0.1
.bss 68164 66340 -1824 -2.7
.data 836 836 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-02 (read/write) 676559 674295 -2264 -0.3
.app_xip_area 598889 598449 -440 -0.1
.bss 70028 68204 -1824 -2.6
.data 2180 2180 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
CYW30739B2-P5-EVK-03 (read/write) 676559 674295 -2264 -0.3
.app_xip_area 598889 598449 -440 -0.1
.bss 70028 68204 -1824 -2.6
.data 2180 2180 0 0.0
.rodata 0 0 0 0.0
.text 2040 2040 0 0.0
efr32 lighting-app BRD4187C (read/write) 1072076 1072076 0 0.0
.bss 180008 180008 0 0.0
.data 3448 3448 0 0.0
.text 888600 888600 0 0.0
lock-app BRD4338a (read/write) 962300 962292 -8 -0.0
.bss 213092 213092 0 0.0
.data 29448 29448 0 0.0
.text 700392 700384 -8 -0.0
window-app BRD4187C (read/write) 1135760 1135752 -8 -0.0
.bss 164560 164560 0 0.0
.data 3352 3352 0 0.0
.text 967828 967820 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214912 1214912 0 0.0
(read/write) 1751544 1751544 0 0.0
.dram0.bss 74624 74624 0 0.0
.dram0.data 13660 13660 0 0.0
.flash.rodata 253736 253736 0 0.0
.flash.text 1214912 1214912 0 0.0
.iram0.text 75570 75570 0 0.0
m5stack (read only) 1256479 1256271 -208 -0.0
(read/write) 538148 536156 -1992 -0.4
.dram0.bss 81384 79560 -1824 -2.2
.dram0.data 35196 35196 0 0.0
.flash.rodata 285648 285480 -168 -0.1
.flash.text 1250315 1250107 -208 -0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2720509 2720509 0 0.0
(read/write) 132536 132536 0 0.0
.bss 47752 47752 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 187472 187472 0 0.0
.text 2350005 2350005 0 0.0
all-clusters-app debug (read only) 6033257 6033257 0 0.0
(read/write) 484048 484048 0 0.0
.bss 136032 136032 0 0.0
.data 4592 4592 0 0.0
.data.rel.ro 335976 335976 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1448 1448 0 0.0
.rodata 354320 354320 0 0.0
.text 5240195 5240195 0 0.0
all-clusters-minimal-app debug (read only) 5316665 5316665 0 0.0
(read/write) 240000 240000 0 0.0
.bss 128896 128896 0 0.0
.data 4496 4496 0 0.0
.data.rel.ro 99512 99512 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 1176 1176 0 0.0
.rodata 293130 293130 0 0.0
.text 4783603 4783603 0 0.0
bridge-app debug (read only) 4707209 4707209 0 0.0
(read/write) 220912 220912 0 0.0
.bss 119424 119424 0 0.0
.data 6272 6272 0 0.0
.data.rel.ro 88480 88480 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 233514 233514 0 0.0
.text 4248179 4248179 0 0.0
chip-tool debug (read only) 12156417 12156417 0 0.0
(read/write) 524328 524328 0 0.0
.bss 95000 95000 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 416928 416928 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 454457 454457 0 0.0
.text 10991203 10991203 0 0.0
chip-tool-ipv6only arm64 (read only) 11483548 11483548 0 0.0
(read/write) 589896 589896 0 0.0
.bss 104008 104008 0 0.0
.data 4536 4536 0 0.0
.data.rel.ro 457024 457024 0 0.0
.dynamic 512 512 0 0.0
.got 17264 17264 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 358460 358460 0 0.0
.text 10240280 10240280 0 0.0
fabric-bridge-app debug (read only) 4573465 4573465 0 0.0
(read/write) 212888 212888 0 0.0
.bss 114976 114976 0 0.0
.data 5056 5056 0 0.0
.data.rel.ro 86160 86160 0 0.0
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 226922 226922 0 0.0
.text 4123523 4123523 0 0.0
lighting-app debug+rpc+ui (read only) 5630769 5630769 0 0.0
(read/write) 229712 229712 0 0.0
.bss 120368 120368 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 96912 96912 0 0.0
.dynamic 672 672 0 0.0
.got 5864 5864 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 357332 357332 0 0.0
.text 5021491 5021491 0 0.0
lock-app debug (read only) 4768249 4768249 0 0.0
(read/write) 208040 208040 0 0.0
.bss 114664 114664 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 82472 82472 0 0.0
.dynamic 624 624 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 259370 259370 0 0.0
.text 4292435 4292435 0 0.0
ota-provider-app debug (read only) 4381001 4381001 0 0.0
(read/write) 196640 196640 0 0.0
.bss 114528 114528 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 71728 71728 0 0.0
.dynamic 624 624 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 211754 211754 0 0.0
.text 3971459 3971459 0 0.0
ota-requestor-app debug (read only) 4511689 4511689 0 0.0
(read/write) 201008 201008 0 0.0
.bss 115424 115424 0 0.0
.data 4800 4800 0 0.0
.data.rel.ro 74848 74848 0 0.0
.dynamic 624 624 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 217834 217834 0 0.0
.text 4091523 4091523 0 0.0
shell debug (read only) 3004473 3003945 -528 -0.0
(read/write) 159448 156632 -2816 -1.8
.bss 63504 60656 -2848 -4.5
.data 1424 1424 0 0.0
.data.rel.ro 88672 88704 32 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 191232 191072 -160 -0.1
.text 2634162 2633842 -320 -0.0
thermostat-no-ble arm64 (read only) 4499100 4499100 0 0.0
(read/write) 247024 247024 0 0.0
.bss 123000 123000 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 105920 105920 0 0.0
.dynamic 512 512 0 0.0
.got 8992 8992 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 162164 162164 0 0.0
.text 3995592 3995592 0 0.0
tv-app debug (read only) 5828641 5828129 -512 -0.0
(read/write) 355296 352512 -2784 -0.8
.bss 245136 242256 -2880 -1.2
.data 6560 6560 0 0.0
.data.rel.ro 96312 96392 80 0.1
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 297994 297834 -160 -0.1
.text 5284323 5284019 -304 -0.0
tv-casting-app debug (read only) 9992065 9991537 -528 -0.0
(read/write) 345776 342960 -2816 -0.8
.bss 159512 156632 -2880 -1.8
.data 3008 3008 0 0.0
.data.rel.ro 176272 176336 64 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1232 1232 0 0.0
.rodata 388248 388088 -160 -0.0
.text 9132755 9132435 -320 -0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2536520 2536520 0 0.0
.bss 220808 220808 0 0.0
.data 5224 5224 0 0.0
.text 1499204 1499204 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1061220 1061220 0 0.0
bss 139161 139161 0 0.0
rodata 101876 101876 0 0.0
text 772860 772860 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1238316 1238316 0 0.0
bss 137517 137517 0 0.0
rodata 151420 151420 0 0.0
text 799344 799344 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1008860 1008860 0 0.0
bss 138059 138059 0 0.0
rodata 89132 89132 0 0.0
text 734408 734408 0 0.0
nxp contact k32w0+release (read only) 576332 576332 0 0.0
(read/write) 83188 83188 0 0.0
.bss 67888 67888 0 0.0
.data 2204 2204 0 0.0
.text 575796 575796 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 704172 704172 0 0.0
.bss 71240 71240 0 0.0
.data 2872 2872 0 0.0
.text 590680 590680 0 0.0
light k32w0+release (read only) 610544 610544 0 0.0
(read/write) 82648 82648 0 0.0
.bss 67336 67336 0 0.0
.data 2224 2224 0 0.0
.text 610008 610008 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 796128 796128 0 0.0
.bss 80776 80776 0 0.0
.data 2080 2080 0 0.0
.text 673904 673904 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 826248 826248 0 0.0
(read/write) 1827116 1827116 0 0.0
.bss 204340 204340 0 0.0
.data 2752 2752 0 0.0
.text 1611636 1611636 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 829344 829344 0 0.0
(read/write) 1748388 1748388 0 0.0
.bss 201268 201268 0 0.0
.data 2728 2728 0 0.0
.text 1536004 1536004 0 0.0
light cy8ckit_062s2_43012 (read only) 836064 836064 0 0.0
(read/write) 1666860 1666860 0 0.0
.bss 194732 194732 0 0.0
.data 2544 2544 0 0.0
.text 1461196 1461196 0 0.0
lock cy8ckit_062s2_43012 (read only) 809000 809000 0 0.0
(read/write) 1695508 1695508 0 0.0
.bss 221812 221812 0 0.0
.data 2528 2528 0 0.0
.text 1462780 1462780 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1134196 1134196 0 0.0
.bss 102636 102636 0 0.0
.data 864 864 0 0.0
.text 646576 646576 0 0.0
lock-app qpg6105+debug (read/write) 1093956 1093956 0 0.0
.bss 97308 97308 0 0.0
.data 876 876 0 0.0
.text 606340 606340 0 0.0
stm32 light STM32WB5MM-DK (read/write) 606737 606737 0 0.0
.bss 128500 128500 0 0.0
.data 696 696 0 0.0
.rodata 80708 80708 0 0.0
.text 387088 387088 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834118 834118 0 0.0
bss 49884 49884 0 0.0
text 624600 624600 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096468 1096468 0 0.0
bss 101552 101552 0 0.0
text 797278 797278 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058960 1058960 0 0.0
bss 110048 110048 0 0.0
text 772618 772618 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914600 914600 0 0.0
bss 92804 92804 0 0.0
text 656212 656212 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836486 836486 0 0.0
bss 49928 49928 0 0.0
text 627020 627020 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 937436 935116 -2320 -0.2
bss 77540 75720 -1820 -2.3
text 703626 703346 -280 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090800 1090800 0 0.0
bss 99876 99876 0 0.0
text 794086 794086 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911556 911556 0 0.0
bss 69208 69208 0 0.0
text 660386 660386 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933412 933412 0 0.0
bss 92516 92516 0 0.0
text 675198 675198 0 0.0
pump-app tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 831044 831044 0 0.0
bss 58172 58172 0 0.0
text 621024 621024 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 800140 800140 0 0.0
bss 56108 56108 0 0.0
text 598896 598896 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676420 674484 -1936 -0.3
bss 73388 71828 -1560 -2.1
text 461830 461612 -218 -0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 844338 844338 0 0.0
bss 51556 51556 0 0.0
text 633688 633688 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858965 858965 0 0.0
bss 59724 59724 0 0.0
text 642436 642436 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825688 825688 0 0.0
bss 56432 56432 0 0.0
text 618458 618458 0 0.0
window-covering tlsr9258a (read only) 52568 52568 0 0.0
(read/write) 835732 835732 0 0.0
bss 58388 58388 0 0.0
text 623292 623292 0 0.0

@mergify mergify bot merged commit bbd710a into project-chip:master May 15, 2024
67 checks passed
@Damian-Nordic Damian-Nordic deleted the shell-commandset branch May 15, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

Assignees
No one assigned
Labels
lib review - approved shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Damian-Nordic @andy31415 @yufengwangca @jmartinez-silabs