[nrfconnect] Introduced several platform configuration fixes #33194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recvmsg() is now implemented natively in Zephyr, so we are not supposed to define a custom one. Signed-off-by: Marcin Kajor <[email protected]>
... from the gnu17 configuration to avoid missing pthread types definitions (_pthreadtypes.h). This tricked the preprocessor the header was already included, hence we didn't get its content. Signed-off-by: Marcin Kajor <[email protected]>
The PICOLIB is now used by the default. NEWLIB_LIBC symbol is no longer selected by hostap. OpenThread selects NEWLIB_LIBC anyway. Signed-off-by: Marcin Kajor <[email protected]>
Co-authored-by: Damian Krolik <[email protected]>
This fixes a problem with Thread activity interrupting factory reset. This activity used to led to “Factory reset fail: -6”. Writing to the cleared nvm flash pages caused the problem. Signed-off-by: Patryk Lipinski <[email protected]> Signed-off-by: Michał Szablowski <[email protected]>
This commit reverts the previous optimization of reducing the number of packet buffers in the system. Additionally increase of stack size is needed to accomodate LTO. Signed-off-by: Łukasz Duda <[email protected]>
Currently, there is an issue with persistent subscriptions when multiple controllers create subscriptions.
kkasperczyk-no
force-pushed
the
platform_config_fixes
branch
from
cd1cfb1 to
35ab6b8
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
Damian-Nordic
approved these changes
Apr 26, 2024
|
PR #33194: Size comparison from cfb9404 to 35ab6b8 Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
Removed the defaults from Kconfig.mcuboot.defaults configuration that should not be set there: * BOOT_ENCRYPT_X - are configs without a prompt, so it should not be modified outside of the mcuboot module * SPI_NOR and NORDIC_QSPI_NOR - are set based on the device tree configuration, so we should not set it, as it may lead to configuration and dts mismatch. Signed-off-by: Kamil Kasperczyk <[email protected]>
kkasperczyk-no
force-pushed
the
platform_config_fixes
branch
from
35ab6b8 to
8acef46
Compare
|
PR #33194: Size comparison from cfb9404 to 8acef46 Increases (16 builds for telink)
Decreases (1 build for efr32)
Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink)
|
This reverts commit bb09061.
|
PR #33194: Size comparison from cfb9404 to be73977 Increases above 0.2%:
Increases (30 builds for nrfconnect, telink)
Decreases (1 build for efr32)
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Apr 26, 2024
kkasperczyk-no
added a commit
to kkasperczyk-no/connectedhomeip
that referenced
this pull request
May 8, 2024
…-chip#33194) * [nrfconnect] Disable Zephyr socket extensions The recvmsg() is now implemented natively in Zephyr, so we are not supposed to define a custom one. Signed-off-by: Marcin Kajor <[email protected]> * [nrfconnect] Remove D_SYS__PTHREADTYPES_H_ flag ... from the gnu17 configuration to avoid missing pthread types definitions (_pthreadtypes.h). This tricked the preprocessor the header was already included, hence we didn't get its content. Signed-off-by: Marcin Kajor <[email protected]> * [nrfconnect] Use newlib as a default libc implementation. The PICOLIB is now used by the default. NEWLIB_LIBC symbol is no longer selected by hostap. OpenThread selects NEWLIB_LIBC anyway. Signed-off-by: Marcin Kajor <[email protected]> * [zephyr] Added OpenThread dependencies to a few Kconfigs Co-authored-by: Damian Krolik <[email protected]> * [zephyr] Lock Thread stack before factory reset This fixes a problem with Thread activity interrupting factory reset. This activity used to led to “Factory reset fail: -6”. Writing to the cleared nvm flash pages caused the problem. Signed-off-by: Patryk Lipinski <[email protected]> Signed-off-by: Michał Szablowski <[email protected]> * [nrfconnect] Increase default number of packet buffers and stack size This commit reverts the previous optimization of reducing the number of packet buffers in the system. Additionally increase of stack size is needed to accomodate LTO. Signed-off-by: Łukasz Duda <[email protected]> * [nrfconnect] Select Experimental for persistent subscriptions Currently, there is an issue with persistent subscriptions when multiple controllers create subscriptions. * [nrfconnect] Fixed mcuboot default configuration Removed the defaults from Kconfig.mcuboot.defaults configuration that should not be set there: * BOOT_ENCRYPT_X - are configs without a prompt, so it should not be modified outside of the mcuboot module * SPI_NOR and NORDIC_QSPI_NOR - are set based on the device tree configuration, so we should not set it, as it may lead to configuration and dts mismatch. Signed-off-by: Kamil Kasperczyk <[email protected]> * Revert "[nrfconnect] Disable Zephyr socket extensions" This reverts commit bb09061. --------- Signed-off-by: Marcin Kajor <[email protected]> Signed-off-by: Patryk Lipinski <[email protected]> Signed-off-by: Michał Szablowski <[email protected]> Signed-off-by: Łukasz Duda <[email protected]> Signed-off-by: Kamil Kasperczyk <[email protected]> Co-authored-by: Marcin Kajor <[email protected]> Co-authored-by: Damian Krolik <[email protected]> Co-authored-by: Patryk Lipinski <[email protected]> Co-authored-by: Łukasz Duda <[email protected]> Co-authored-by: Arkadiusz Balys <[email protected]>
kkasperczyk-no
added a commit
that referenced
this pull request
May 8, 2024
* [nrfconnect] Disable Zephyr socket extensions The recvmsg() is now implemented natively in Zephyr, so we are not supposed to define a custom one. Signed-off-by: Marcin Kajor <[email protected]> * [nrfconnect] Remove D_SYS__PTHREADTYPES_H_ flag ... from the gnu17 configuration to avoid missing pthread types definitions (_pthreadtypes.h). This tricked the preprocessor the header was already included, hence we didn't get its content. Signed-off-by: Marcin Kajor <[email protected]> * [nrfconnect] Use newlib as a default libc implementation. The PICOLIB is now used by the default. NEWLIB_LIBC symbol is no longer selected by hostap. OpenThread selects NEWLIB_LIBC anyway. Signed-off-by: Marcin Kajor <[email protected]> * [zephyr] Added OpenThread dependencies to a few Kconfigs Co-authored-by: Damian Krolik <[email protected]> * [zephyr] Lock Thread stack before factory reset This fixes a problem with Thread activity interrupting factory reset. This activity used to led to “Factory reset fail: -6”. Writing to the cleared nvm flash pages caused the problem. Signed-off-by: Patryk Lipinski <[email protected]> Signed-off-by: Michał Szablowski <[email protected]> * [nrfconnect] Increase default number of packet buffers and stack size This commit reverts the previous optimization of reducing the number of packet buffers in the system. Additionally increase of stack size is needed to accomodate LTO. Signed-off-by: Łukasz Duda <[email protected]> * [nrfconnect] Select Experimental for persistent subscriptions Currently, there is an issue with persistent subscriptions when multiple controllers create subscriptions. * [nrfconnect] Fixed mcuboot default configuration Removed the defaults from Kconfig.mcuboot.defaults configuration that should not be set there: * BOOT_ENCRYPT_X - are configs without a prompt, so it should not be modified outside of the mcuboot module * SPI_NOR and NORDIC_QSPI_NOR - are set based on the device tree configuration, so we should not set it, as it may lead to configuration and dts mismatch. Signed-off-by: Kamil Kasperczyk <[email protected]> * Revert "[nrfconnect] Disable Zephyr socket extensions" This reverts commit bb09061. --------- Signed-off-by: Marcin Kajor <[email protected]> Signed-off-by: Patryk Lipinski <[email protected]> Signed-off-by: Michał Szablowski <[email protected]> Signed-off-by: Łukasz Duda <[email protected]> Signed-off-by: Kamil Kasperczyk <[email protected]> Co-authored-by: Marcin Kajor <[email protected]> Co-authored-by: Damian Krolik <[email protected]> Co-authored-by: Patryk Lipinski <[email protected]> Co-authored-by: Łukasz Duda <[email protected]> Co-authored-by: Arkadiusz Balys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced several platform configuration fixes that were missed during switch to NCS 2.6.0 version