-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix ChipCluster subscribe issue #33192
[Android] Fix ChipCluster subscribe issue #33192
Conversation
PR #33192: Size comparison from cfb9404 to b37babd Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@joonhaengHeo could you update the summary to describe the problem and fix? Right now the title says "fix subscribe issue" which does not say what the issue is and the description just says files modified. The issue number tagged also looks quite empty as it is just a title. |
I updated the summary to reflex the changes, thanks |
Fix #33176
-- For generated cluster subscribe API, we have not yet passed the value to the upper layer via onSuccess, we modify ChipCluster script where we call callback.onSuccess in onSuccess to fix this issue.
-- Add onResubscriptionAttempt callback as well.