-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NSCache for the MTRDevice attribute cache when possible. #33125
Merged
mergify
merged 3 commits into
project-chip:master
from
bzbarsky-apple:use-NSCache-in-MTRDevice
Apr 24, 2024
Merged
Use NSCache for the MTRDevice attribute cache when possible. #33125
mergify
merged 3 commits into
project-chip:master
from
bzbarsky-apple:use-NSCache-in-MTRDevice
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are storing our cluster data persistently, we don't have to ensure it's pinned in memory all the time. Use NSCache, and reload from storage as needed.
bzbarsky-apple
force-pushed
the
use-NSCache-in-MTRDevice
branch
from
April 23, 2024 22:33
0b59971
to
db118ac
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
April 23, 2024 22:33
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 23, 2024 22:33
PR #33125: Size comparison from a456135 to db118ac Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
jtung-apple
reviewed
Apr 23, 2024
jtung-apple
reviewed
Apr 23, 2024
jtung-apple
reviewed
Apr 23, 2024
Co-authored-by: Jeff Tung <[email protected]>
Co-authored-by: Jeff Tung <[email protected]>
PR #33125: Size comparison from a456135 to b433d18 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
jtung-apple
approved these changes
Apr 24, 2024
Fast-tracking platform-specific change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are storing our cluster data persistently, we don't have to ensure it's pinned in memory all the time. Use NSCache, and reload from storage as needed.