Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RAII for group session iteration #33122

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Use RAII for group session iteration #33122

merged 1 commit into from
Apr 24, 2024

Conversation

andy31415
Copy link
Contributor

This cherrypicks #32970 into the 1.3 branch.

@andy31415 @andreilitvin
Use RAII for group session iteration (project-chip#32970)
2c45ebe 
* Use RAII for iterator management

* Restyle

* Fix typo

* Fix naming a bit now that I made this a template

* Make it clear that class member is initialized
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

PR #33122: Size comparison from 4431f18 to 2c45ebe

Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 4431f18 2c45ebe change % change
bl602 lighting-app bl602 (read/write) 1438314 1438338 24 0.0
.text 1104358 1104378 20 0.0
bl602+mfd (read/write) 1452738 1452754 16 0.0
.text 1119676 1119696 20 0.0
bl602+rpc (read/write) 1485962 1485978 16 0.0
.text 1136004 1136024 20 0.0
bl702 lighting-app bl702 (read/write) 1202771 1202791 20 0.0
.text 973280 973300 20 0.0
bl702+mfd (read/write) 1213843 1213863 20 0.0
.text 985290 985310 20 0.0
bl702+rpc (read/write) 1294519 1294539 20 0.0
.text 1048244 1048264 20 0.0
bl706-eth (read/write) 1020453 1020473 20 0.0
.text 764374 764394 20 0.0
bl706-wifi (read/write) 1255082 1255118 36 0.0
.text 996250 996286 36 0.0
bl702l lighting-app bl702l (read/write) 1172360 1172892 532 0.0
.text 966390 966410 20 0.0
bl702l+mfd (read/write) 1183508 1183528 20 0.0
.text 978456 978476 20 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 774364 774388 24 0.0
.text 692252 692276 24 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 790724 790748 24 0.0
.text 714436 714460 24 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779404 779428 24 0.0
.text 676364 676388 24 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731612 731636 24 0.0
.text 653844 653868 24 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 717212 717236 24 0.0
.text 643668 643692 24 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583842 583874 32 0.0
.text 495092 495124 32 0.0
lock CC3235SF_LAUNCHXL (read only) 629090 629130 40 0.0
.text 519892 519932 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569515 569531 16 0.0
.app_xip_area 459253 459269 16 0.0
lock cyw930739m2evb_01 (read/write) 552163 552187 24 0.0
.app_xip_area 437141 437165 24 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572299 572315 16 0.0
.app_xip_area 463541 463557 16 0.0
switch cyw930739m2evb_01 (read/write) 565227 565251 24 0.0
.app_xip_area 453189 453213 24 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 934576 934600 24 0.0
.text 735172 735196 24 0.0
BRD4187C (read/write) 1111336 1111360 24 0.0
.text 912708 912732 24 0.0
window-app BRD4187C (read/write) 1158696 1158720 24 0.0
.text 987748 987772 24 0.0
esp32 all-clusters-app c3devkit (read only) 1211924 1211962 38 0.0
.flash.text 1211924 1211962 38 0.0
m5stack (read only) 1253987 1254071 84 0.0
.flash.text 1247823 1247907 84 0.0
k32w contact k32w0+release (read only) 605216 605232 16 0.0
.text 604680 604696 16 0.0
k32w1+release (read/write) 700108 700124 16 0.0
.text 586712 586728 16 0.0
light k32w0+release (read only) 607160 607192 32 0.0
.text 606624 606656 32 0.0
k32w1+release (read/write) 791512 791536 24 0.0
.text 669456 669480 24 0.0
linux air-purifier-app debug (read only) 2623677 2623885 208 0.0
.text 2261413 2261621 208 0.0
all-clusters-app debug (read only) 5929857 5930065 208 0.0
.text 5146915 5147123 208 0.0
all-clusters-minimal-app debug (read only) 5210689 5210897 208 0.0
.text 4687379 4687587 208 0.0
bridge-app debug (read only) 4605057 4605265 208 0.0
.text 4155587 4155795 208 0.0
chip-tool debug (read only) 12054817 12055025 208 0.0
.text 10898355 10898563 208 0.0
chip-tool-ipv6only arm64 (read only) 11373444 11373684 240 0.0
.text 10138792 10139032 240 0.0
lighting-app debug+rpc+ui (read only) 5528649 5528857 208 0.0
.text 4927795 4928003 208 0.0
lock-app debug (read only) 4672369 4672577 208 0.0
.text 4205619 4205827 208 0.0
ota-provider-app debug (read only) 4299857 4300065 208 0.0
.text 3898531 3898739 208 0.0
ota-requestor-app debug (read only) 4429297 4429505 208 0.0
.text 4017315 4017523 208 0.0
shell debug (read only) 2897897 2898105 208 0.0
.text 2539058 2539266 208 0.0
thermostat-no-ble arm64 (read only) 4418484 4418724 240 0.0
.text 3924136 3924376 240 0.0
tv-app debug (read only) 5737265 5737473 208 0.0
.text 5202995 5203203 208 0.0
tv-casting-app debug (read only) 9872361 9872569 208 0.0
.text 9023827 9024035 208 0.0
mbed lock-app-release cy8cproto_062_4343w (read/write) 2532672 2532736 64 0.0
.text 1495356 1495420 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1062792 1062824 32 0.0
text 779872 779896 24 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1224236 1224268 32 0.0
text 795860 795880 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1010368 1010400 32 0.0
text 741208 741232 24 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1799340 1799372 32 0.0
.text 1589980 1590012 32 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1721404 1721436 32 0.0
.text 1515196 1515228 32 0.0
light cy8ckit_062s2_43012 (read/write) 1640508 1640540 32 0.0
.text 1441028 1441060 32 0.0
lock cy8ckit_062s2_43012 (read/write) 1670124 1670156 32 0.0
.text 1443484 1443516 32 0.0
qpg lighting-app qpg6105+debug (read/write) 1130320 1130344 24 0.0
.text 642704 642728 24 0.0
lock-app qpg6105+debug (read/write) 1090296 1090320 24 0.0
.text 602676 602700 24 0.0
stm32 light STM32WB5MM-DK (read/write) 601549 601573 24 0.0
.text 383072 383096 24 0.0
telink air-quality-sensor-app tlsr9528a_retention (read/write) 824350 824390 40 0.0
text 617120 617158 38 0.0
all-clusters-app tlsr9518adk80d (read/write) 1093212 1093252 40 0.0
text 794242 794280 38 0.0
all-clusters-minimal-app tlsr9528a (read/write) 1050676 1050716 40 0.0
text 765556 765594 38 0.0
bridge-app tlsr9518adk80d (read/write) 911396 911436 40 0.0
text 653040 653078 38 0.0
contact-sensor-app tlsr9528a_retention (read/write) 825982 826022 40 0.0
text 618810 618848 38 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 931700 931740 40 0.0
text 698960 698998 38 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1074568 1074608 40 0.0
text 778424 778462 38 0.0
lock-app-dfu tlsr9528a (read/write) 904084 904124 40 0.0
text 654214 654252 38 0.0
ota-requestor-app tlsr9518adk80d (read/write) 930368 930408 40 0.0
text 672118 672156 38 0.0
pump-app tlsr9258a_retention (read/write) 828714 828754 40 0.0
text 621872 621910 38 0.0
pump-controller-app tlsr9518adk80d (read/write) 792288 792320 32 0.0
text 592550 592588 38 0.0
shell tlsr9518adk80d (read/write) 677312 677348 36 0.0
text 462570 462608 38 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 833518 833558 40 0.0
text 625180 625218 38 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 852249 852289 40 0.0
text 637260 637298 38 0.0
thermostat tlsr9518adk80d (read/write) 817936 817976 40 0.0
text 612234 612272 38 0.0
window-covering tlsr9258a (read/write) 836028 836068 40 0.0
text 627492 627530 38 0.0
Decreases (3 builds for efr32, linux)
platform target config section 4431f18 2c45ebe change % change
efr32 lock-app BRD4161A+wf200 (read/write) 1123668 1123660 -8 -0.0
.text 934036 934028 -8 -0.0
linux chip-tool-ipv6only arm64 (read/write) 588904 588664 -240 -0.0
thermostat-no-ble arm64 (read/write) 244464 244224 -240 -0.1
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section 4431f18 2c45ebe change % change
bl602 lighting-app bl602 (read/write) 1438314 1438338 24 0.0
.bss 85360 85360 0 0.0
.data 9504 9504 0 0.0
.rodata 158444 158444 0 0.0
.text 1104358 1104378 20 0.0
bl602+mfd (read/write) 1452738 1452754 16 0.0
.bss 85520 85520 0 0.0
.data 9480 9480 0 0.0
.rodata 157404 157404 0 0.0
.text 1119676 1119696 20 0.0
bl602+rpc (read/write) 1485962 1485978 16 0.0
.bss 93392 93392 0 0.0
.data 9880 9880 0 0.0
.rodata 166012 166012 0 0.0
.text 1136004 1136024 20 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1202771 1202791 20 0.0
.bss 11133 11133 0 0.0
.data 3688 3688 0 0.0
.rodata 107796 107796 0 0.0
.text 973280 973300 20 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1213843 1213863 20 0.0
.bss 11309 11309 0 0.0
.data 3664 3664 0 0.0
.rodata 106736 106736 0 0.0
.text 985290 985310 20 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1294519 1294539 20 0.0
.bss 19613 19613 0 0.0
.data 4224 4224 0 0.0
.rodata 123168 123168 0 0.0
.text 1048244 1048264 20 0.0
bl706-eth (read/write) 1020453 1020473 20 0.0
.bss 23708 23708 0 0.0
.data 3264 3264 0 0.0
.rodata 101128 101128 0 0.0
.text 764374 764394 20 0.0
bl706-wifi (read/write) 1255082 1255118 36 0.0
.bss 10577 10577 0 0.0
.data 3696 3696 0 0.0
.rodata 122128 122128 0 0.0
.text 996250 996286 36 0.0
bl702l lighting-app bl702l (read/write) 1172360 1172892 532 0.0
.bss 16328 16328 0 0.0
.data 5048 5048 0 0.0
.rodata 101800 101800 0 0.0
.text 966390 966410 20 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1183508 1183528 20 0.0
.bss 16504 16504 0 0.0
.data 5032 5032 0 0.0
.rodata 100740 100740 0 0.0
.text 978456 978476 20 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 774364 774388 24 0.0
(read/write) 168648 168648 0 0.0
.bss 90636 90636 0 0.0
.data 3568 3568 0 0.0
.rodata 81844 81844 0 0.0
.text 692252 692276 24 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 790724 790748 24 0.0
(read/write) 178896 178896 0 0.0
.bss 100884 100884 0 0.0
.data 3568 3568 0 0.0
.rodata 76020 76020 0 0.0
.text 714436 714460 24 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 779404 779428 24 0.0
(read/write) 173336 173336 0 0.0
.bss 95324 95324 0 0.0
.data 3568 3568 0 0.0
.rodata 102772 102772 0 0.0
.text 676364 676388 24 0.0
pump-app LP_EM_CC1354P10_6 (read only) 731612 731636 24 0.0
(read/write) 167616 167616 0 0.0
.bss 89368 89368 0 0.0
.data 3560 3560 0 0.0
.rodata 77500 77500 0 0.0
.text 653844 653868 24 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 717212 717236 24 0.0
(read/write) 167824 167824 0 0.0
.bss 89592 89592 0 0.0
.data 3552 3552 0 0.0
.rodata 73276 73276 0 0.0
.text 643668 643692 24 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 583842 583874 32 0.0
(read/write) 208000 208000 0 0.0
.bss 201228 201228 0 0.0
.data 1648 1648 0 0.0
.rodata 86626 86626 0 0.0
.text 495092 495124 32 0.0
lock CC3235SF_LAUNCHXL (read only) 629090 629130 40 0.0
(read/write) 208344 208344 0 0.0
.bss 201720 201720 0 0.0
.data 1504 1504 0 0.0
.rodata 107074 107074 0 0.0
.text 519892 519932 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569515 569531 16 0.0
.app_xip_area 459253 459269 16 0.0
.bss 65088 65088 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552163 552187 24 0.0
.app_xip_area 437141 437165 24 0.0
.bss 69840 69840 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 572299 572315 16 0.0
.app_xip_area 463541 463557 16 0.0
.bss 63624 63624 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565227 565251 24 0.0
.app_xip_area 453189 453213 24 0.0
.bss 66824 66824 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 934576 934600 24 0.0
.bss 197976 197976 0 0.0
.data 1404 1404 0 0.0
.text 735172 735196 24 0.0
BRD4187C (read/write) 1111336 1111360 24 0.0
.bss 195184 195184 0 0.0
.data 3424 3424 0 0.0
.text 912708 912732 24 0.0
lock-app BRD4161A+wf200 (read/write) 1123668 1123660 -8 -0.0
.bss 186804 186804 0 0.0
.data 2808 2808 0 0.0
.text 934036 934028 -8 -0.0
window-app BRD4187C (read/write) 1158696 1158720 24 0.0
.bss 167592 167592 0 0.0
.data 3336 3336 0 0.0
.text 987748 987772 24 0.0
esp32 all-clusters-app c3devkit (read only) 1211924 1211962 38 0.0
(read/write) 1749824 1749824 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252336 252336 0 0.0
.flash.text 1211924 1211962 38 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1253987 1254071 84 0.0
(read/write) 536424 536424 0 0.0
.dram0.bss 81264 81264 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284060 284060 0 0.0
.flash.text 1247823 1247907 84 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 605216 605232 16 0.0
(read/write) 79480 79480 0 0.0
.bss 67308 67308 0 0.0
.data 2188 2188 0 0.0
.text 604680 604696 16 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 700108 700124 16 0.0
.bss 71156 71156 0 0.0
.data 2856 2856 0 0.0
.text 586712 586728 16 0.0
light k32w0+release (read only) 607160 607192 32 0.0
(read/write) 79340 79340 0 0.0
.bss 67164 67164 0 0.0
.data 2192 2192 0 0.0
.text 606624 606656 32 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 791512 791536 24 0.0
.bss 80636 80636 0 0.0
.data 2056 2056 0 0.0
.text 669456 669480 24 0.0
linux air-purifier-app debug (read only) 2623677 2623885 208 0.0
(read/write) 129048 129048 0 0.0
.bss 46544 46544 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 74312 74312 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 184688 184688 0 0.0
.text 2261413 2261621 208 0.0
all-clusters-app debug (read only) 5929857 5930065 208 0.0
(read/write) 480520 480520 0 0.0
.bss 134848 134848 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 333688 333688 0 0.0
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1408 1408 0 0.0
.rodata 349456 349456 0 0.0
.text 5146915 5147123 208 0.0
all-clusters-minimal-app debug (read only) 5210689 5210897 208 0.0
(read/write) 236472 236472 0 0.0
.bss 127680 127680 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 97272 97272 0 0.0
.dynamic 624 624 0 0.0
.got 5272 5272 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 288490 288490 0 0.0
.text 4687379 4687587 208 0.0
bridge-app debug (read only) 4605057 4605265 208 0.0
(read/write) 217384 217384 0 0.0
.bss 118208 118208 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86208 86208 0 0.0
.dynamic 624 624 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 229066 229066 0 0.0
.text 4155587 4155795 208 0.0
chip-tool debug (read only) 12054817 12055025 208 0.0
(read/write) 522016 522016 0 0.0
.bss 94424 94424 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 415240 415240 0 0.0
.dynamic 624 624 0 0.0
.got 5760 5760 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 449401 449401 0 0.0
.text 10898355 10898563 208 0.0
chip-tool-ipv6only arm64 (read only) 11373444 11373684 240 0.0
(read/write) 588904 588664 -240 -0.0
.bss 103528 103528 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455128 455128 0 0.0
.dynamic 512 512 0 0.0
.got 17000 17000 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 354836 354836 0 0.0
.text 10138792 10139032 240 0.0
lighting-app debug+rpc+ui (read only) 5528649 5528857 208 0.0
(read/write) 226112 226112 0 0.0
.bss 119144 119144 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 94576 94576 0 0.0
.dynamic 672 672 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 354068 354068 0 0.0
.text 4927795 4928003 208 0.0
lock-app debug (read only) 4672369 4672577 208 0.0
(read/write) 204936 204936 0 0.0
.bss 113632 113632 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 80456 80456 0 0.0
.dynamic 624 624 0 0.0
.got 5192 5192 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 254986 254986 0 0.0
.text 4205619 4205827 208 0.0
ota-provider-app debug (read only) 4299857 4300065 208 0.0
(read/write) 193432 193432 0 0.0
.bss 113312 113312 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 69840 69840 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 208138 208138 0 0.0
.text 3898531 3898739 208 0.0
ota-requestor-app debug (read only) 4429297 4429505 208 0.0
(read/write) 197800 197800 0 0.0
.bss 114208 114208 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 72944 72944 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 214250 214250 0 0.0
.text 4017315 4017523 208 0.0
shell debug (read only) 2897897 2898105 208 0.0
(read/write) 156472 156472 0 0.0
.bss 62768 62768 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 86496 86496 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 185408 185408 0 0.0
.text 2539058 2539266 208 0.0
thermostat-no-ble arm64 (read only) 4418484 4418724 240 0.0
(read/write) 244464 244224 -240 -0.1
.bss 121832 121832 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 103680 103680 0 0.0
.dynamic 512 512 0 0.0
.got 8624 8624 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 159484 159484 0 0.0
.text 3924136 3924376 240 0.0
tv-app debug (read only) 5737265 5737473 208 0.0
(read/write) 352832 352832 0 0.0
.bss 244400 244400 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 94584 94584 0 0.0
.dynamic 624 624 0 0.0
.got 5488 5488 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 291882 291882 0 0.0
.text 5202995 5203203 208 0.0
tv-casting-app debug (read only) 9872361 9872569 208 0.0
(read/write) 340416 340416 0 0.0
.bss 156272 156272 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174240 174240 0 0.0
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 382680 382680 0 0.0
.text 9023827 9024035 208 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2532672 2532736 64 0.0
.bss 220480 220480 0 0.0
.data 5216 5216 0 0.0
.text 1495356 1495420 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1062792 1062824 32 0.0
bss 133119 133119 0 0.0
rodata 102600 102600 0 0.0
text 779872 779896 24 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1224236 1224268 32 0.0
bss 127155 127155 0 0.0
rodata 151200 151200 0 0.0
text 795860 795880 20 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1010368 1010400 32 0.0
bss 131977 131977 0 0.0
rodata 89864 89864 0 0.0
text 741208 741232 24 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832368 832368 0 0.0
(read/write) 1799340 1799372 32 0.0
.bss 198292 198292 0 0.0
.data 2680 2680 0 0.0
.text 1589980 1590012 32 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835520 835520 0 0.0
(read/write) 1721404 1721436 32 0.0
.bss 195172 195172 0 0.0
.data 2648 2648 0 0.0
.text 1515196 1515228 32 0.0
light cy8ckit_062s2_43012 (read only) 842248 842248 0 0.0
(read/write) 1640508 1640540 32 0.0
.bss 188636 188636 0 0.0
.data 2456 2456 0 0.0
.text 1441028 1441060 32 0.0
lock cy8ckit_062s2_43012 (read only) 815088 815088 0 0.0
(read/write) 1670124 1670156 32 0.0
.bss 215796 215796 0 0.0
.data 2456 2456 0 0.0
.text 1443484 1443516 32 0.0
qpg lighting-app qpg6105+debug (read/write) 1130320 1130344 24 0.0
.bss 102488 102488 0 0.0
.data 836 836 0 0.0
.text 642704 642728 24 0.0
lock-app qpg6105+debug (read/write) 1090296 1090320 24 0.0
.bss 97232 97232 0 0.0
.data 856 856 0 0.0
.text 602676 602700 24 0.0
stm32 light STM32WB5MM-DK (read/write) 601549 601573 24 0.0
.bss 128352 128352 0 0.0
.data 676 676 0 0.0
.rodata 79716 79716 0 0.0
.text 383072 383096 24 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 824350 824390 40 0.0
bss 49692 49692 0 0.0
text 617120 617158 38 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1093212 1093252 40 0.0
bss 101812 101812 0 0.0
text 794242 794280 38 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1050676 1050716 40 0.0
bss 110116 110116 0 0.0
text 765556 765594 38 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 911396 911436 40 0.0
bss 93148 93148 0 0.0
text 653040 653078 38 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 825982 826022 40 0.0
bss 49740 49740 0 0.0
text 618810 618848 38 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 931700 931740 40 0.0
bss 77740 77740 0 0.0
text 698960 698998 38 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1074568 1074608 40 0.0
bss 100228 100228 0 0.0
text 778424 778462 38 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 904084 904124 40 0.0
bss 69204 69204 0 0.0
text 654214 654252 38 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 930368 930408 40 0.0
bss 92728 92728 0 0.0
text 672118 672156 38 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 828714 828754 40 0.0
bss 49848 49848 0 0.0
text 621872 621910 38 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 792288 792320 32 0.0
bss 56048 56048 0 0.0
text 592550 592588 38 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 677312 677348 36 0.0
bss 73672 73672 0 0.0
text 462570 462608 38 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833518 833558 40 0.0
bss 51372 51372 0 0.0
text 625180 625218 38 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 852249 852289 40 0.0
bss 59524 59524 0 0.0
text 637260 637298 38 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 817936 817976 40 0.0
bss 56336 56336 0 0.0
text 612234 612272 38 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 836028 836068 40 0.0
bss 68112 68112 0 0.0
text 627492 627530 38 0.0

@woody-apple
Copy link
Contributor

Everything now is 1.3... We shouldn't cherry pick stuff in at this point. Will bring this up at the next SW standup (which will have to move times, sorry!)

@woody-apple
Copy link
Contributor

There are known issues in master right now for pairing issues, and failures, we should be encouraging (like all releases), master vs 1.3-branch.

@andy31415
Copy link
Contributor Author

There are known issues in master right now for pairing issues, and failures, we should be encouraging (like all releases), master vs 1.3-branch.

Based on comments from various members, it seems that people would like stable branches. While I agree that master is likely to have more fixes than a fixed branch in time, we cannot assume everyone uses master.

@andy31415 andy31415 merged commit 29ed2f9 into project-chip:v1.3-branch Apr 24, 2024
67 of 68 checks passed
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this pull request Jan 16, 2025
@adigie
Revert "Use RAII for group session iteration (project-chip#32970) (pr…
1791390 
…oject-chip#33122)"

This reverts commit 29ed2f9.

Signed-off-by: Adrian Gielniewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

Assignees
No one assigned
Labels
transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @woody-apple @yunhanw-google